mirror of
https://codeberg.org/forgejo-aneksajo/forgejo-aneksajo.git
synced 2025-04-21 21:56:43 +02:00
195388ba62
Previously, an external renderer that matched on an annexed file would only see its content streamed via `STDIN`, or a temporary file with a copy of its content would be generated and passed-by-filepath (with `IS_INPUT_FILE=true`). Whether that happens, is also subject to `MAX_DISPLAY_FILE_SIZE` (which defaults to 8MB). This was problematic, because annexed files tend to be large. Moreover, if present, they already exist as write-protected files on the file-system. Creating a copy is both expensive and serves no particular purpose. This commit changes how external renderers are called. 1) With `IS_INPUT_FILE=true`, the renderer is passed the true location of an annex key, if present, and an empty path, if not. 2) The original, repository-relative path of the rendering target is made available to the renderer via the `GITEA_RELATIVE_PATH` environment variable. To achieve a lean implementation, the `Blob` of the rendering target is passed on to the `RenderContext` (because the implementation of the annex-related functionality is centered on this dtype. This change makes it less costly to increase `MAX_DISPLAY_FILE_SIZE`, in order to make large, annexed files eligible for markup rendering, because no content copies will be made any longer. External renderers can now use the original file path, with the full original filename, including extensions, for decision making. For example, to detect particular compression formats based in a file name extension, or to alter the rendering based on contextual information encoded in the file path (e.g., a multi-file data structure with a particular organization pattern). Apart from the additional environment variable, there is no change to the handling of renderers that take their input via `STDIN` (i.e., `IS_INPUT_FILE=false`). Fixes #35. Reviewed-on: https://codeberg.org/matrss/forgejo-aneksajo/pulls/36 Reviewed-by: matrss <matrss@noreply.codeberg.org> Co-authored-by: Michael Hanke <michael.hanke@gmail.com> Co-committed-by: Michael Hanke <michael.hanke@gmail.com> |
||
|---|---|---|
| .. | ||
| asciicast | ||
| common | ||
| console | ||
| csv | ||
| external | ||
| markdown | ||
| mdstripper | ||
| orgmode | ||
| tests/repo/repo1_filepreview | ||
| camo.go | ||
| camo_test.go | ||
| file_preview.go | ||
| html.go | ||
| html_internal_test.go | ||
| html_test.go | ||
| renderer.go | ||
| renderer_test.go | ||
| sanitizer.go | ||
| sanitizer_test.go | ||