davrot/forgejo_backup
1
0
Fork 0
mirror of https://codeberg.org/davrot/forgejo.git synced 2025-06-24 20:00:02 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

ui: improve error pages (#7274)

Browse source 
* add testing
* make each page accessible via `/devtest/error`
* allow translating the `Page not found` part of the title
* code: improve consistency, remove unused
* devtest: put index page in a container to fix alignment
* 500: make navbar more like the real one, remove fake menu button
* deadcode: remove unused `func NotFound`: it was added in bdd32f152d and the only usage was removed in 1bfb0a24d8

Preview:
https://codeberg.org/attachments/1b75afb3-e898-410f-be02-f036a5400143

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7274
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Beowulf <beowulf@beocode.eu>
This commit is contained in:
0ko 2025-03-28 19:50:43 +00:00 • committed by David Rotermund
parent b704f1e43f
commit 0a1083b0bb
11 changed files with 106 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/integration/repo_test.go
View file

@ -1,4 +1,5 @@
// Copyright 2017 The Gitea Authors. All rights reserved.
// Copyright 2023 The Forgejo Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package integration
@ -691,7 +692,7 @@ func TestCommitView(t *testing.T) {
// Really ensure that 404 is being sent back.
doc := NewHTMLParser(t, resp.Body)
doc.AssertElement(t, `[aria-label="Page Not Found"]`, true)
doc.AssertElement(t, `[aria-label="Page not found"]`, true)
})
t.Run("Too short commit ID", func(t *testing.T) {