davrot/forgejo_backup
1
0
Fork 0
mirror of https://codeberg.org/davrot/forgejo.git synced 2025-07-10 16:00:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: Fix to delete cookie when AppSubURL is non-empty (#30375)

Browse source 
Cookies may exist on "/subpath" and "/subpath/" for some legacy reasons (eg: changed CookiePath behavior in code). The legacy cookie should be removed correctly.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Kyle D <kdumontnu@gmail.com>
(cherry picked from commit b18c04ebde94e23d97da4958173faea843d5344f)
This commit is contained in:
Jonathan Tran 2024-04-14 00:46:56 -04:00 • committed by Gergely Nagy
parent bf933f5ca4
commit 7ff74a47c8
No known key found for this signature in database
3 changed files with 37 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
modules/session/store.go
View file

@ -6,6 +6,9 @@ package session
import (
"net/http"
"code.gitea.io/gitea/modules/setting"
"code.gitea.io/gitea/modules/web/middleware"
"gitea.com/go-chi/session"
)
@ -18,6 +21,10 @@ type Store interface {
// RegenerateSession regenerates the underlying session and returns the new store
func RegenerateSession(resp http.ResponseWriter, req *http.Request) (Store, error) {
// Ensure that a cookie with a trailing slash does not take precedence over
// the cookie written by the middleware.
middleware.DeleteLegacySiteCookie(resp, setting.SessionConfig.CookieName)
s, err := session.RegenerateSession(resp, req)
return s, err
}