davrot/forgejo_backup
1
0
Fork 0
mirror of https://codeberg.org/davrot/forgejo.git synced 2025-05-30 09:00:02 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Simplify CheckUnitUser logic (#12854)

Browse source 
if check one user's unit in different repos, it's not necessary to
get user data every time.

Signed-off-by: a1012112796 <1012112796@qq.com>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
This commit is contained in:
赵智超 2020-09-16 07:49:34 +08:00 • committed by GitHub
parent 07995e2301
commit ec5677b7a2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 17 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

13
models/repo.go
View file

@ -425,20 +425,17 @@ func (repo *Repository) getUnits(e Engine) (err error) {
}
// CheckUnitUser check whether user could visit the unit of this repository
func (repo *Repository) CheckUnitUser(userID int64, isAdmin bool, unitType UnitType) bool {
return repo.checkUnitUser(x, userID, isAdmin, unitType)
func (repo *Repository) CheckUnitUser(user *User, unitType UnitType) bool {
return repo.checkUnitUser(x, user, unitType)
}
func (repo *Repository) checkUnitUser(e Engine, userID int64, isAdmin bool, unitType UnitType) bool {
if isAdmin {
func (repo *Repository) checkUnitUser(e Engine, user *User, unitType UnitType) bool {
if user.IsAdmin {
return true
}
user, err := getUserByID(e, userID)
if err != nil {
return false
}
perm, err := getUserRepoPermission(e, repo, user)
if err != nil {
log.Error("getUserRepoPermission(): %v", err)
return false
}