Michael Jerger
15bb6b7f92
[gitea] week 2025-22 cherry pick (gitea/main -> forgejo) ( #8198 )
...
## Checklist
- [x] go to the last cherry-pick PR (forgejo/forgejo#8040 ) to figure out how far it went: [gitea@d5bbaee64e](d5bbaee64eforgejo/forgejo#8198 )
- [ ] have the PR pass the CI
- end-to-end (specially important if there are actions related changes)
- [ ] add `run-end-to-end` label
- [ ] check the result
- [ ] write release notes
- [ ] assign reviewers
- [ ] 48h later, last call
- merge 1 hour after the last call
## Legend
- ❓ - No decision about the commit has been made.
- 🍒 - The commit has been cherry picked.
- ⏩ - The commit has been skipped.
- 💡 - The commit has been skipped, but should be ported to Forgejo.
- ✍️ - The commit has been skipped, and a port to Forgejo already exists.
## Commits
- 🍒 [`gitea`](17cfae82a56397da88d3https://github.com/go-gitea/gitea/pull/34556 ))
- 🍒 [`gitea`](b408bf2f0b46bc899d57https://github.com/go-gitea/gitea/pull/34602 ))
- 🍒 [`gitea`](9165ea871304332f31bfhttps://github.com/go-gitea/gitea/pull/34652 ))
- 🍒 [`gitea`](3f7dbbdaf12a9019fd04https://github.com/go-gitea/gitea/pull/34612 ))
- 🍒 [`gitea`](497b83b75d9a83cc7badhttps://github.com/go-gitea/gitea/pull/34577 ))
## TODO
- 💡 [`gitea`](6b8b580218https://github.com/go-gitea/gitea/pull/34736 ))
Packages: Fix for container, needs careful merge.
------
- 💡 [`gitea`](bbee652e29https://github.com/go-gitea/gitea/pull/34714 ))
Fork: Fix, needs careful merge.
------
- 💡 [`gitea`](d21ce9fa07https://github.com/go-gitea/gitea/pull/34653 ))
LFS: Performance improvement - needs careful merge.
------
- 💡 [`gitea`](8fed27bf6ahttps://github.com/go-gitea/gitea/pull/34708 ))
Various: Fixes, tests missing.
------
- 💡 [`gitea`](c9505a26b9https://github.com/go-gitea/gitea/pull/34341 ))
CodeSign: Nice feature - needs careful merge.
------
- 💡 [`gitea`](fbc3796f9ehttps://github.com/go-gitea/gitea/pull/34685 ))
Pull: Fix, needs careful merge.
------
- 💡 [`gitea`](1610a63bfdhttps://github.com/go-gitea/gitea/pull/34680 ))
Various Fixes - needs carefull merge.
------
- 💡 [`gitea`](0082cb51fahttps://github.com/go-gitea/gitea/pull/34649 ))
oidc: fix "first user is always admin". Needs careful merge.
------
- 💡 [`gitea`](c6b2cbd75dhttps://github.com/go-gitea/gitea/pull/34621 ))
Issues: Fix Markdown rendering. Needs carefull merge
------
- 💡 [`gitea`](7a59f5a825https://github.com/go-gitea/gitea/pull/34620 ))
No issue, no test.
------
- 💡 [`gitea`](6d0b24064ahttps://github.com/go-gitea/gitea/pull/34562 ))
Next PR in Commit-Status story.
------
- 💡 [`gitea`](f6041441eehttps://github.com/go-gitea/gitea/pull/34629 ))
Just for a common sense here: How should I consider refactorings?
------
- 💡 [`gitea`](cc942e2a86https://github.com/go-gitea/gitea/pull/34643 ))
User: Seems to fix email validation - but seems not to be finished.
------
- 💡 [`gitea`](7fa5a88831https://github.com/go-gitea/gitea/pull/34639 ))
UI: Nice idea - can we adapt this?
------
- 💡 [`gitea`](47d69b7749https://github.com/go-gitea/gitea/pull/34623 ))
Label: Color validation but needs careful merge.
------
- 💡 [`gitea`](108db0b04fhttps://github.com/go-gitea/gitea/pull/34509 ))
Nice fix for a bug hard to trace down.
Needs careful merge & think about whether a test is possible.
------
- 💡 [`gitea`](79cc369892https://github.com/go-gitea/gitea/pull/34575 ))
Small fix but would expect a test, showing what was fixed.
------
- 💡 [`gitea`](fe57ee3074https://github.com/go-gitea/gitea/pull/34570 ))
Small & simple - but tests are missing.
------
- 💡 [`gitea`](4e471487fbhttps://github.com/go-gitea/gitea/pull/34552 ))
Fix arround "Split GetLatestCommitStatus".
------
- 💡 [`gitea`](c5e78fc7adhttps://github.com/go-gitea/gitea/pull/34553 ))
Large refactoring to simplify options handling. But needs careful merge.
------
- 💡 [`gitea`](f48c0135a6https://github.com/go-gitea/gitea/pull/34573 ))
Nice fix but needs test.
------
- 💡 [`gitea`](e8d8984f7chttps://github.com/go-gitea/gitea/pull/34579 ))
Various fixes, tests missing.
------
## Skipped
- ⏩ [`gitea`](637070e07bhttps://github.com/go-gitea/gitea/pull/34725 ))
------
- ⏩ [`gitea`](0d3e9956cd⏩ [`gitea`](28debdbe00⏩ [`gitea`](dcc9206a59https://github.com/go-gitea/gitea/pull/34713 ))
------
- ⏩ [`gitea`](bc28654b49⏩ [`gitea`](65986f423fhttps://github.com/go-gitea/gitea/pull/34692 ))
------
- ⏩ [`gitea`](18bafcc378https://github.com/go-gitea/gitea/pull/34699 ))
------
- ⏩ [`gitea`](8d135ef5cfhttps://github.com/go-gitea/gitea/pull/34701 ))
------
- ⏩ [`gitea`](d5893ee260https://github.com/go-gitea/gitea/pull/34697 ))
- gitea UI specific specific
------
- ⏩ [`gitea`](06ccb3a1d4⏩ [`gitea`](94db956e31https://github.com/go-gitea/gitea/pull/34689 ))
------
- ⏩ [`gitea`](d5afdccde8⏩ [`gitea`](e9f5105e95https://github.com/go-gitea/gitea/pull/34510 ))
already in Forgejo - see https://codeberg.org/forgejo/forgejo/pulls/8035
------
- ⏩ [`gitea`](2c341b6803⏩ [`gitea`](92e7e98c56https://github.com/go-gitea/gitea/pull/34667 ))
------
- ⏩ [`gitea`](7b39c82587https://github.com/go-gitea/gitea/pull/34666 ))
Already in forgejo - see https://codeberg.org/forgejo/forgejo/issues/8070
------
- ⏩ [`gitea`](1fe652cd26⏩ [`gitea`](a9a705f4dbhttps://github.com/go-gitea/gitea/pull/34645 ))
Migration: Seems to be an important fix, but no tests.
As I know @earl-warren worked hard on migration, is this still relevant to us?
------
- ⏩ [`gitea`](1e0758a9f1⏩ [`gitea`](f6f6aedd4fhttps://github.com/go-gitea/gitea/pull/34640 ))
------
- ⏩ [`gitea`](aa2b3b2b1fhttps://github.com/go-gitea/gitea/pull/34638 ))
- gitea UI specific specific
------
- ⏩ [`gitea`](b38f2d31fdhttps://github.com/go-gitea/gitea/pull/34626 ))
------
- ⏩ [`gitea`](74a0178c6ahttps://github.com/go-gitea/gitea/pull/34625 ))
already in Forgejo - see https://codeberg.org/forgejo/forgejo/issues/6896
------
- ⏩ [`gitea`](5b22af4373https://github.com/go-gitea/gitea/pull/34613 ))
------
- ⏩ [`gitea`](9e0e107d23https://github.com/go-gitea/gitea/pull/34597 ))
- gitea UI specific specific
------
- ⏩ [`gitea`](e5781cec75https://github.com/go-gitea/gitea/pull/34599 ))
- gitea UI specific specific
------
- ⏩ [`gitea`](375dab1111https://github.com/go-gitea/gitea/pull/34588 ))
- gitea UI specific specific
------
- ⏩ [`gitea`](2a1585b32ehttps://github.com/go-gitea/gitea/pull/34580 ))
------
<details>
<summary><h2>Stats</h2></summary>
<br>
Between [`gitea@d5bbaee64e`](d5bbaee64e6b8b580218https://codeberg.org/forgejo/forgejo/pulls/8198
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Michael Jerger <michael.jerger@meissa-gmbh.de>
Co-committed-by: Michael Jerger <michael.jerger@meissa-gmbh.de>
2025-06-17 18:28:07 +02:00
Gusted
2457f5ff22
chore: branding import path ( #7337 )
...
- Massive replacement of changing `code.gitea.io/gitea` to `forgejo.org`.
- Resolves forgejo/discussions#258
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7337
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Reviewed-by: Beowulf <beowulf@beocode.eu>
Reviewed-by: Panagiotis "Ivory" Vasilopoulos <git@n0toose.net>
Co-authored-by: Gusted <postmaster@gusted.xyz>
Co-committed-by: Gusted <postmaster@gusted.xyz>
2025-03-27 19:40:14 +00:00
TheFox0x7
0813126058
test: add more workflow event coverage
2024-08-18 15:19:01 +02:00
TheFox0x7
4de909747b
Add testifylint to lint checks ( #4535 )
...
go-require lint is ignored for now
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4535
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: TheFox0x7 <thefox0x7@gmail.com>
Co-committed-by: TheFox0x7 <thefox0x7@gmail.com>
2024-07-30 19:41:10 +00:00
Mai-Lapyst
51735c415b
Add support for workflow_dispatch ( #3334 )
...
Closes #2797
I'm aware of https://github.com/go-gitea/gitea/pull/28163 exists, but since I had it laying around on my drive and collecting dust, I might as well open a PR for it if anyone wants the feature a bit sooner than waiting for upstream to release it or to be a forgejo "native" implementation.
This PR Contains:
- Support for the `workflow_dispatch` trigger
- Inputs: boolean, string, number, choice
Things still to be done:
- [x] API Endpoint `/api/v1/<org>/<repo>/actions/workflows/<workflow id>/dispatches`
- ~~Fixing some UI bugs I had no time figuring out, like why dropdown/choice inputs's menu's behave weirdly~~ Unrelated visual bug with dropdowns inside dropdowns
- [x] Fix bug where opening the branch selection submits the form
- [x] Limit on inputs to render/process
Things not in this PR:
- Inputs: environment (First need support for environments in forgejo)
Things needed to test this:
- A patch for https://code.forgejo.org/forgejo/runner to actually consider the inputs inside the workflow.
~~One possible patch can be seen here: https://code.forgejo.org/Mai-Lapyst/runner/src/branch/support-workflow-inputs~~
[PR](https://code.forgejo.org/forgejo/runner/pulls/199 )
## Testing
- Checkout PR
- Setup new development runner with [this PR](https://code.forgejo.org/forgejo/runner/pulls/199 )
- Create a repo with a workflow (see below)
- Go to the actions tab, select the workflow and see the notice as in the screenshot above
- Use the button + dropdown to run the workflow
- Try also running it via the api using the `` endpoint
- ...
- Profit!
<details>
<summary>Example workflow</summary>
```yaml
on:
workflow_dispatch:
inputs:
logLevel:
description: 'Log Level'
required: true
default: 'warning'
type: choice
options:
- info
- warning
- debug
tags:
description: 'Test scenario tags'
required: false
type: boolean
boolean_default_true:
description: 'Test scenario tags'
required: true
type: boolean
default: true
boolean_default_false:
description: 'Test scenario tags'
required: false
type: boolean
default: false
number1_default:
description: 'Number w. default'
default: '100'
type: number
number2:
description: 'Number w/o. default'
type: number
string1_default:
description: 'String w. default'
default: 'Hello world'
type: string
string2:
description: 'String w/o. default'
required: true
type: string
jobs:
test:
runs-on: docker
steps:
- uses: actions/checkout@v3
- run: whoami
- run: cat /etc/issue
- run: uname -a
- run: date
- run: echo ${{ inputs.logLevel }}
- run: echo ${{ inputs.tags }}
- env:
GITHUB_CONTEXT: ${{ toJson(github) }}
run: echo "$GITHUB_CONTEXT"
- run: echo "abc"
```
</details>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3334
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Mai-Lapyst <mai-lapyst@noreply.codeberg.org>
Co-committed-by: Mai-Lapyst <mai-lapyst@noreply.codeberg.org>
2024-06-28 05:17:11 +00:00
Lunny Xiao
97292da960
Fix schedule tasks bugs ( #28691 )
...
Fix #28157
This PR fix the possible bugs about actions schedule.
## The Changes
- Move `UpdateRepositoryUnit` and `SetRepoDefaultBranch` from models to
service layer
- Remove schedules plan from database and cancel waiting & running
schedules tasks in this repository when actions unit has been disabled
or global disabled.
- Remove schedules plan from database and cancel waiting & running
schedules tasks in this repository when default branch changed.
2024-01-12 21:50:38 +00:00
Zettat123
9a8af92577
Fix the bug when getting files changed for pull_request_target event ( #26320 )
...
Follow #25229
Copy from
https://github.com/go-gitea/gitea/pull/26290#issuecomment-1663135186
The bug is that we cannot get changed files for the
`pull_request_target` event. This event runs in the context of the base
branch, so we won't get any changes if we call
`GetFilesChangedSinceCommit` with `PullRequest.Base.Ref`.
2023-08-05 14:26:06 +08:00
Zettat123
7586b5815a
Fix activity type match in matchPullRequestEvent ( #25746 )
...
Fix #25736
Caused by #24048
Right now we only check the activity type for `pull_request` event when
`types` is specified or there are no `types` and filter. If a workflow
only specifies filters but no `types` like this:
```
on:
pull_request:
branches: [main]
```
the workflow will be triggered even if the activity type is not one of
`[opened, reopened, sync]`. We need to check the activity type in this
case.
Co-authored-by: Giteabot <teabot@gitea.io>
2023-07-07 16:30:07 +00:00
Zettat123
48e5a74f21
Support pull_request_target event ( #25229 )
...
Fix #25088
This PR adds the support for
[`pull_request_target`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target )
workflow trigger. `pull_request_target` is similar to `pull_request`,
but the workflow triggered by the `pull_request_target` event runs in
the context of the base branch of the pull request rather than the head
branch. Since the workflow from the base is considered trusted, it can
access the secrets and doesn't need approvals to run.
2023-06-26 14:33:18 +08:00
Zettat123
5eb4c63867
Support triggering workflows by wiki related events ( #24119 )
...
This PR is to support triggering workflows by wiki related events like
creating, editing or deleting wiki pages. In GitHub, this event is
called
[gollum](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#gollum )
2023-04-17 13:49:47 -04:00
Zettat123
2d91afaa92
Fix mismatch between hook events and github event types ( #24048 )
...
Some workflow trigger events can have multiple activity types, such as
`issues` and `pull_request`, and user can specify which types can
trigger the workflow. See GitHub documentation:
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows
Now some hook events cannot match the workflow trigger events correctly
because we don't check the activity types. For example,
`pull_request_label` is an individual hook event. But there isn't a
`pull_request_label` workflow trigger event, we can only use
`pull_request` event's `label` activity type. If we don't check the
activity types, the workflows without the `label` activity type may be
triggered by the `pull_request_label` event by mistake. We need to
improve the match logic.
- [x] [`issues`
](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#issues )
- [x]
[`issue_comment`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#issue_comment )
- [x]
[`pull_request`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request )
- [x]
[`pull_request_review`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_review )
- [x]
[`pull_request_review_comment`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_review_comment )
- [x]
[`release`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release )
- [x]
[`registry_package`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#registry_package )
2023-04-12 12:16:47 -04:00
