Michael Jerger
15bb6b7f92
[gitea] week 2025-22 cherry pick (gitea/main -> forgejo) ( #8198 )
...
## Checklist
- [x] go to the last cherry-pick PR (forgejo/forgejo#8040 ) to figure out how far it went: [gitea@d5bbaee64e](d5bbaee64eforgejo/forgejo#8198 )
- [ ] have the PR pass the CI
- end-to-end (specially important if there are actions related changes)
- [ ] add `run-end-to-end` label
- [ ] check the result
- [ ] write release notes
- [ ] assign reviewers
- [ ] 48h later, last call
- merge 1 hour after the last call
## Legend
- ❓ - No decision about the commit has been made.
- 🍒 - The commit has been cherry picked.
- ⏩ - The commit has been skipped.
- 💡 - The commit has been skipped, but should be ported to Forgejo.
- ✍️ - The commit has been skipped, and a port to Forgejo already exists.
## Commits
- 🍒 [`gitea`](17cfae82a56397da88d3https://github.com/go-gitea/gitea/pull/34556 ))
- 🍒 [`gitea`](b408bf2f0b46bc899d57https://github.com/go-gitea/gitea/pull/34602 ))
- 🍒 [`gitea`](9165ea871304332f31bfhttps://github.com/go-gitea/gitea/pull/34652 ))
- 🍒 [`gitea`](3f7dbbdaf12a9019fd04https://github.com/go-gitea/gitea/pull/34612 ))
- 🍒 [`gitea`](497b83b75d9a83cc7badhttps://github.com/go-gitea/gitea/pull/34577 ))
## TODO
- 💡 [`gitea`](6b8b580218https://github.com/go-gitea/gitea/pull/34736 ))
Packages: Fix for container, needs careful merge.
------
- 💡 [`gitea`](bbee652e29https://github.com/go-gitea/gitea/pull/34714 ))
Fork: Fix, needs careful merge.
------
- 💡 [`gitea`](d21ce9fa07https://github.com/go-gitea/gitea/pull/34653 ))
LFS: Performance improvement - needs careful merge.
------
- 💡 [`gitea`](8fed27bf6ahttps://github.com/go-gitea/gitea/pull/34708 ))
Various: Fixes, tests missing.
------
- 💡 [`gitea`](c9505a26b9https://github.com/go-gitea/gitea/pull/34341 ))
CodeSign: Nice feature - needs careful merge.
------
- 💡 [`gitea`](fbc3796f9ehttps://github.com/go-gitea/gitea/pull/34685 ))
Pull: Fix, needs careful merge.
------
- 💡 [`gitea`](1610a63bfdhttps://github.com/go-gitea/gitea/pull/34680 ))
Various Fixes - needs carefull merge.
------
- 💡 [`gitea`](0082cb51fahttps://github.com/go-gitea/gitea/pull/34649 ))
oidc: fix "first user is always admin". Needs careful merge.
------
- 💡 [`gitea`](c6b2cbd75dhttps://github.com/go-gitea/gitea/pull/34621 ))
Issues: Fix Markdown rendering. Needs carefull merge
------
- 💡 [`gitea`](7a59f5a825https://github.com/go-gitea/gitea/pull/34620 ))
No issue, no test.
------
- 💡 [`gitea`](6d0b24064ahttps://github.com/go-gitea/gitea/pull/34562 ))
Next PR in Commit-Status story.
------
- 💡 [`gitea`](f6041441eehttps://github.com/go-gitea/gitea/pull/34629 ))
Just for a common sense here: How should I consider refactorings?
------
- 💡 [`gitea`](cc942e2a86https://github.com/go-gitea/gitea/pull/34643 ))
User: Seems to fix email validation - but seems not to be finished.
------
- 💡 [`gitea`](7fa5a88831https://github.com/go-gitea/gitea/pull/34639 ))
UI: Nice idea - can we adapt this?
------
- 💡 [`gitea`](47d69b7749https://github.com/go-gitea/gitea/pull/34623 ))
Label: Color validation but needs careful merge.
------
- 💡 [`gitea`](108db0b04fhttps://github.com/go-gitea/gitea/pull/34509 ))
Nice fix for a bug hard to trace down.
Needs careful merge & think about whether a test is possible.
------
- 💡 [`gitea`](79cc369892https://github.com/go-gitea/gitea/pull/34575 ))
Small fix but would expect a test, showing what was fixed.
------
- 💡 [`gitea`](fe57ee3074https://github.com/go-gitea/gitea/pull/34570 ))
Small & simple - but tests are missing.
------
- 💡 [`gitea`](4e471487fbhttps://github.com/go-gitea/gitea/pull/34552 ))
Fix arround "Split GetLatestCommitStatus".
------
- 💡 [`gitea`](c5e78fc7adhttps://github.com/go-gitea/gitea/pull/34553 ))
Large refactoring to simplify options handling. But needs careful merge.
------
- 💡 [`gitea`](f48c0135a6https://github.com/go-gitea/gitea/pull/34573 ))
Nice fix but needs test.
------
- 💡 [`gitea`](e8d8984f7chttps://github.com/go-gitea/gitea/pull/34579 ))
Various fixes, tests missing.
------
## Skipped
- ⏩ [`gitea`](637070e07bhttps://github.com/go-gitea/gitea/pull/34725 ))
------
- ⏩ [`gitea`](0d3e9956cd⏩ [`gitea`](28debdbe00⏩ [`gitea`](dcc9206a59https://github.com/go-gitea/gitea/pull/34713 ))
------
- ⏩ [`gitea`](bc28654b49⏩ [`gitea`](65986f423fhttps://github.com/go-gitea/gitea/pull/34692 ))
------
- ⏩ [`gitea`](18bafcc378https://github.com/go-gitea/gitea/pull/34699 ))
------
- ⏩ [`gitea`](8d135ef5cfhttps://github.com/go-gitea/gitea/pull/34701 ))
------
- ⏩ [`gitea`](d5893ee260https://github.com/go-gitea/gitea/pull/34697 ))
- gitea UI specific specific
------
- ⏩ [`gitea`](06ccb3a1d4⏩ [`gitea`](94db956e31https://github.com/go-gitea/gitea/pull/34689 ))
------
- ⏩ [`gitea`](d5afdccde8⏩ [`gitea`](e9f5105e95https://github.com/go-gitea/gitea/pull/34510 ))
already in Forgejo - see https://codeberg.org/forgejo/forgejo/pulls/8035
------
- ⏩ [`gitea`](2c341b6803⏩ [`gitea`](92e7e98c56https://github.com/go-gitea/gitea/pull/34667 ))
------
- ⏩ [`gitea`](7b39c82587https://github.com/go-gitea/gitea/pull/34666 ))
Already in forgejo - see https://codeberg.org/forgejo/forgejo/issues/8070
------
- ⏩ [`gitea`](1fe652cd26⏩ [`gitea`](a9a705f4dbhttps://github.com/go-gitea/gitea/pull/34645 ))
Migration: Seems to be an important fix, but no tests.
As I know @earl-warren worked hard on migration, is this still relevant to us?
------
- ⏩ [`gitea`](1e0758a9f1⏩ [`gitea`](f6f6aedd4fhttps://github.com/go-gitea/gitea/pull/34640 ))
------
- ⏩ [`gitea`](aa2b3b2b1fhttps://github.com/go-gitea/gitea/pull/34638 ))
- gitea UI specific specific
------
- ⏩ [`gitea`](b38f2d31fdhttps://github.com/go-gitea/gitea/pull/34626 ))
------
- ⏩ [`gitea`](74a0178c6ahttps://github.com/go-gitea/gitea/pull/34625 ))
already in Forgejo - see https://codeberg.org/forgejo/forgejo/issues/6896
------
- ⏩ [`gitea`](5b22af4373https://github.com/go-gitea/gitea/pull/34613 ))
------
- ⏩ [`gitea`](9e0e107d23https://github.com/go-gitea/gitea/pull/34597 ))
- gitea UI specific specific
------
- ⏩ [`gitea`](e5781cec75https://github.com/go-gitea/gitea/pull/34599 ))
- gitea UI specific specific
------
- ⏩ [`gitea`](375dab1111https://github.com/go-gitea/gitea/pull/34588 ))
- gitea UI specific specific
------
- ⏩ [`gitea`](2a1585b32ehttps://github.com/go-gitea/gitea/pull/34580 ))
------
<details>
<summary><h2>Stats</h2></summary>
<br>
Between [`gitea@d5bbaee64e`](d5bbaee64e6b8b580218https://codeberg.org/forgejo/forgejo/pulls/8198
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Michael Jerger <michael.jerger@meissa-gmbh.de>
Co-committed-by: Michael Jerger <michael.jerger@meissa-gmbh.de>
2025-06-17 18:28:07 +02:00
Rowan Bohde
2e00ae4cdd
Validate OAuth Redirect URIs ( #32643 )
...
This fixes a TODO in the code to validate the RedirectURIs when adding
or editing an OAuth application in user settings.
This also includes a refactor of the user settings tests to only create
the DB once per top-level test to avoid reloading fixtures.
(cherry picked from commit 16a7d343d78807e39df124756e5d43a69a2203a3)
Conflicts:
services/forms/user_form.go
tests/integration/user_settings_test.go
simple conflicts
2024-12-03 10:19:22 +01:00
Denys Konovalov
ca35dec18b
Add ability to set multiple redirect URIs in OAuth application UI ( #25072 )
...
OAuth applications can already have multiple redirect URIs if
created/edited over API.
This change allows for setting multiple redirect URIs through the UI as
a comma-separated list (e. g.
`https://example.org/redirect,https://redirect.example.org `)
<details>
<summary>Screenshots</summary>
...
Follow #21429 & #22861
Use `<gitea-locale-number>` instead of backend `PrettyNumber`. All old
`PrettyNumber` related functions are removed. A lot of code could be
simplified.
And some functions haven't been used for long time (dead code), so they
are also removed by the way (eg: `SplitStringAtRuneN`, `Dedent`)
This PR only tries to improve the `PrettyNumber` rendering problem, it
doesn't touch the "plural" problem.
Screenshot:
2023-04-03 12:58:09 -04:00
flynnnnnnnnnn
e81ccc406b
Implement FSFE REUSE for golang files ( #21840 )
...
Change all license headers to comply with REUSE specification.
Fix #16132
Co-authored-by: flynnnnnnnnnn <flynnnnnnnnnn@github>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
2022-11-27 18:20:29 +00:00
6543
54e9ee37a7
format with gofumpt ( #18184 )
...
* gofumpt -w -l .
* gofumpt -w -l -extra .
* Add linter
* manual fix
* change make fmt
2022-01-20 18:46:10 +01:00
wxiaoguang
c7e23401a3
Fix a panic in NotifyCreateIssueComment (caused by string truncation) ( #17928 )
...
* Fix a panic in NotifyCreateIssueComment (caused by string truncation)
* more unit tests
* refactor
* fix some edge cases
* use SplitStringAtByteN for comment content
2021-12-09 05:41:17 +00:00
zeripath
fd15fd4c67
Handle too long PR titles correctly ( #16517 )
...
The CompareAndPullRequestPost handler for POST to /compare
incorrectly handles returning errors to the user. For a start
it does not set the necessary markers to switch SimpleMDE
but it also does not immediately return to the form.
This PR fixes this by setting the appropriate values, fixing
the templates and preventing the suggestion of a too long
title.
Fix #16507
Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-07-25 03:59:27 +01:00
