mirror of
https://codeberg.org/davrot/forgejo.git
synced 2025-07-25 07:00:02 +02:00
e47fa23729
Fixes #8491. Previous behavior always updated the newly created review to set the `official` flag to false. This logic is now removed. The most likely reason that this logic existed was that team reviews were being marked as official based upon `doer`, rather than the target team, which seems undesirable. The expected behavior was retained by removing the check for `IsOfficialReviewer(..., doer)`, ensuring that when making a review request for a team, it doesn't matter *who* makes the request. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8511 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
16 lines
No EOL
307 B
YAML
16 lines
No EOL
307 B
YAML
-
|
|
id: 23
|
|
repo_id: 2
|
|
index: 3
|
|
poster_id: 2
|
|
original_author_id: 0
|
|
name: protected branch pull
|
|
content: pull request to a protected branch
|
|
milestone_id: 0
|
|
priority: 0
|
|
is_pull: true
|
|
is_closed: false
|
|
num_comments: 0
|
|
created_unix: 1707270422
|
|
updated_unix: 1707270422
|
|
is_locked: false |