Domagoj Kriskovic
741b65d0eb
Add ensureUserCanSendComment authorization middleware ( #22959 )
...
* Add ensureUserCanSendComment authorization middleware
* added tests
GitOrigin-RevId: d1f58bd6bc63275456e5280ccb8c99aaa02c4e5f
2025-01-21 09:05:53 +00:00
Eric Mc Sween
71c2dc7d2d
Merge pull request #22970 from overleaf/em-log-user-id
...
Add userId to request logs when user is logged in
GitOrigin-RevId: c7c907375af20c83f2ac762aa634b8d8cd1d9404
2025-01-21 09:05:44 +00:00
Eric Mc Sween
6ee70550c4
Merge pull request #22960 from overleaf/em-promisify-filestore-controller
...
Promisify FileStoreController
GitOrigin-RevId: b5f5861a7601a1bf4af3024394f910a0f5a14206
2025-01-21 09:05:40 +00:00
Jakob Ackermann
01ab32c029
[web] bump copyright year for Server Pro/CE to 2025 ( #22950 )
...
GitOrigin-RevId: 7747e64e787e22beb5caf6e47255ab6eeeb74d23
2025-01-21 09:05:06 +00:00
Antoine Clausse
d4a10c7b41
[web] Socket diagnostics updates ( #22951 )
...
* Increase threshold for "latency in red color"
* Fix online status in Chrome and Safari
* Add "Auto ping" checkbox
* Put `/socket-diagnostics` behind `AuthenticationController.requireLogin`
* Set logs to `logger.info` when debugging
* Add `publicId` and `clientId` to logs
* Fix disconnect logs when debugging
* Refresh UI every second. Display red "Ping Count" if unanswered for 3s
* Update services/web/frontend/js/features/socket-diagnostics/components/socket-diagnostics.tsx
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
* Update services/web/frontend/js/features/socket-diagnostics/components/socket-diagnostics.tsx
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
* `npm run format:fix`
---------
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: 9faf2abdac51fa4b87c67d8fe89c4125d01d826f
2025-01-21 09:05:01 +00:00
Antoine Clausse
c8be2e25cf
[web] Promisify ensureAffiliationMiddleware
and refactor InstitutionHubsController
( #22242 feedback) ( #22261 )
...
* Promisify `ensureAffiliationMiddleware`
* In `ensureAffiliationMiddleware`, throw when UserNotFoundError
* Unnest object `_InstitutionHubsController`
* Format fix
GitOrigin-RevId: 5b3c6c24724520353540b8d8dd05005b6fa749ff
2025-01-21 09:04:57 +00:00
Jessica Lawshe
b735cac588
Merge pull request #22912 from overleaf/jel-cms-tabs-bs5
...
[web] Update admin panel to use `.ol-tabs` style
GitOrigin-RevId: c9e808c5534e5f033a8e829b35b0c6bd865cb596
2025-01-20 09:05:22 +00:00
Antoine Clausse
7bef003c56
[real-time, web] Create a UI to test socket connection ( #22907 )
...
* Create a UI to test socket connection
* Add Clock Delta to the measurements
* Add colors to DiagnosticItem
* Update icon
* Add more info to the diagnostics screen
* Add logs in backend on debug messages, disconnections and connection
* Add last received ping info
* Reorder DiagnosticItems
* Remove "warning" text color (too light)
* Replace Phosphor icons by Material Icons
GitOrigin-RevId: 6a015b4928cd19849ff287cf254f671840ed44af
2025-01-17 09:05:49 +00:00
Antoine Clausse
b9fb636f0b
[web] Remove promises
exports from Controller modules ( #22242 )
...
* Remove promises object from CollaboratorsInviteController.mjs
* Define functions at root
* Remove mentions of undefined `revokeInviteForUser`
* Remove unused `doLogout`
* Remove promises object from UserController.js
* Remove unused `makeChangePreview`
* Remove promises object from SubscriptionController.js (`getRecommendedCurrency` and `getLatamCountryBannerDetails`)
* Remove promises object from CollabratecController.mjs
* Remove promises object from SSOController.mjs
* Remove promises object from ReferencesApiController.mjs
* Remove promises object from MetricsEmailController.mjs
* Remove promises object from InstitutionHubsController.mjs
* Remove promises object from DocumentUpdaterController.mjs
* Remove promises object from SubscriptionAdminController.mjs
* Fixup unit tests
* Add expects that controllers don't error
* Promisify `ensureAffiliationMiddleware`
GitOrigin-RevId: 311c8afa7d5c8e4f051408d305b6b4147a020edc
2025-01-17 09:05:36 +00:00
David
c919960d2b
Merge pull request #22902 from overleaf/dp-remove-presentation-mode-flag
...
Remove pdf-presentation-mode feature flag
GitOrigin-RevId: 14e64115c539fe2721150ed6f09dfcc4ce9cbaaa
2025-01-17 09:04:49 +00:00
M Fahru
da6f332269
Merge pull request #22821 from overleaf/kh-cop-on-upgrade-modal
...
[web] limit COP group plans to 20 seats in upgrade modal
GitOrigin-RevId: b1d2713b978d0269892d8f547eeccc5ab702ea77
2025-01-16 09:06:37 +00:00
Jessica Lawshe
5c188939d6
Merge pull request #22740 from overleaf/jel-mono-text
...
[web] Eyebrow text margin
GitOrigin-RevId: cdf1eadf8ad1da4d81724e8aeb9994cc931388ce
2025-01-16 09:06:28 +00:00
Rebeka Dekany
971a5d9de4
Merge pull request #22717 from overleaf/rd-migrate-admin-bootstrap5
...
[web] Migrate the admin page to Bootstrap 5
GitOrigin-RevId: 8d283f7ce4a7d73f033a69a4c075311ff756f06a
2025-01-16 09:06:12 +00:00
Alf Eaton
f069adaf15
Add full project search UI ( #22671 )
...
GitOrigin-RevId: f40c85f40f4c16b4b3c26a197924cd9ac9b3db1f
2025-01-16 09:05:45 +00:00
Kristina
7994390967
[web] tear down group-pricing-2025 split test on non-plans pages ( #22785 )
...
* [web] rm split test from the change to group modal
* [web] rm split test from cancel flow
* [web] rm split test from checkout flow
* [web] rm unused translations
GitOrigin-RevId: 0188f2631ed18e79fdf55dabedac7cdea4f213d3
2025-01-16 09:05:22 +00:00
Kristina
23c455d7b9
[web] tear down group-pricing-2025 split test on plans page ( #22786 )
...
* [web] rm split test from new plans page
* [web] rm showDiscountPercentage from group_member_picker (always false)
* [web] rm now unused classes on edu discount checkbox
* [web] rm split test from FAQ
* [web] rm unused translation
GitOrigin-RevId: 262d97f317d8aaef6e5a07a8ecd4edc67557408b
2025-01-16 09:05:17 +00:00
M Fahru
292308d546
Merge pull request #22540 from overleaf/mf-remove-plans-page-default-variant-code
...
[web] Remove dead backend (include pug template) code after `website-redesign-plans` test has been concluded and `new-design` variant is fully activated
GitOrigin-RevId: 143129da71d43b88535f971b13e9e72c98bad798
2025-01-15 09:05:06 +00:00
Eric Mc Sween
c9591e250a
Merge pull request #22822 from overleaf/em-ai-manually-collected
...
Hide Error Assist from manually collected group admins
GitOrigin-RevId: fd4d851d1d427b1978649129674d74cb375bc3f5
2025-01-15 09:04:49 +00:00
Eric Mc Sween
a69036e005
Merge pull request #22825 from overleaf/em-move-project-snapshot
...
Move full project on client code to the main web tree
GitOrigin-RevId: a2afd0d7fceaef213841e662df0b20587e9fef69
2025-01-15 09:04:45 +00:00
M Fahru
2ef5db2938
Merge pull request #22340 from overleaf/mf-clean-up-currency-format-test
...
[web] Clean up localized currency format test (`local-ccy-format-v2`)
GitOrigin-RevId: 30d671479522b87ee9205994508b745d2b0ae4c3
2025-01-14 09:05:49 +00:00
Domagoj Kriskovic
30ebad91b7
Allow reviewers to resolve their own comments ( #22582 )
...
* Allow reviewers to resolve their own comments
* check if reviewer is comment author
* add missing translation
* add CommentsController tests
* added DocumentManagerTests
* added HttpControllerTests
* Add AuthorizationManagerTests
* added AuthorizationMiddlewareTests
* added DocumentUpdaterHandler test
* fix test descriptions
* remove returns from CommentsControllerTests
* use ensureUserCanResolveThread in authorizationMiddleware
* move canResolveThread to AuthorizationManager
* commentId as param in NotFoundError
* refactor canUserResolveThread
GitOrigin-RevId: 131c3d1eb9ac916eaaa9221d351a92bc07b80cdc
2025-01-14 09:05:11 +00:00
Alf Eaton
db78629e5c
Remove deprecated apple-mobile-web-app-* meta tags ( #22734 )
...
GitOrigin-RevId: b146d74e94a215a222d403bd852e9b21b74614b1
2025-01-14 09:04:41 +00:00
Alexandre Bourdin
356212ecde
Merge pull request #22252 from overleaf/ab-gradual-rollout-continuity
...
[web] Ensure continuity for gradual rollouts
GitOrigin-RevId: c5bada71ae476862c782dc669024944f12d77097
2025-01-13 09:04:59 +00:00
Miguel Serrano
84413c991d
Merge pull request #21677 from overleaf/msm-register-hide-sso-login
...
[web] Hide 'Login with SSO' when accepting SSO group invite
GitOrigin-RevId: fd4c327bbb838209773b4e7b1c41f6e3a355ad8b
2025-01-10 09:06:00 +00:00
Miguel Serrano
fe623d2297
Merge pull request #22264 from overleaf/msm-login_support_text-env
...
[web] Add `OVERLEAF_LOGIN_SUPPORT_TEXT` for CE/SP login pages
GitOrigin-RevId: 7f473b6a3448b4cb73c0c954d0ea1db34b980d6c
2025-01-10 09:05:56 +00:00
Miguel Serrano
5f913738a8
Merge pull request #22321 from overleaf/msm-force-flag-delete-user
...
[web] Fix user deletion in CE/SP when email does not exist
GitOrigin-RevId: 051f822318d63c8a9f50d5e9aeca095f3b37efb4
2025-01-10 09:05:48 +00:00
Brian Gough
2ce82fabab
Merge pull request #22533 from overleaf/ar-only-use-history-for-blobs-when-enabled
...
[web] only use history for blobs when enabled
GitOrigin-RevId: 010983e9b29657d4c594e03945dca5700577bf0a
2025-01-10 09:05:32 +00:00
Eric Mc Sween
eb1b939f5a
Merge pull request #22567 from overleaf/em-collection-method
...
Add collection method field to Mongo subscriptions
GitOrigin-RevId: 7fffabaecfde8f7da8e05fcedcbbf0b2fdcc70f5
2025-01-10 09:05:25 +00:00
Domagoj Kriskovic
a8650b3f0b
[web] Fix split test check ( #22781 )
...
GitOrigin-RevId: f3ce805fcf1dd79e17264bd134b55fc3dbe59171
2025-01-10 09:05:07 +00:00
Domagoj Kriskovic
2d57e347aa
Ensure track changes is enabled for reviewers when switching roles ( #22645 )
...
* Ensure track changes is enabled for reviewers when switching roles
* update track_changes.${userId} if track_changes is an object
GitOrigin-RevId: 3e803f4d475dbb67ff85b30095307ea58a07b2bc
2025-01-10 09:04:51 +00:00
Domagoj Kriskovic
61d300de6a
Use owner's reviewer role assigment ( #22735 )
...
GitOrigin-RevId: f632ea8c23b5a1f9ac6985922c53f1b6d49e9494
2025-01-10 09:04:46 +00:00
David
e9e59bbcc9
Merge pull request #22720 from overleaf/dp-editor-redesign
...
Editor redesign skeleton page
GitOrigin-RevId: 966c88ac3714e4cc7de3e21951e4e1641bfd6852
2025-01-09 09:05:43 +00:00
Rebeka Dekany
70185ad8a1
Merge pull request #22594 from overleaf/as-kh-group-pricing-2025
...
[Group Pricing] Update pricing for group plans
GitOrigin-RevId: 0a622bcd5fcd25070dc910823dc547b2342121ec
2025-01-09 09:05:30 +00:00
Miguel Serrano
d6f8645e8c
Merge pull request #21031 from overleaf/msm-clean-collabratec-tokens
...
[web] cleanup collabratec tokens
GitOrigin-RevId: 0ad73ca5d4c4c82d79e2ec7119c5b77a83b7086f
2025-01-09 09:05:15 +00:00
Eric Mc Sween
e3485f01da
Merge pull request #21472 from overleaf/em-hackathon-mongo-mocks-docker
...
Do not mock Mongo in unit tests
GitOrigin-RevId: 7a200a4ddc8f91b14e96cf02cb4873c51fc3489a
2025-01-08 09:05:34 +00:00
Mathias Jakobsen
8b0aae34ed
Merge pull request #22592 from overleaf/em-swallowed-error-recurly-wrapper
...
Do not swallow errors when communicating with Recurly
GitOrigin-RevId: 152f75dce10bd13f0a1655118de2de4f3a03ba08
2025-01-08 09:04:41 +00:00
Andrew Rumble
e64e69f539
Merge pull request #22652 from overleaf/ar-handle-filestore-404-when-copying-in-saas
...
[web] Do not do filestore copy in SAAS
GitOrigin-RevId: 83456ca57f706246a86b997a038968aecfbae4c5
2024-12-24 09:04:48 +00:00
ilkin-overleaf
48c0aaf940
Merge pull request #22578 from overleaf/ii-fl-add-seats-upgrade-plan-link
...
[web] Add seats "Upgrade my plan" link
GitOrigin-RevId: 7c72101be6b22feee9e3fb2ec119336e0e092ca9
2024-12-19 09:05:01 +00:00
Alf Eaton
abbac67954
Remove Writefull promo banner from projects dashboard ( #22568 )
...
GitOrigin-RevId: 49f95f1317462248f4841882ec0ef0ac23c45fe3
2024-12-19 09:04:42 +00:00
Kristina
d488791474
[web] Update change plan flow for group-pricing-2025 ( #22532 )
...
GitOrigin-RevId: 23f6f5972b1d13b457c7c5e88f508b7cf022469a
2024-12-18 09:06:38 +00:00
Antoine Clausse
a1e42ff003
[web] Reapply "Update navigation events (navbar menu, new project)" and bugfix ( #22576 )
...
* Reapply "[web] Update navigation events (navbar menu, new project) (#22473 )"
This reverts commit 134809f73c57d3f019e8158243e1fc74f9f6540a.
* Set the analytics event on the links, not the small contained span (pug)
* Fixup `menu-click` events in pug files: use `trackingKey`, correct event name, ...
* Add `location` prop in NavDropdownMenuItems and ContactUsItem, because they're used in the sidebar too
GitOrigin-RevId: 0bb95f69182268c34929f51121f2d5a2b19c4692
2024-12-18 09:06:18 +00:00
M Fahru
6daf2bef45
Merge pull request #22082 from overleaf/mf-remove-is-split-test-active
...
[web] Remove `isSplitTestActive` function since it is no longer used
GitOrigin-RevId: 81f3f61f14bb10d403fa72a61dc4a304c191512f
2024-12-18 09:05:55 +00:00
Antoine Clausse
27ea8211f3
Merge pull request #22575 from overleaf/revert-22473-ac-ds-nav-analytics-events
...
Revert "[web] Update navigation events (navbar menu, new project)"
GitOrigin-RevId: 9608be862e272c29ed92524ae6b8484094e8e0ff
2024-12-18 09:05:35 +00:00
Andrew Rumble
8417267075
Merge pull request #22188 from overleaf/ar-convert-modules-group-settings-to-es-modules
...
Convert modules/group-settings to es modules
GitOrigin-RevId: 3f1768fb91148722c0f0c181ab9b5a5a9174deca
2024-12-18 09:05:27 +00:00
Antoine Clausse
c6506d9a2e
[web] Update navigation events (navbar menu, new project) ( #22473 )
...
* Add project-list-events.ts
* Add event `menu-expand`
* Add event `menu-click`
* Add event `new-project-expand`
* Add event `new-project-click`
* Change `menu-clicked-*` events to "`menu-clicked`+trackingKey"
* Add `SplitTestProvider` to header-footer-react
* Convert to `menu-click` events in pug files
* Add sidebar `menu-expand` events
* Fixup formatting after rebase
* Fixup format after merge
* Get location type from `ExtraSegmentations`
* Replace `any` by `ExtraSegmentations['menu-click']['item']`
Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>
* Use `string & {}` trick to type `new-project-click.item`
Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>
* Add `location: 'top-menu'` to Pug events
* Add `menu-expand` tracking event
---------
Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>
GitOrigin-RevId: c290835c9b92a25a758cec94b49103edcdcdffed
2024-12-18 09:05:23 +00:00
ilkin-overleaf
b253d860ff
Merge pull request #22554 from overleaf/ii-fl-upgrade-subscription-redirect
...
[web] FL subscription upgrade error handling
GitOrigin-RevId: 1c9e841ba94cec4aa4de6e91f565cdf75e251b3d
2024-12-18 09:05:16 +00:00
ilkin-overleaf
8e7f1d5e89
Merge pull request #22448 from overleaf/ii-flexible-group-licensing-add-seats-tests
...
[web] Add seats tests
GitOrigin-RevId: 76fb5edc6eba5579fac2d3e05cd1f64fba16046c
2024-12-18 09:05:12 +00:00
Tim Down
e68d2e88e0
Merge pull request #22506 from overleaf/td-bs5-ieee-overall-theme-take-2
...
Always apply overall dark theme with IEEE-branded editor and tear down ieee-stylesheet feature flag, second attempt
GitOrigin-RevId: 311d125a77a46ee3f34769064005b6edea7ce013
2024-12-17 09:05:28 +00:00
Tim Down
79e4b76551
Merge pull request #22222 from overleaf/td-thin-footer-react
...
Implement thin footer in Bootstrap 5
GitOrigin-RevId: c45f63b3d2536e6266eb55cc95df11b53a6b77ec
2024-12-17 09:05:23 +00:00
Kristina
8fa2e9ec96
Merge pull request #22447 from overleaf/kh-group-pricing-faq
...
[web] add group pricing change FAQ
GitOrigin-RevId: 50bbc097889fb90515fa27dd502c84f5ba3a23db
2024-12-16 09:05:47 +00:00