Commit graph

3681 commits

Author SHA1 Message Date
Eric Mc Sween
7cb146765c Merge pull request #22503 from overleaf/em-overleaf-assist
Rename last mentions of Overleaf Assist to Error Assist

GitOrigin-RevId: 83170de1bcf494955138f8ff6484f3fba9c1ea9b
2024-12-18 09:05:39 +00:00
Antoine Clausse
27ea8211f3 Merge pull request #22575 from overleaf/revert-22473-ac-ds-nav-analytics-events
Revert "[web] Update navigation events (navbar menu, new project)"

GitOrigin-RevId: 9608be862e272c29ed92524ae6b8484094e8e0ff
2024-12-18 09:05:35 +00:00
Antoine Clausse
c6506d9a2e [web] Update navigation events (navbar menu, new project) (#22473)
* Add project-list-events.ts

* Add event `menu-expand`

* Add event `menu-click`

* Add event `new-project-expand`

* Add event `new-project-click`

* Change `menu-clicked-*` events to "`menu-clicked`+trackingKey"

* Add `SplitTestProvider` to header-footer-react

* Convert to `menu-click` events in pug files

* Add sidebar `menu-expand` events

* Fixup formatting after rebase

* Fixup format after merge

* Get location type from `ExtraSegmentations`

* Replace `any` by `ExtraSegmentations['menu-click']['item']`

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* Use `string & {}` trick to type `new-project-click.item`

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* Add `location: 'top-menu'` to Pug events

* Add `menu-expand` tracking event

---------

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>
GitOrigin-RevId: c290835c9b92a25a758cec94b49103edcdcdffed
2024-12-18 09:05:23 +00:00
ilkin-overleaf
8e7f1d5e89 Merge pull request #22448 from overleaf/ii-flexible-group-licensing-add-seats-tests
[web] Add seats tests

GitOrigin-RevId: 76fb5edc6eba5579fac2d3e05cd1f64fba16046c
2024-12-18 09:05:12 +00:00
Antoine Clausse
df727d64c3 Merge pull request #22548 from overleaf/ac-ds-phosphor-icons-and-splittests-bugfix
[web] Reapply  Use icons from @phosphor-icons/react for the project-list (DS nav)

GitOrigin-RevId: b87767b7c875ff4c081590e7bc0111892c0a1435
2024-12-17 09:05:32 +00:00
Tim Down
e68d2e88e0 Merge pull request #22506 from overleaf/td-bs5-ieee-overall-theme-take-2
Always apply overall dark theme with IEEE-branded editor and tear down ieee-stylesheet feature flag, second attempt

GitOrigin-RevId: 311d125a77a46ee3f34769064005b6edea7ce013
2024-12-17 09:05:28 +00:00
Tim Down
79e4b76551 Merge pull request #22222 from overleaf/td-thin-footer-react
Implement thin footer in Bootstrap 5

GitOrigin-RevId: c45f63b3d2536e6266eb55cc95df11b53a6b77ec
2024-12-17 09:05:23 +00:00
Antoine Clausse
0c40841d9f Merge pull request #22547 from overleaf/revert-22517-ac-ds-nav-phosphor-icons
Revert "[web] Use icons from `@phosphor-icons/react` for the project-list (DS-Nav)"

GitOrigin-RevId: 350f5d69a8f575d8ee4e3bd6af46e4e5f7137c7d
2024-12-17 09:05:19 +00:00
Alf Eaton
c0cbe51828 Avoid dispatching unnecessary transaction for review panel tooltip (#22524)
* Avoid dispatching unneeded review panel effects
* Remove event listeners

GitOrigin-RevId: 17fec45f660fdd7934aa6ef3202159377902f6a5
2024-12-17 09:05:11 +00:00
Alf Eaton
d434a2ba86 Remove toolbar visibility button (#22519)
GitOrigin-RevId: 51084bf6f21a6ecaf9d38dab33a8e1541bf62bc8
2024-12-17 09:05:06 +00:00
Alf Eaton
9b82969e44 Upgrade CodeMirror dependencies (#22489)
GitOrigin-RevId: 77d2773a382ddb8dfa8f3a66bd6f8041720490b3
2024-12-17 09:05:02 +00:00
Antoine Clausse
bb8bdd04af [web] Use icons from @phosphor-icons/react for the project-list (DS-Nav) (#22517)
* Use icons from `@phosphor-icons/react`

https://phosphoricons.com/

* Add the phosphor Plus icon to the tag list

* Add SignOut icon

* Use Phosphor icon for tags

* Fix icon color when active

* Add offset to dropdown menus so they're positioned like in Figma

---------

Co-authored-by: Tim Down <158919+timdown@users.noreply.github.com>
GitOrigin-RevId: 039e98063d775d0348d227202d5ecd6a0bfb7b65
2024-12-17 09:04:57 +00:00
David
362521dd1e Show full edit/review mode dropdown on first load (#22465)
* Show full edit/review mode dropdown on first load

* Remove unneeded import

* rename localstorage value, inline event

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 7efb52d4b43588dd1ee8b7a6a5f703166b0c9b3a
2024-12-17 09:04:52 +00:00
David
4a8163b3f3 Add new trackedWrite frontend permission for review panel (#22486)
* Add new trackedWrite frontend permission for review panel

* Fix test lint

* Remove comment

* Fix codemirror tests

* hide file actions for reviewer

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 6aab5c662287a02750d81b3960bbdd9c98b325db
2024-12-17 09:04:48 +00:00
Antoine Clausse
90b16e4c8e [web] DS-Nav footer tweaks (#22482)
* Footer tweaks (add border, main-content 100vh)

* Update color to be the same as the sidebar `<hr>`

* Move the border to the larger div so it also separates with the navbar

* Update border color to be the same as the background

* Fixup lint

* Fixup main content padding on mobile view

See https://github.com/overleaf/internal/pull/22186#discussion_r1876087478

* Change the border color to neutral-20

* Use `--border-divider` which is the same color as --neutral-20 (`#e7e9ee`)

* Replace `@media (width >= 768px)` by `@include media-breakpoint-up(md)`

* Replace `min-height: 100dvh` by `min-height: 100%`

GitOrigin-RevId: 426869e9b96a1ee8245c487bb80ff01856521a34
2024-12-16 09:05:14 +00:00
Eric Mc Sween
a323a5c915 Merge pull request #22527 from overleaf/revert-22471-em-tracked-deletes-at-same-position
Revert "Improve handling of tracked delete rejections"

GitOrigin-RevId: 444a5a73aa2b93162036dfc463cd76d9c463aadb
2024-12-16 09:05:10 +00:00
Antoine Clausse
f2d6c73f75 [web] Update project-list Navbar for mobile (#22478)
* Control if nav items are shown with CSS instead of JS

* Fix navbar style for mobile view

* Update navbar toggle icon to close

* Hide "Projects" nav item from the navbar

* Add separator above the Help menuitem in the mobile navbar

* Adjust sidebar padding: 24px from the logo

GitOrigin-RevId: ba587645f56febc0da798269bd6aa8c2e1639c27
2024-12-16 09:05:02 +00:00
Eric Mc Sween
6737cfa38d Merge pull request #22471 from overleaf/em-tracked-deletes-at-same-position
Improve handling of tracked delete rejections

GitOrigin-RevId: 35857d0a3f739c0531223737b2b649c9e8033157
2024-12-16 09:04:58 +00:00
Domagoj Kriskovic
db45323b93 Hide reviewer option from edit-member (#22499)
GitOrigin-RevId: 16f2b51a4856ef0f651b8b7973c34a7529d826cc
2024-12-16 09:04:53 +00:00
Antoine Clausse
e5c97f1963 [web] Add box shadows to scrollable part of sidebar (#22400)
* Add box shadows to scrollable part of sidebar

* Fix lint

* Fix `isAtBottom` boolean on Firefox

* Throttle the `scroll` event

* Remove wrong and unnecessary comment

GitOrigin-RevId: 7bcbb7fc860ab32f44203b3ae9ff37a3fed069a8
2024-12-16 09:04:49 +00:00
Tim Down
b2b398ba0d Merge pull request #22495 from overleaf/revert-22468-td-bs5-ieee-overall-theme
Revert "Always apply overall dark theme with IEEE-branded editor and tear down ieee-stylesheet feature flag"

GitOrigin-RevId: 223b4816b02ba96212ea7e779e16770cd4f16949
2024-12-13 09:05:33 +00:00
Tim Down
4cd624e6a5 Merge pull request #22468 from overleaf/td-bs5-ieee-overall-theme
Always apply overall dark theme with IEEE-branded editor and tear down ieee-stylesheet feature flag

GitOrigin-RevId: 80d10a911f3a188867db9b825f3ae8413f555b64
2024-12-13 09:05:24 +00:00
ilkin-overleaf
09bbbfbb28 Merge pull request #22479 from overleaf/ii-manage-members-add-more-users-link
[web] Members management flexible licensing

GitOrigin-RevId: 8b0283db95c83c2ae1c0dd4e1e756980c168f152
2024-12-13 09:05:08 +00:00
Antoine Clausse
b165e71ba9 [web] Update footer responsiveness with container queries (#22346)
* Remove padding around the footer

* Use CSS container queries instead of media queries on the full window

Container queries are supported by 92.76%	of web users, which can be an issue.
https://caniuse.com/css-container-queries

Though we do use them in other places

* Use `@supports` to check if `@container` can be used and use mixins

* Add the max sidebar width the fallback media query

* Update the footer responsiveness so we don't affect the default variant

GitOrigin-RevId: bed3e4244f1a97fd84740dcf87fb27c760be91ad
2024-12-12 09:06:09 +00:00
Antoine Clausse
62cfb68c1b [web] Add icon menus in the Sidebar (#22318)
* Add sidebar icons and menus (Help, Account)

* Place the account dropdown menu above the tooltip

* Hide tooltip when dropdown menu is shown

* Fixup tooltip position

* Add Digital Science link

* Add aria-labels on the dropdown toggles

* Update sidebar items spacings

- Add space between notification and DS icons
- Balance margin/padding in the scrollable part

* Revert changing the side of .dev-tool-bar-open-button

* Remove `!important` in link color

* Add Help tooltip

* Revert dropdown-menu z-index change

* Move `AccountMenuItems` to its own file

* Revert "Remove `!important` in link color"

This reverts commit b2de83f815d05cd1e224604d4ca355986ba76b99.

GitOrigin-RevId: 286266ea5348384f2592f748d3ae32c452558988
2024-12-12 09:06:05 +00:00
Antoine Clausse
27792199f6 [web] Update project list page main content to DS-nav-bar design (#22307)
* Move some SCSS to project-list-default.scss

* Update project-list-ds-nav.tsx to match design and simplify the SCSS

* Fix survey-notification style: light on the sidebar, dark on the main content

* Replace `withHr` by `useSplitTestContext` hook

* Override the `navbar-btn-padding-h` override.

* Fixup main content padding

Co-authored-by: Tim Down <tim.down@overleaf.com>

* Add padding-top to the logo

* Fixup merges

Add changes from https://github.com/overleaf/internal/pull/22272

---------

Co-authored-by: Tim Down <tim.down@overleaf.com>
GitOrigin-RevId: 8dbc449afbf70388bcf3185413b35234acaad349
2024-12-12 09:05:23 +00:00
Antoine Clausse
629579b840 [web] Update project list page layout and sidebar to new design (#22186)
* PoC DS nav project page shell

* Rename files: use `ds-nav` as a suffix

(really just moving code without changes)

* Update NavBar to the new design

* Small updates to project-list-ds-nav.tsx so it gets its basic shape

* Nest `.survey-notification` and `.project-list-sidebar-survey-wrapper` in the default classes to avoid interferences

* Create `SidebarDsNav`

* Add props to sidebar components so they work in both versions

* Update the SCSS code for the sidebar redesign

* Update subheader to "Organize Tags"

* Mute add affiliation font

* Remove `<aside className="project-list-sidebar-react">` and add sidebar max/min widths

* Fixup buttons padding

* Fix tests: add SplitTestProvider

* Fixup sidebar scroll div: add `flex: 1 1 auto`

* Make "Uncategorized" italic

* Update logo to SVG

* Optimize the svg
https://jakearchibald.github.io/svgomg/
9.12k → 4.92k 53.91%

---------

Co-authored-by: Tim Down <158919+timdown@users.noreply.github.com>
GitOrigin-RevId: 3d08b4b80291d9465fae87ffdf0c6a9f6deda554
2024-12-12 09:05:18 +00:00
David
f8a1e7c43b Merge pull request #22398 from overleaf/dp-change-edit-mode-ui-part-2
Add ReviewModeSwitcher

GitOrigin-RevId: bfbbdac30530d859da0e8b5673357ba805b100ab
2024-12-12 09:05:06 +00:00
Domagoj Kriskovic
f1c3ddb7c2 Use isReviewerRoleEnabled meta tag (#22437)
GitOrigin-RevId: e2f2529f09936a53087393d8f02968bdb5ea1acc
2024-12-12 09:04:51 +00:00
Domagoj Kriskovic
71a0b48a68 Set track changes state permissions for reviewer role (#22345) (#22436)
* Support for adding reviewer role

* added collaboratorsGetter tests

* emit toggle-track-changes when reviewer is added

* Add reviewer in change privilege level handler

GitOrigin-RevId: 88ec39f2b760b5d1ca6dc3a363df31c087268972
2024-12-12 09:04:46 +00:00
Jimmy Domagala-Tang
a8724ff7a0 Merge pull request #22330 from overleaf/jdt-split-preview-charges
feat: splitting immediate charges into pre and post tax
GitOrigin-RevId: 67c96e7dbc4dbf0d73f62242b9710532f633dbef
2024-12-11 09:04:52 +00:00
Domagoj Kriskovic
a038f451d4 Revert "Set track changes state permissions for reviewer role (#22345)" (#22431)
This reverts commit 6a03d2355b3fb7d7b755ed1d3ab1a080126cd2dc.

GitOrigin-RevId: 4e962bd9a547a9d6205460c9a8e9a0e835442be4
2024-12-10 13:09:42 +00:00
David
f1893fa03a Show coloured squares next to collaborator names (#22406)
* Change font to content-primary

* Add user colour blocks to comments/track changes

* Format

GitOrigin-RevId: a9186e9c7c95dfe134bee2f756245275cfa9ea24
2024-12-10 13:09:37 +00:00
David
97cdc290c3 Adapt review panel header with new reviewer role (#22291)
* Adapt review panel header with new reviewer role

* Remove duplicate css property

* Update position-items

GitOrigin-RevId: a2e8dac0c1d90e6d5b3f13769909cddd69b5db14
2024-12-10 13:09:33 +00:00
David
524d743d6c Double the max lenght of a comment before truncating (#22409)
GitOrigin-RevId: 8c4314d0b3567e7c4bd963dadf2eb698d3df3565
2024-12-10 13:09:24 +00:00
Domagoj Kriskovic
53dc5fbafe Set track changes state permissions for reviewer role (#22345)
* Support for adding reviewer role

* added collaboratorsGetter tests

* emit toggle-track-changes when reviewer is added

* Add reviewer in change privilege level handler

GitOrigin-RevId: 6a03d2355b3fb7d7b755ed1d3ab1a080126cd2dc
2024-12-10 13:09:14 +00:00
Domagoj Kriskovic
576134abde Add isReviewerRoleEnabled meta value (#22402)
GitOrigin-RevId: f7e8a49bfdcc98b3dac83b63fe41752bf01b7885
2024-12-10 13:09:10 +00:00
M Fahru
c898e3f323 Merge pull request #22304 from overleaf/mf-clean-up-latam-v2-test
[web] Tear down LATAM geo-pricing v2 split test

GitOrigin-RevId: ca379c7ace5600aa31559c82e166c7ea67c6c26d
2024-12-10 09:05:22 +00:00
Domagoj Kriskovic
f39ca200b9 Support for adding reviewer role (#22314)
* Support for adding reviewer role

* added collaboratorsGetter tests

* emit toggle-track-changes when reviewer is added

GitOrigin-RevId: 5b831102d561f5dbc4b23ab9f6dc63e3a87ea103
2024-12-10 09:04:47 +00:00
David
9ed3861c70 Merge pull request #22287 from overleaf/dp-review-safari
Allow review panel entry buttons to be focused in safari

GitOrigin-RevId: 1f9854534394d2561b673857fde186058e4acf49
2024-12-10 09:04:43 +00:00
David
e72a3cbc28 Merge pull request #22297 from overleaf/dp-bs5-dropdown-description-icon
Fix display of leading icons in dropdown items with a description

GitOrigin-RevId: bdb7bca62abef9d599a23364656b32599a909a90
2024-12-10 09:04:39 +00:00
Brian Gough
a08d1b18dc Merge pull request #22378 from overleaf/bg-issue22368
Fix frontend to handle missing hashes for image preview

GitOrigin-RevId: e67300d9b08b02b1670cb3a7bbd4483cf4486f51
2024-12-10 09:04:29 +00:00
roo hutton
5a24d23930 Merge pull request #22309 from overleaf/rh-plan-annual-toggle
[web] Plans page period toggle improvements

GitOrigin-RevId: 8900d9ce9c2116fd11f9688ada93d11211df045f
2024-12-09 09:05:15 +00:00
Domagoj Kriskovic
6a6ef776d5 Revert "Update review entries in overview panel on collaborator changes (#22098)" (#22369)
This reverts commit e2d837efe889170dc055df69eae6b4e8f86cb5fc.

GitOrigin-RevId: e2c8637ffd64fc52f1a9cb36801f8688d42d4e0c
2024-12-09 09:05:00 +00:00
Domagoj Kriskovic
e83963eefc Update review entries in overview panel on collaborator changes (#22098)
* remove unused "total" property

* add missing key

* added socket listeners

* remove accept-changes listener

* not using ranges context in overview

* fix lint error

* added comment

* add accept-changes listener

* rename to removeThreadHandler

* simplify docRanges useEffect

* refactor removeThreadHandler

* refactor accept-changes handler

* delete unnecessery event handlers

* remove edit-message listener

GitOrigin-RevId: e2d837efe889170dc055df69eae6b4e8f86cb5fc
2024-12-09 09:04:56 +00:00
Domagoj Kriskovic
174d62e4cc Improve positioning of "Add comment" tooltip when selecting entire line(s) (#22277)
* Avoid obscuring text with "Add comment" tooltip when selecting entire line

* tooltip position change on direction of selection

GitOrigin-RevId: d8cd301091104dae2422e34e14f90afd4c0927c4
2024-12-09 09:04:52 +00:00
Jimmy Domagala-Tang
2dcd1afcc5 Merge pull request #22360 from overleaf/jdt-fix-admin-panel-tests-ai
feat: updating test defaults
GitOrigin-RevId: 2be457097dcdebe13dd211f2ea24b45573b7744a
2024-12-06 09:06:58 +00:00
Jimmy Domagala-Tang
6ba4b0141a Merge pull request #22255 from overleaf/jdt-rm-free-suggestion-text-on-purchase
[Web] remove uses left indicator after potential add-on purchase

GitOrigin-RevId: c9c839b90eea62b9d0dbeb4ae81321f303582c2c
2024-12-06 09:06:53 +00:00
Jimmy Domagala-Tang
ab5a539c62 Merge pull request #22110 from overleaf/jdt-remove-assistant-from-labs
[Web] End Error Assist Labs Experiment

GitOrigin-RevId: 2570c07aea3d6b71dc59792cd2248cb890b415d3
2024-12-06 09:06:32 +00:00
Rebeka Dekany
1363045db2 Merge pull request #22272 from overleaf/rd-tag-dropdown-fix
[web] Tag dropdown menu should not be dismissed when hovering outside of it

GitOrigin-RevId: 0f0f903e07d657752e3476b9abea643bae65eb9e
2024-12-06 09:05:51 +00:00