Alf Eaton
b8d74c6ae0
Remove 'review-panel-redesign' split test and old code ( #24235 )
...
GitOrigin-RevId: 1f3d4a9a51429591a82391a9bee3cfdf226bc9c8
2025-03-24 10:48:15 +00:00
Domagoj Kriskovic
6ee3ff63e4
Dont show "add comment" tooltip when text is selected via search ( #23341 )
...
* Dont show "add comment" tooltip when text is selected via search
* remove the tooltip if selection changes
* handle empty selection
* use tr.effects.some for mouseUp check
* avoid creating new create function each time
* use useEventListener
GitOrigin-RevId: 18d96fe6fdefcd55f88849cf880f804d4c963f4d
2025-02-05 09:06:02 +00:00
Alf Eaton
5e491cc0c0
Use thread id in removeNewCommentRangeEffect ( #23205 )
...
GitOrigin-RevId: 6082f5e6d6f548eff43da657526097118a2d3c11
2025-02-03 09:04:48 +00:00
Eric Mc Sween
659f15d010
Merge pull request #22571 from overleaf/dk-add-comment-mouseup2
...
Show add comment tooltip on mouse up
GitOrigin-RevId: d12b10c0c3d481a509c19eaacaf8055c2c65ff30
2024-12-18 09:05:47 +00:00
Alf Eaton
c0cbe51828
Avoid dispatching unnecessary transaction for review panel tooltip ( #22524 )
...
* Avoid dispatching unneeded review panel effects
* Remove event listeners
GitOrigin-RevId: 17fec45f660fdd7934aa6ef3202159377902f6a5
2024-12-17 09:05:11 +00:00
Domagoj Kriskovic
174d62e4cc
Improve positioning of "Add comment" tooltip when selecting entire line(s) ( #22277 )
...
* Avoid obscuring text with "Add comment" tooltip when selecting entire line
* tooltip position change on direction of selection
GitOrigin-RevId: d8cd301091104dae2422e34e14f90afd4c0927c4
2024-12-09 09:04:52 +00:00
Alf Eaton
3bbde49781
Merge pull request #22055 from overleaf/ae-restore-review-tooltips
...
Reapply "Allow position of review tooltip to be calculated automatically (#21803 )"
GitOrigin-RevId: b6dff2d12627b04ff1859bd4765be01670256aa4
2024-11-22 09:05:33 +00:00
Alf Eaton
bc310ddd1e
Revert "Allow position of review tooltip to be calculated automatically ( #21803 )" ( #22022 )
...
This reverts commit 7d285a9c76032a3238422e15a73ae4b819612b31.
GitOrigin-RevId: 792391619bd6f2a9483428088c31ece09a441b33
2024-11-21 09:05:12 +00:00
Alf Eaton
598ccab8b4
Allow position of review tooltip to be calculated automatically ( #21803 )
...
* Remove view from textSelectedEffect
* Upgrade @codemirror/view to 6.34.3
GitOrigin-RevId: 7d285a9c76032a3238422e15a73ae4b819612b31
2024-11-21 09:03:59 +00:00
Domagoj Kriskovic
edb4e3d537
Improve selection detection for "Add comment" tooltip ( #21731 )
...
GitOrigin-RevId: cd13cacea0d6e45015997f3a831d0f127ddf8cd8
2024-11-12 09:05:57 +00:00
Domagoj Kriskovic
72f03b39c6
Hide "add comment" tooltip on mouse down ( #21721 )
...
* Hide "add comment" tooltip on mouse down
* using EditorView.domEventHandlers
GitOrigin-RevId: 48b7626d5c1be8a3fb0b1ee1fcc1bc7738f8dbc5
2024-11-08 09:06:23 +00:00
Domagoj Kriskovic
0329a18875
Show "add comment" tooltip below cursor if near viewport top ( #21348 )
...
* Scroll selection anchor into view when adding new comment
* check if cursor is near viewport edge
* Show "add comment" tooltip below cursor if near viewport top
GitOrigin-RevId: 0dc2234bc03b1d88a3719ba01a4a865f218b9bfa
2024-10-28 09:05:47 +00:00
David
1c5f5950fa
Merge pull request #21208 from overleaf/dp-accept-reject-all-changes
...
Add options to accept/reject all changes to review tooltip
GitOrigin-RevId: 1cea76926d59d0354c8abaa6ba69b7e99c02fbe0
2024-10-24 08:05:08 +00:00
