Commit graph

2885 commits

Author SHA1 Message Date
David
ad78287c1f Merge pull request #23891 from overleaf/dp-eq-preview
Always include math preview theme even when it is disabled

GitOrigin-RevId: cfbad399ccd0cb6805158633c35c7b15140b9feb
2025-02-27 09:04:51 +00:00
ilkin-overleaf
0783bf1dc7 Merge pull request #23743 from overleaf/ii-bs5-manage-group-members
[web] BS5 Group members management

GitOrigin-RevId: fab24ee6f6de07aa64887e123df930593fcec6a2
2025-02-27 09:04:47 +00:00
Antoine Clausse
d9a9fbb242 [web] Fix button-link loading state in subscription page (#23640)
* Fix inline loading button style

* Fix frontend test

GitOrigin-RevId: 59cdf68b8f2ad50f042a4457dc37f5c3d33d6c87
2025-02-26 09:04:58 +00:00
Jakob Ackermann
04c42f03e1 [web] editor connection tweaks for connection attempts when offline (#23864)
* [web] only flag errors originating from WebSocket connect as ws failure

* [web] slow down reconnecting when potentially offline

GitOrigin-RevId: 7c587d52dfe8092c45e2152f929e05e814db98f4
2025-02-26 09:04:47 +00:00
Alf Eaton
1fd9c592e2 Ensure that lastClickEvent is set before handling doubleClick (#23865)
GitOrigin-RevId: 1f080e62e95dc71cec6bcf2f5c9e0cb8bd5f5e2c
2025-02-26 09:04:33 +00:00
Alf Eaton
fe878a88d1 Run Prettier (#23860)
GitOrigin-RevId: fd65c7d24c4ada0367ba38092a142c6f6aeaba71
2025-02-26 09:04:19 +00:00
Domagoj Kriskovic
598d51c9e7 Prevent focusing review panel entry on resolve/accept/reject (#23859)
GitOrigin-RevId: 91d6725d1ea2a27f1ff93871db745440486b7246
2025-02-26 09:04:16 +00:00
Alf Eaton
fe1beec09a Use the original double-click location in bracketSelection extension (#23722)
GitOrigin-RevId: 173c4b4149fa4e6b552cb88022dad6334492c59a
2025-02-26 09:04:12 +00:00
Alf Eaton
cee51af9fd Disable "Go to code location in PDF" button for non-TeX files (#23751)
GitOrigin-RevId: 9a51252e2df6e52532d0cd787a8fd744af41ed95
2025-02-26 09:04:08 +00:00
Alf Eaton
02cd5d2f2f Reduce PDF.js maxCanvasPixels in Safari (#23781)
GitOrigin-RevId: 3b75d85bb4af33e4d4d40ee6f1dc9cf375f1435f
2025-02-26 09:04:05 +00:00
Alf Eaton
7070a0d410 Focus the editor and place cursor after the learned/corrected word (#23782)
GitOrigin-RevId: 605b13a4bb0d8e9375d8c4edc17a1866e29a3169
2025-02-26 09:04:01 +00:00
Alf Eaton
9dee601ba3 Remove AI Error Assistant feedback prompt (#23796)
GitOrigin-RevId: 36ee1ca0befc0f2e4bf817a6946213f814947079
2025-02-26 09:03:52 +00:00
Jakob Ackermann
8138c76c1d [web] restrict external heartbeat/server ping to websocket transport (#23830)
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: c03a78e2c05cd380b705bd14652060980682cb39
2025-02-25 09:05:02 +00:00
Jakob Ackermann
4d857b7937 [web] editor connection fixes (#23807)
* [haproxy] add support for xhr-polling in real-time

* [web] try 3 WebSockets then fallback to xhr-polling when (re-)connecting

* [web] ensure old socket.io transport has been closed when reconnecting

* [web] close xhr-polling transport before leaving the page

This will de-register the client, leave the project and clean up the
connected clients tracking ASAP.

* [web] rename constant to avoid confusion

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: 55e500c341145947e5589875438fc796394b6ae4
2025-02-25 09:04:58 +00:00
Antoine Clausse
82f2e47476 [web] Show DS Navigation for all SAAS users regardless of feature flag (with fix!) (#23821)
* Reapply "[web] Show DS Navigation for all SAAS users regardless of feature fla…"

This reverts commit 8d4096a7e4b6a7894b1bef14290548225deebd57.

* Fix: `hasDsNav` should check `isOverleaf` !!!

* Change `hasDsNav` from a boolean to a function call for dynamic evaluation

GitOrigin-RevId: 17463ac113a4278ed344622552d83da93b208b4d
2025-02-25 09:04:54 +00:00
Antoine Clausse
47dd074c36 Merge pull request #23811 from overleaf/revert-23801-ac-remove-ds-nav-code-3
Revert "[web] Show DS Navigation for all SAAS users regardless of feature flag"

GitOrigin-RevId: 3a5b5603718da2fddabc9f1460151efd9cbf6178
2025-02-24 09:06:11 +00:00
Antoine Clausse
c31dffc605 [web] Show DS Navigation for all SAAS users regardless of feature flag (#23801)
* Remove `sidebar-navigation-ui-update` as true from analytics events

* Hide "ds-nav" survey for users who have the feature flag

* Replace `useIsDsNav()` by `isOverleaf`

* Rename former `hideDsSurvey` to `hideDsSurvey`, and set `hasDsNav = isOverleaf` variable

so the intent is clearer.

* Update frontend tests

GitOrigin-RevId: 2be9f88a10da430c0429de15d777d98104327f9f
2025-02-24 09:06:04 +00:00
Alf Eaton
e151be6b89 Avoid selecting word when opening spell check context menu (#23756)
GitOrigin-RevId: 0276979d18583f5813476b2ac01a8eb33b352fcb
2025-02-24 09:05:36 +00:00
Alf Eaton
816410f2d4 Remove aria-hidden from theme menu divider option (#23704)
GitOrigin-RevId: c6df23ad5869aaff41beb767ecd5d1d86910a267
2025-02-24 09:05:31 +00:00
Alf Eaton
e8a6cb340e Remove link from DS in side nav (#23759)
GitOrigin-RevId: 0724fecd45ce3686be25d394aaea9c2c2b97f669
2025-02-24 09:05:18 +00:00
Alf Eaton
a7e00e19e2 Only dispatch doc:changed event for insert or delete operations (#23779)
GitOrigin-RevId: b3425d4edffb045b2a15e5fc5cb69210d9e97203
2025-02-24 09:05:02 +00:00
Alf Eaton
6688b81ece Ensure that the Chat pane is disabled for read-only link collaborators (#23785)
GitOrigin-RevId: 56e1b1d6b08ec7537386cab0b251e325d681e117
2025-02-24 09:04:58 +00:00
Domagoj Kriskovic
ebab25058a Allow selecting comment text without changing scroll position (#23628)
* Allow selecting comment text without changing scroll position

* cursor:default on review content

* check text selection on mouseup

* update comment

GitOrigin-RevId: f867613f5b4d08c3b960abfa061b14b404f411a8
2025-02-24 09:04:45 +00:00
Domagoj Kriskovic
d8b850f740 Convert track changes to proper format when reviewer role is enabled (#23683)
GitOrigin-RevId: 2ac696804491f61e52b4645dff7f64339c47afc5
2025-02-24 09:04:41 +00:00
Antoine Clausse
3976210485 Merge pull request #23798 from overleaf/revert-23767-ac-remove-ds-nav-code-small
Revert "[web] Show DS Navigation for all users regardless of feature flag "

GitOrigin-RevId: 569800d75e1ef3ed6af666325213f1615c8f3a43
2025-02-24 09:04:37 +00:00
Antoine Clausse
7b2f51aad5 [web] Show DS Navigation for all users regardless of feature flag (#23767)
* Remove uses of `useIsDsNav`

* Remove `sidebar-navigation-ui-update` as true from analytics events

* Hide "ds-nav" survey for users who have the feature flag

* `make cleanup_unused_locales` & `bin/run web npm run extract-translations`

* Update frontend tests

GitOrigin-RevId: 83f429d81ca1b46e9eab4fc667a921026a85912f
2025-02-21 09:05:48 +00:00
Antoine Clausse
34cac93f9a [web] When switching primary email, delete the old primary if it's unconfirmed (#23688)
* Add note to ConfirmModal: unconfirmed primary will be deleted

* Change confirm button copy

* Promisify `UserEmailsController.setDefault`

* Update tests after promisification

* Delete unconfirmed primary when swapped

* Fixup apostrophe in translation

* `npm run extract-translations`

* Add unit tests

* Add acceptance tests

* Fix frontend tests

* Make email address bold

* Add "We removed the previous primary..." to the email

GitOrigin-RevId: c971e219e36e509f9963e1720acdd44f562a05b5
2025-02-21 09:05:44 +00:00
Eric Mc Sween
12abf74620 Merge pull request #23689 from overleaf/em-dp-mj-interstitial-join-project-bs5
Migrate interstitial join project page to Bootstrap 5

GitOrigin-RevId: 10f45eecb33e087373a9605074ef9f8562ca2b8f
2025-02-21 09:05:00 +00:00
Eric Mc Sween
2710e37caf Merge pull request #23715 from overleaf/em-zoom-tooltips
Change copy for zoom tooltips

GitOrigin-RevId: e87d66d22bba93b9e9ee5e6938a99d003e70131a
2025-02-21 09:04:56 +00:00
roo hutton
14e76b5a72 Misc fixes for updated compile timeout paywall (#23741)
* hide cached files/logs and files buttons while primary paywall showing

* replace plans link with interstitial

* open checkout in new tab

* editors > collaborators, use correct collab count for student plan, refactor collab translations

* fix variable case

GitOrigin-RevId: 48f53aa385ed6d7e5c9b485fe4a045a47c448777
2025-02-21 09:04:52 +00:00
David
64bb822e41 Merge pull request #23738 from overleaf/ae-blur-handler-timeout
Wrap "Add Comment" blur action in setTimeout

GitOrigin-RevId: 632555d94c8a33a095f3b9a10089714eeae2d962
2025-02-21 09:04:36 +00:00
David
3a9587797d Merge pull request #23710 from overleaf/dp-remove-file-tree-workaround
Remove pre-filetree work around for new editor

GitOrigin-RevId: 7b34e4e298324ad217b603b48abbfbfa78d21804
2025-02-21 09:04:32 +00:00
David
2d02111e06 Merge pull request #23697 from overleaf/dp-layout-switcher
Add layout switcher button to toolbar

GitOrigin-RevId: 33bf664c2e2cb5c2f992b70fd9ca90b5dfe2ee44
2025-02-21 09:04:28 +00:00
Domagoj Kriskovic
725db44392 Change scrollTo behavior when review panel entry is selected (#23720)
GitOrigin-RevId: 86fc08f437c49bdf00a9b7d8461b9476f2e9717f
2025-02-21 09:04:10 +00:00
Alf Eaton
8ca5360454 Reapply "Increase the length of unsaved doc time before the editor is locked" (#23723)
* Reapply "Increase the length of unsaved doc time before the editor is locked (#23431)"

This reverts commit d0efca398e59ca488c530ee9ec5ca76f29843679.

* Use pendingOpCreatedAt if inflightOpCreatedAt isn't set

GitOrigin-RevId: b3301d7cc1554215a4ba569537bd47beeefde20f
2025-02-20 09:06:31 +00:00
Alf Eaton
0d85fd775c Encapsulate left menu loading error (#23724)
GitOrigin-RevId: 6f53b4932f6e691b7aaaa5d308571561af636877
2025-02-20 09:06:14 +00:00
Alf Eaton
432bbe0db8 Merge pull request #23714 from overleaf/ae-revert-unsaved-docs
Revert "Increase the length of unsaved doc time before the editor is locked"

GitOrigin-RevId: 0f2d257a55ebc3353ded2b10d505bfdb2e85f402
2025-02-20 09:05:53 +00:00
Eric Mc Sween
483c97a484 Merge pull request #23691 from overleaf/em-resolve-comments-permissions
Add resolveAllComments and resolveOwnComments permissions

GitOrigin-RevId: 1fca9391dc3ff6e890532054582c49f11731e987
2025-02-20 09:05:45 +00:00
Eric Mc Sween
ae491f910b Merge pull request #23692 from overleaf/em-history-errors
Move error boundary inside history container

GitOrigin-RevId: cd4c911cef18b50cd4187f655e818c9ab851cfe0
2025-02-20 09:05:40 +00:00
Alf Eaton
f40118e58b Increase the length of unsaved doc time before the editor is locked (#23431)
* Use opInflightSince to measure unsaved doc time
* Use performance.now() for lastAcked timestamp
* Use inflightOpCreatedAt
* Increase MAX_UNSAVED_ALERT_SECONDS to 15
* Increase MAX_UNSAVED_SECONDS to 30
* Increase FATAL_OP_TIMEOUT to 45000
* Convert "Connection lost" modal to a notification

GitOrigin-RevId: 2d4233723620fd03ce6d6c5795c48c33c0b2f92c
2025-02-20 09:05:20 +00:00
Alf Eaton
04a2e24a89 Use refs and timeout for editor heartbeat events (#23340)
GitOrigin-RevId: 4eb7697fb40c9aaf523765c256c870a21afb0844
2025-02-20 09:05:15 +00:00
Alf Eaton
97d7a60f68 Increase the maximum width of the search input (#23140)
GitOrigin-RevId: 70619c42cbbb16047a929e773a30ba4c0b5cfa50
2025-02-20 09:05:11 +00:00
Eric Mc Sween
4152d3d796 Merge pull request #23667 from overleaf/em-read-only-label-version
Prevent read-only users from labelling a version

GitOrigin-RevId: 472e70f3860553b131f20afe3dfd01aa00bd48fa
2025-02-19 09:05:26 +00:00
Eric Mc Sween
79bb2e3d40 Merge pull request #23673 from overleaf/em-reviewer-role-delete-replies
Let reviewers delete their own comments

GitOrigin-RevId: bd5341a917a3e886dc573d7e42d12343da6700cd
2025-02-19 09:05:21 +00:00
Mathias Jakobsen
a34ebd3c7e Merge pull request #23660 from overleaf/mj-history-tooltip
[web] Editor redesign: Add tooltip to history button

GitOrigin-RevId: c14dab2c6d62d10312f9d5097fd95cad5cae1397
2025-02-19 09:05:17 +00:00
Mathias Jakobsen
fb12a1bc8e Merge pull request #23656 from overleaf/mj-ide-toolbar-buttons
[web] Reduce toolbar and rail size in editor redesign

GitOrigin-RevId: 9e9670c37664355f4bc287a5561b427768bb4436
2025-02-19 09:05:12 +00:00
David
46e9c69d8e Merge pull request #23597 from overleaf/dp-integrations-panel
Add integration panel to new editor

GitOrigin-RevId: 85e038c645e40d0ea596ed35d31448caa232e298
2025-02-19 09:05:02 +00:00
roo hutton
e954afa1c2 Merge pull request #23618 from overleaf/rh-compile-timeout-paywall-event-tracking
Add events to compile timeout paywall

GitOrigin-RevId: 2982e1a8c6494bafbc3137a25f5e9eb08182812b
2025-02-18 09:04:26 +00:00
Kristina
61f4e3f9d5 [web] fix UI regressions on share modal (#23542)
* restore `yellow-40` to the warning label
* adjust actions layout so dropdown always stays readable

GitOrigin-RevId: 60886cd71e7041976fe2467cf7ab946a6ef90be6
2025-02-18 09:04:21 +00:00
Antoine Clausse
ed3442ada6 [web] Update socket diagnostics: 2 columns, copy to clipboard (#23581)
* Use 2 columns for socket diagnostics

* Fixup time so it's never negative

* Add "Copy to clipboard" feature

GitOrigin-RevId: ba7bcc672287c2697afadd904ade315b4a39f954
2025-02-17 09:05:07 +00:00