Commit graph

261 commits

Author SHA1 Message Date
Tim Down
5c4cb50628 Merge pull request #24988 from overleaf/td-bs5-upgrade-and-rename
Apply minor upgrades to Bootstrap 5 and react-bootstrap

GitOrigin-RevId: eb013f38515ebd4b9572d139f00841aca344e3c6
2025-05-16 08:05:28 +00:00
Rebeka Dekany
7c79c3b4c3 Add ARIA attributes for menu and separator (#25501)
GitOrigin-RevId: ef80d2811ecee78adc8bb359cf3b059d79fe9900
2025-05-13 08:08:36 +00:00
Tim Down
7abafb01ea Merge pull request #23940 from overleaf/td-react-18
Upgrade to React 18

GitOrigin-RevId: 9b81936e6eea2bccd97fe5c2c5841f0b946371b8
2025-05-02 08:05:29 +00:00
Antoine Clausse
13270dee2d [web] Tear down sidebar-navigation-ui-update, Update project-list look in SP/CE (#24920)
* Remove hacks that conditionally hid `ds-nav` survey

* Remove `getAssignment` of `sidebar-navigation-ui-update`

* Remove `hasDsNav`: make it true everywhere

* Remove dead code

* Update Footer so thin footer is shown in SP/CE

* Run `web$ make cleanup_unused_locales` & `bin/run web npm run extract-translations`

* [server-pro] fix learn wiki tests following DS navigation changes

* [server-pro] tests: remove logout action before switching session

* [server-pro] tests: fix logout test

* [server-pro] tests: use new css class for sidebar on project dashboard

* Revert "should add a documentation entry to the nav bar" test change

---------

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: 93eb7a1b03bb4e54ad1770150d83778b8f7f6727
2025-04-25 08:05:29 +00:00
Mathias Jakobsen
dfc00ed8c1 Merge pull request #24949 from overleaf/mj-papers-notification-papers-feature
[web] Show papers notification to users with papers feature

GitOrigin-RevId: 376ed7a43bec28766f89101588ed2546ec3093d2
2025-04-17 08:05:49 +00:00
Mathias Jakobsen
8fc206073b Merge pull request #24923 from overleaf/dp-mj-papers-notification
Add notification banner for Papers integration marketing

GitOrigin-RevId: 625c3afcc6ca617fd01af58a05a6c85f7126398b
2025-04-17 08:05:19 +00:00
Rebeka Dekany
562ef81389 Cleanup Bootstrap 3 code in the Account settings page (#24058)
* Remove the Bootstrap 5 version utilities

* Remove Account settings LESS stylesheet and unused styles

* Prefer using the OLFormText wrapper component instead of FormText

* Remove the Bootstrap 3 version stories

* Replace Font Awesome icons to Material icons

* Fix the heading hierarchy

* Cleanup unused translation

* Restore ellipsis to the text of two loading spinners

* Add loading button tests back and add some button loading labels

---------

Co-authored-by: Tim Down <158919+timdown@users.noreply.github.com>
GitOrigin-RevId: 283a9167c8c78bf0fe5062840ded6917dcd6263b
2025-03-24 10:49:33 +00:00
Tim Down
c2da12939e Merge pull request #24313 from overleaf/td-ac-bs5-frontend-tests
Update front-end tests to use Bootstrap 5

GitOrigin-RevId: abaa09f8c0639d64d6ade97468ab16204e5de97b
2025-03-24 10:48:20 +00:00
Tim Down
09b68de041 Merge pull request #24083 from overleaf/td-bs5-misc-bs3-removal
Remove Bootstrap 3 components in a few places

GitOrigin-RevId: 0380506543b40f3d8d83f2bf6199af28f61ad5af
2025-03-18 09:05:17 +00:00
Rebeka Dekany
69bc8a135b Bootstrap 3 cleanup from the IDE page - #2 (#24175)
* Remove skipLoadingStyleSheet

* Remove unused bootstrap-5 assignment from the Account settings page since it's archived

* Remove bsVersionIcon

* Remove bsVersion, bootstrapVersion and isBootstrap5 from elements on the IDE page

* Remove BS3Dropdown from the context menu

* Cleanup Bootstrap 3 related comment and type

GitOrigin-RevId: a67244eb78943ee84cc5f89bae164c0361e8fc13
2025-03-11 09:05:00 +00:00
Rebeka Dekany
cd133e8240 Show dashboard notification for unconfirmed emails and untrusted secondary emails (#23919)
* Show an aggressive dashboard notification for unconfirmed emails
Show a persistent dashboard notification for untrusted secondary emails

* For emails before the cutoffDate, start displaying the notification on the deletionDate and show the notification for 90 days

* Update the email deletion logic for displaying the email notification and update test

* Update test

GitOrigin-RevId: 1b0e44f79592292d428c634dc1ec4df9e6ceaeb4
2025-03-07 09:05:50 +00:00
Eric Mc Sween
4ccc21ca85 Merge pull request #24046 from overleaf/em-cdn-assets
Load assets from the CDN in selected pages

GitOrigin-RevId: c2b25f74e30c0ce47e486855dee3815d72d43d47
2025-03-06 09:05:23 +00:00
Antoine Clausse
82f2e47476 [web] Show DS Navigation for all SAAS users regardless of feature flag (with fix!) (#23821)
* Reapply "[web] Show DS Navigation for all SAAS users regardless of feature fla…"

This reverts commit 8d4096a7e4b6a7894b1bef14290548225deebd57.

* Fix: `hasDsNav` should check `isOverleaf` !!!

* Change `hasDsNav` from a boolean to a function call for dynamic evaluation

GitOrigin-RevId: 17463ac113a4278ed344622552d83da93b208b4d
2025-02-25 09:04:54 +00:00
Antoine Clausse
47dd074c36 Merge pull request #23811 from overleaf/revert-23801-ac-remove-ds-nav-code-3
Revert "[web] Show DS Navigation for all SAAS users regardless of feature flag"

GitOrigin-RevId: 3a5b5603718da2fddabc9f1460151efd9cbf6178
2025-02-24 09:06:11 +00:00
Antoine Clausse
c31dffc605 [web] Show DS Navigation for all SAAS users regardless of feature flag (#23801)
* Remove `sidebar-navigation-ui-update` as true from analytics events

* Hide "ds-nav" survey for users who have the feature flag

* Replace `useIsDsNav()` by `isOverleaf`

* Rename former `hideDsSurvey` to `hideDsSurvey`, and set `hasDsNav = isOverleaf` variable

so the intent is clearer.

* Update frontend tests

GitOrigin-RevId: 2be9f88a10da430c0429de15d777d98104327f9f
2025-02-24 09:06:04 +00:00
Alf Eaton
e8a6cb340e Remove link from DS in side nav (#23759)
GitOrigin-RevId: 0724fecd45ce3686be25d394aaea9c2c2b97f669
2025-02-24 09:05:18 +00:00
Antoine Clausse
3976210485 Merge pull request #23798 from overleaf/revert-23767-ac-remove-ds-nav-code-small
Revert "[web] Show DS Navigation for all users regardless of feature flag "

GitOrigin-RevId: 569800d75e1ef3ed6af666325213f1615c8f3a43
2025-02-24 09:04:37 +00:00
Antoine Clausse
7b2f51aad5 [web] Show DS Navigation for all users regardless of feature flag (#23767)
* Remove uses of `useIsDsNav`

* Remove `sidebar-navigation-ui-update` as true from analytics events

* Hide "ds-nav" survey for users who have the feature flag

* `make cleanup_unused_locales` & `bin/run web npm run extract-translations`

* Update frontend tests

GitOrigin-RevId: 83f429d81ca1b46e9eab4fc667a921026a85912f
2025-02-21 09:05:48 +00:00
Rebeka Dekany
a9d4341a26 Merge pull request #23489 from overleaf/rd-fix-label-alignment-project-dashboard
[web] Fix the label alignment of tags

GitOrigin-RevId: fe0a530131148fc166b16c968dcec12a082a7413
2025-02-12 09:06:02 +00:00
Tim Down
3082e4c5cc Merge pull request #23220 from overleaf/td-bs5-paused-plan-remove-bs3
Remove Bootstrap 3 styles from paused plan widget

GitOrigin-RevId: 1f04ab5c356f60330a9c5266b81de114dd81f943
2025-02-10 09:05:01 +00:00
Jimmy Domagala-Tang
e228b77c14 Merge pull request #22840 from overleaf/revert-22795-jdt-offline-survey
Revert "feat: enable temporary survey hardcoded to only non ds-nav users"

GitOrigin-RevId: d48b629572e1b6b29121c3e1b54a70f3a8b4c884
2025-01-28 09:05:20 +00:00
roo hutton
ad096f82bf Merge pull request #21905 from overleaf/rh-pause-sub
Add support for pausing subscription

GitOrigin-RevId: f939ea4e7f3c2b1fa16dcb8aff1b2460d091d4e2
2025-01-23 09:06:04 +00:00
Rebeka Dekany
84deec4e5a Merge pull request #22993 from overleaf/rd-searchbar-button-fix-migration
[web] Fix close button alignment of search bar

GitOrigin-RevId: ef6761f6f068090d8cbf7e8922b257bd499ee5c3
2025-01-21 09:06:15 +00:00
Antoine Clausse
f9cc0c3bf4 [web] Scope ds-nav split test to project list (#22689)
* Add `dsNavStyle` prop, so `sidebar-navigation-ui-update` doesn't change all pages

* Use `useIsDsNav` instead of `useSplitTestContext`

* Create a `useDsNavStyle` hook

* Use `useDsNavStyle`

* Add comment on `useIsDsNav` and `NavStyleContext`

* Revert "Hide nav dropdown chevron icon in welcome page"

This reverts commit 78b5ba85

* Move `DsNavStyleProvider` usage to project-list-ds-nav.tsx

* Fix typo

* Simplify `useDsNavStyle` conditions

GitOrigin-RevId: df3fe66d772919c40df69d357bee6949ab413928
2025-01-17 09:05:41 +00:00
Jimmy Domagala-Tang
6d5354d7fe Merge pull request #22795 from overleaf/jdt-offline-survey
feat: enable temporary survey hardcoded to only non ds-nav users
GitOrigin-RevId: b96ebb64d5a92d1c2421fc828a1769f31b7d363f
2025-01-10 09:05:40 +00:00
Mathias Jakobsen
f89d70f9a8 Merge pull request #22668 from overleaf/ae-deprecated-safari-14
Restore the deprecated browser message

GitOrigin-RevId: 93b49db87893aba7e85da6d831ed446cd66fc10f
2025-01-08 09:04:45 +00:00
Lucie Germain
ee4c8b5fe2 Merge pull request #22630 from overleaf/td-ds-nav-system-messages
Add system messages to DS nav version of project dashboard

GitOrigin-RevId: 85830d58242300a40148190f8a18204666a3065c
2024-12-20 09:05:25 +00:00
Antoine Clausse
bce3d4df78 Update SurveyNotification style for DS Nav (#22585)
* Hide the "DS nav" survey for users on the default variant

* Create and use `SurveyWidgetDsNav`

* Add link to SurveyWidgetDsNav button

* Revert SurveyNotification changes in the DS Nav mobile view

* Hide DS nav survey via JS rather than CSS

* Remove survey card in DS nav project dashboard mobile view in the short term

* Change sr-only to visually-hidden

* Fix typo

---------

Co-authored-by: Tim Down <158919+timdown@users.noreply.github.com>
GitOrigin-RevId: 6ff91637bcc8ad29c383627c7218f644a7b19d75
2024-12-19 09:04:47 +00:00
Alf Eaton
abbac67954 Remove Writefull promo banner from projects dashboard (#22568)
GitOrigin-RevId: 49f95f1317462248f4841882ec0ef0ac23c45fe3
2024-12-19 09:04:42 +00:00
Antoine Clausse
14ba6013ac Replace tags-list dropdown icon to Phosphor ThreeDotsVertical (#22562)
GitOrigin-RevId: 50c70aca162e787eb6ab051ac56c6b226a6c6aa6
2024-12-18 09:06:26 +00:00
Antoine Clausse
a1e42ff003 [web] Reapply "Update navigation events (navbar menu, new project)" and bugfix (#22576)
* Reapply "[web] Update navigation events (navbar menu, new project) (#22473)"

This reverts commit 134809f73c57d3f019e8158243e1fc74f9f6540a.

* Set the analytics event on the links, not the small contained span (pug)

* Fixup `menu-click` events in pug files: use `trackingKey`, correct event name, ...

* Add `location` prop in NavDropdownMenuItems and ContactUsItem, because they're used in the sidebar too

GitOrigin-RevId: 0bb95f69182268c34929f51121f2d5a2b19c4692
2024-12-18 09:06:18 +00:00
Antoine Clausse
27ea8211f3 Merge pull request #22575 from overleaf/revert-22473-ac-ds-nav-analytics-events
Revert "[web] Update navigation events (navbar menu, new project)"

GitOrigin-RevId: 9608be862e272c29ed92524ae6b8484094e8e0ff
2024-12-18 09:05:35 +00:00
Antoine Clausse
c6506d9a2e [web] Update navigation events (navbar menu, new project) (#22473)
* Add project-list-events.ts

* Add event `menu-expand`

* Add event `menu-click`

* Add event `new-project-expand`

* Add event `new-project-click`

* Change `menu-clicked-*` events to "`menu-clicked`+trackingKey"

* Add `SplitTestProvider` to header-footer-react

* Convert to `menu-click` events in pug files

* Add sidebar `menu-expand` events

* Fixup formatting after rebase

* Fixup format after merge

* Get location type from `ExtraSegmentations`

* Replace `any` by `ExtraSegmentations['menu-click']['item']`

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* Use `string & {}` trick to type `new-project-click.item`

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* Add `location: 'top-menu'` to Pug events

* Add `menu-expand` tracking event

---------

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>
GitOrigin-RevId: c290835c9b92a25a758cec94b49103edcdcdffed
2024-12-18 09:05:23 +00:00
Antoine Clausse
df727d64c3 Merge pull request #22548 from overleaf/ac-ds-phosphor-icons-and-splittests-bugfix
[web] Reapply  Use icons from @phosphor-icons/react for the project-list (DS nav)

GitOrigin-RevId: b87767b7c875ff4c081590e7bc0111892c0a1435
2024-12-17 09:05:32 +00:00
Tim Down
79e4b76551 Merge pull request #22222 from overleaf/td-thin-footer-react
Implement thin footer in Bootstrap 5

GitOrigin-RevId: c45f63b3d2536e6266eb55cc95df11b53a6b77ec
2024-12-17 09:05:23 +00:00
Antoine Clausse
0c40841d9f Merge pull request #22547 from overleaf/revert-22517-ac-ds-nav-phosphor-icons
Revert "[web] Use icons from `@phosphor-icons/react` for the project-list (DS-Nav)"

GitOrigin-RevId: 350f5d69a8f575d8ee4e3bd6af46e4e5f7137c7d
2024-12-17 09:05:19 +00:00
Antoine Clausse
bb8bdd04af [web] Use icons from @phosphor-icons/react for the project-list (DS-Nav) (#22517)
* Use icons from `@phosphor-icons/react`

https://phosphoricons.com/

* Add the phosphor Plus icon to the tag list

* Add SignOut icon

* Use Phosphor icon for tags

* Fix icon color when active

* Add offset to dropdown menus so they're positioned like in Figma

---------

Co-authored-by: Tim Down <158919+timdown@users.noreply.github.com>
GitOrigin-RevId: 039e98063d775d0348d227202d5ecd6a0bfb7b65
2024-12-17 09:04:57 +00:00
Antoine Clausse
90b16e4c8e [web] DS-Nav footer tweaks (#22482)
* Footer tweaks (add border, main-content 100vh)

* Update color to be the same as the sidebar `<hr>`

* Move the border to the larger div so it also separates with the navbar

* Update border color to be the same as the background

* Fixup lint

* Fixup main content padding on mobile view

See https://github.com/overleaf/internal/pull/22186#discussion_r1876087478

* Change the border color to neutral-20

* Use `--border-divider` which is the same color as --neutral-20 (`#e7e9ee`)

* Replace `@media (width >= 768px)` by `@include media-breakpoint-up(md)`

* Replace `min-height: 100dvh` by `min-height: 100%`

GitOrigin-RevId: 426869e9b96a1ee8245c487bb80ff01856521a34
2024-12-16 09:05:14 +00:00
Antoine Clausse
f2d6c73f75 [web] Update project-list Navbar for mobile (#22478)
* Control if nav items are shown with CSS instead of JS

* Fix navbar style for mobile view

* Update navbar toggle icon to close

* Hide "Projects" nav item from the navbar

* Add separator above the Help menuitem in the mobile navbar

* Adjust sidebar padding: 24px from the logo

GitOrigin-RevId: ba587645f56febc0da798269bd6aa8c2e1639c27
2024-12-16 09:05:02 +00:00
Antoine Clausse
e5c97f1963 [web] Add box shadows to scrollable part of sidebar (#22400)
* Add box shadows to scrollable part of sidebar

* Fix lint

* Fix `isAtBottom` boolean on Firefox

* Throttle the `scroll` event

* Remove wrong and unnecessary comment

GitOrigin-RevId: 7bcbb7fc860ab32f44203b3ae9ff37a3fed069a8
2024-12-16 09:04:49 +00:00
Antoine Clausse
b165e71ba9 [web] Update footer responsiveness with container queries (#22346)
* Remove padding around the footer

* Use CSS container queries instead of media queries on the full window

Container queries are supported by 92.76%	of web users, which can be an issue.
https://caniuse.com/css-container-queries

Though we do use them in other places

* Use `@supports` to check if `@container` can be used and use mixins

* Add the max sidebar width the fallback media query

* Update the footer responsiveness so we don't affect the default variant

GitOrigin-RevId: bed3e4244f1a97fd84740dcf87fb27c760be91ad
2024-12-12 09:06:09 +00:00
Antoine Clausse
62cfb68c1b [web] Add icon menus in the Sidebar (#22318)
* Add sidebar icons and menus (Help, Account)

* Place the account dropdown menu above the tooltip

* Hide tooltip when dropdown menu is shown

* Fixup tooltip position

* Add Digital Science link

* Add aria-labels on the dropdown toggles

* Update sidebar items spacings

- Add space between notification and DS icons
- Balance margin/padding in the scrollable part

* Revert changing the side of .dev-tool-bar-open-button

* Remove `!important` in link color

* Add Help tooltip

* Revert dropdown-menu z-index change

* Move `AccountMenuItems` to its own file

* Revert "Remove `!important` in link color"

This reverts commit b2de83f815d05cd1e224604d4ca355986ba76b99.

GitOrigin-RevId: 286266ea5348384f2592f748d3ae32c452558988
2024-12-12 09:06:05 +00:00
Antoine Clausse
27792199f6 [web] Update project list page main content to DS-nav-bar design (#22307)
* Move some SCSS to project-list-default.scss

* Update project-list-ds-nav.tsx to match design and simplify the SCSS

* Fix survey-notification style: light on the sidebar, dark on the main content

* Replace `withHr` by `useSplitTestContext` hook

* Override the `navbar-btn-padding-h` override.

* Fixup main content padding

Co-authored-by: Tim Down <tim.down@overleaf.com>

* Add padding-top to the logo

* Fixup merges

Add changes from https://github.com/overleaf/internal/pull/22272

---------

Co-authored-by: Tim Down <tim.down@overleaf.com>
GitOrigin-RevId: 8dbc449afbf70388bcf3185413b35234acaad349
2024-12-12 09:05:23 +00:00
Antoine Clausse
629579b840 [web] Update project list page layout and sidebar to new design (#22186)
* PoC DS nav project page shell

* Rename files: use `ds-nav` as a suffix

(really just moving code without changes)

* Update NavBar to the new design

* Small updates to project-list-ds-nav.tsx so it gets its basic shape

* Nest `.survey-notification` and `.project-list-sidebar-survey-wrapper` in the default classes to avoid interferences

* Create `SidebarDsNav`

* Add props to sidebar components so they work in both versions

* Update the SCSS code for the sidebar redesign

* Update subheader to "Organize Tags"

* Mute add affiliation font

* Remove `<aside className="project-list-sidebar-react">` and add sidebar max/min widths

* Fixup buttons padding

* Fix tests: add SplitTestProvider

* Fixup sidebar scroll div: add `flex: 1 1 auto`

* Make "Uncategorized" italic

* Update logo to SVG

* Optimize the svg
https://jakearchibald.github.io/svgomg/
9.12k → 4.92k 53.91%

---------

Co-authored-by: Tim Down <158919+timdown@users.noreply.github.com>
GitOrigin-RevId: 3d08b4b80291d9465fae87ffdf0c6a9f6deda554
2024-12-12 09:05:18 +00:00
Jimmy Domagala-Tang
2dcd1afcc5 Merge pull request #22360 from overleaf/jdt-fix-admin-panel-tests-ai
feat: updating test defaults
GitOrigin-RevId: 2be457097dcdebe13dd211f2ea24b45573b7744a
2024-12-06 09:06:58 +00:00
Jimmy Domagala-Tang
ab5a539c62 Merge pull request #22110 from overleaf/jdt-remove-assistant-from-labs
[Web] End Error Assist Labs Experiment

GitOrigin-RevId: 2570c07aea3d6b71dc59792cd2248cb890b415d3
2024-12-06 09:06:32 +00:00
Rebeka Dekany
1363045db2 Merge pull request #22272 from overleaf/rd-tag-dropdown-fix
[web] Tag dropdown menu should not be dismissed when hovering outside of it

GitOrigin-RevId: 0f0f903e07d657752e3476b9abea643bae65eb9e
2024-12-06 09:05:51 +00:00
Alf Eaton
a82952f9df Show deprecated browser message to Safari 14 (#22124)
GitOrigin-RevId: 92ba1a900f990eb8ab20870f0909816a07a5af9c
2024-12-02 09:05:13 +00:00
Tim Down
967c3e597c Merge pull request #21971 from overleaf/td-ds-nav-split-test
Add split test for DS unified nav

GitOrigin-RevId: d649661568f9c1de9d2fe47f4491540e80830ab3
2024-11-28 09:05:39 +00:00
Eric Mc Sween
0769998dd7 Merge pull request #22024 from overleaf/em-standalone-ai-add-on-is-not-premium
Do not hide upgrade buttons when on standalone AI add-on

GitOrigin-RevId: ec5cf42c051745d5ca1dff57f7cd27a89c21a6a9
2024-11-26 09:04:57 +00:00