Domagoj Kriskovic
f1c3ddb7c2
Use isReviewerRoleEnabled meta tag ( #22437 )
...
GitOrigin-RevId: e2f2529f09936a53087393d8f02968bdb5ea1acc
2024-12-12 09:04:51 +00:00
David
f1893fa03a
Show coloured squares next to collaborator names ( #22406 )
...
* Change font to content-primary
* Add user colour blocks to comments/track changes
* Format
GitOrigin-RevId: a9186e9c7c95dfe134bee2f756245275cfa9ea24
2024-12-10 13:09:37 +00:00
David
97cdc290c3
Adapt review panel header with new reviewer role ( #22291 )
...
* Adapt review panel header with new reviewer role
* Remove duplicate css property
* Update position-items
GitOrigin-RevId: a2e8dac0c1d90e6d5b3f13769909cddd69b5db14
2024-12-10 13:09:33 +00:00
David
524d743d6c
Double the max lenght of a comment before truncating ( #22409 )
...
GitOrigin-RevId: 8c4314d0b3567e7c4bd963dadf2eb698d3df3565
2024-12-10 13:09:24 +00:00
David
9ed3861c70
Merge pull request #22287 from overleaf/dp-review-safari
...
Allow review panel entry buttons to be focused in safari
GitOrigin-RevId: 1f9854534394d2561b673857fde186058e4acf49
2024-12-10 09:04:43 +00:00
Domagoj Kriskovic
6a6ef776d5
Revert "Update review entries in overview panel on collaborator changes ( #22098 )" ( #22369 )
...
This reverts commit e2d837efe889170dc055df69eae6b4e8f86cb5fc.
GitOrigin-RevId: e2c8637ffd64fc52f1a9cb36801f8688d42d4e0c
2024-12-09 09:05:00 +00:00
Domagoj Kriskovic
e83963eefc
Update review entries in overview panel on collaborator changes ( #22098 )
...
* remove unused "total" property
* add missing key
* added socket listeners
* remove accept-changes listener
* not using ranges context in overview
* fix lint error
* added comment
* add accept-changes listener
* rename to removeThreadHandler
* simplify docRanges useEffect
* refactor removeThreadHandler
* refactor accept-changes handler
* delete unnecessery event handlers
* remove edit-message listener
GitOrigin-RevId: e2d837efe889170dc055df69eae6b4e8f86cb5fc
2024-12-09 09:04:56 +00:00
Domagoj Kriskovic
fb45c3c144
Fix onKeyPress listener in AutoExpandingTextArea ( #22040 )
...
GitOrigin-RevId: 3fe870fe3aa16e6ed212ea4347a31e57444ad5e6
2024-11-22 09:05:51 +00:00
Domagoj Kriskovic
99f77b2205
Fixed "Add comment" tooltip if cursor is out of viewport ( #21852 )
...
* Fixed "Add comment" tooltip if cursor is out of viewport
* account for cm-line padding when calulation tooltip pos
GitOrigin-RevId: f4b69a3bf83dd15c0304bfd6b37f3be8b07cd727
2024-11-20 09:05:00 +00:00
Domagoj Kriskovic
8a90ffa3fb
Add confirm modal on accept/reject selected changes ( #21540 )
...
* Add showGenericConfirmModal in ModalsContext
* Add confirm modal on accept/reject selected changes
* plural in translations
* change tooltip to include selected changes
* add _plural to all translated languages
* lowercase title/tooltip
* count replacements as single change
* use new translation key
GitOrigin-RevId: afadbe1eeb2a290688b96f2b5388485f40c958d0
2024-11-12 09:06:01 +00:00
Domagoj Kriskovic
8b0b923063
Fix "show more/less" options in new review panel ( #21700 )
...
* Fix "show all/less" options in new review panel
* added newLineCharsLimit, inline options
* fix scss lint
GitOrigin-RevId: 98f29c76d4efda225515162cde0961e55acd5545
2024-11-11 09:05:21 +00:00
David
1c7e4ddcd2
Merge pull request #21450 from overleaf/dp-focus-entry
...
Refactor how ReviewPanel and TrackChangesWidget are rendered
GitOrigin-RevId: 0b206a2a70270a885befdcf2403da4e1af3aa9bf
2024-11-05 09:04:54 +00:00
David
ef90950cd3
Merge pull request #21439 from overleaf/dk-accept-reject-all-tooltip
...
Added tooltips to "Accept all" and "Reject all" options
GitOrigin-RevId: 62887e4e26964119cbb2c2aa140565c46aba94fe
2024-10-29 09:05:57 +00:00
David
7c613cdceb
Merge pull request #21438 from overleaf/dp-edit-comment-popover
...
Dont select entry from textarea when review panel is mini
GitOrigin-RevId: 5900ae11ec01bb40100e19497557469e6dac1615
2024-10-29 09:05:53 +00:00
David
9d62c620fd
Merge pull request #21410 from overleaf/dp-mini-panel-click
...
Prevent clicking on mini review panel entry popovers from opening the full panel
GitOrigin-RevId: a81ed154307750a756931d9fe5e893cd30d40c55
2024-10-29 09:04:56 +00:00
David
44b2ca1830
Manually force blur on submitting an edited message ( #21333 )
...
* Return focus to parent entry element after message is edited
* Revert "Return focus to parent entry element after message is edited"
This reverts commit 96234a666e7e7c17b99a23a8a92ea030efe6083f.
* Manually force blur on submitting an edited message
* Show review panel entry header when editing comment (#21397 )
* Show review panel entry header when editing comment
* edit comment spacing
* hide comment options when editing
---------
Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 66a8d1ed772cf91ea0f086bd08cdabaeb7456956
2024-10-28 09:05:43 +00:00
Domagoj Kriskovic
29c5bc8206
Focused and selected states for ReviewPanelEntry ( #21354 )
...
GitOrigin-RevId: 41e5ed1110d71eae51cbbde1e874dda133d666c8
2024-10-28 09:05:34 +00:00
Domagoj Kriskovic
db23262611
Scroll selection anchor into view when adding new comment ( #21328 )
...
* Scroll selection anchor into view when adding new comment
* check if cursor is near viewport edge
GitOrigin-RevId: 57d4195f7ce1513a56249365b45b3959b4ea813f
2024-10-28 09:05:29 +00:00
Domagoj Kriskovic
4bcc7c9602
Update review panel entries on layout resize ( #21323 )
...
GitOrigin-RevId: db9b01609a2425952671e30fc20c16de4d3b36a8
2024-10-28 09:05:25 +00:00
David
d74981775c
Merge pull request #21283 from overleaf/dp-keyboard-shortcuts
...
Add missing keyboard shortcuts to new review panel
GitOrigin-RevId: 78e3a63284b62c90e8a3803bd81fdf273f1a2ec9
2024-10-24 08:05:17 +00:00
David
c872d97295
Merge pull request #21250 from overleaf/dp-resolved-comments-ui
...
UI tweaks for resolved comments menu
GitOrigin-RevId: 23df6f9f0374277c315d2fb9c9940dd92ec19f4e
2024-10-24 08:05:12 +00:00
David
1c5f5950fa
Merge pull request #21208 from overleaf/dp-accept-reject-all-changes
...
Add options to accept/reject all changes to review tooltip
GitOrigin-RevId: 1cea76926d59d0354c8abaa6ba69b7e99c02fbe0
2024-10-24 08:05:08 +00:00
David
c7eafd69c2
Merge pull request #21014 from overleaf/dk-review-panel-tc-widget
...
Add "Track changes is On" button when review panel is closed
GitOrigin-RevId: a165201f611860ba531f2eeb3d89f83a695cd017
2024-10-22 08:05:50 +00:00
Domagoj Kriskovic
64460681b8
Fix delete comment/thread in the new review panel ( #21199 )
...
GitOrigin-RevId: 95d4db64d2f837322d84a81cbd129ec02ee135a2
2024-10-22 08:05:46 +00:00
Domagoj Kriskovic
c606f04cce
Sort track changes and comments in overview mode ( #21099 )
...
GitOrigin-RevId: 795d30b56e57970363512170f504ab51bd104c93
2024-10-22 08:05:37 +00:00
Domagoj Kriskovic
332e2a38c9
Fix review panel entry focus handler ( #21075 )
...
* Fix review panel entry focus handler
* dont check position
* remove event.target checks
* Revert "remove event.target checks"
This reverts commit 3f511e47b6922260666c6952b692f6f0a29d5912.
GitOrigin-RevId: 9271df9cdb36a040d59a97c88f21d6e923ac0404
2024-10-22 08:05:33 +00:00
David
87f714f7c3
Merge pull request #21164 from overleaf/dp-add-comment-keyboard-shortcut
...
Add keyboard shortcut (cmd+shift+c) for adding a new comment
GitOrigin-RevId: 20359426f45e90b09cbc887bac3096adf1b3141a
2024-10-22 08:05:15 +00:00
David
31154bb9f5
Merge pull request #21065 from overleaf/dp-limit-track-change
...
Truncate text in a tracked change
GitOrigin-RevId: a3c070f0ca2f51545151934d25a26a10c99b7465
2024-10-22 08:05:11 +00:00
David
af7e388c41
Merge pull request #21122 from overleaf/dp-rp-hide-edit
...
Hide edit option for other user's comments
GitOrigin-RevId: 317fa57402dfbe2e949fa7b196cbbe246f88257d
2024-10-22 08:05:02 +00:00
ilkin-overleaf
8bc374c916
Merge pull request #21115 from overleaf/ii-bs5-review-panel
...
[web] BS5 review panel new
GitOrigin-RevId: c65d17d0053858bd74984ba746a620b89d900606
2024-10-21 08:04:37 +00:00
Domagoj Kriskovic
e00831761a
Fix "update in progress" error when removing highlight ranges ( #21024 )
...
GitOrigin-RevId: 025e69f10b6010fe978ac57838ae17c113358633
2024-10-14 11:10:09 +00:00
David
438192fc11
Open review panel current file view when clicking add comment tooltip ( #20891 )
...
* Remove need for custom set-review-panel-open event
* Open current file view when clicking add comment tooltip
---------
Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 2b21061193f4270030d73174014aabbd017fd38e
2024-10-14 11:08:56 +00:00
Domagoj Kriskovic
4a3eed35d6
Fix accept changes request for new review panel ( #20956 )
...
* Fix accept changes request for new review panel
* Implement pessimistic UI updates for new review panel (#20986 )
* Implement pessimistic UI updates for new review panel
* deleteThread, reopenThread handlers
* use finally
* handleSubmit in useCallback
GitOrigin-RevId: 358181a6b5601ad1b3579e001564dfa4da67a81d
2024-10-14 11:08:44 +00:00
David
42a199043a
Skip ReviewPanelEntry focus event if target is anchor element ( #20928 )
...
GitOrigin-RevId: e6ad0ca7c03de2ef176b6328c27dd0afa10bd102
2024-10-14 11:08:39 +00:00
David
def2f7f4fd
Move divider into overview-file component so that they don't render if file doesn't ( #20882 )
...
GitOrigin-RevId: fef584609fa06e6313323c27bc6f9ab9b9a6c815
2024-10-14 11:08:30 +00:00
David
b1d1432183
Update add comment tooltip to match new designs ( #20913 )
...
* Update add comment tooltip to match new designs
* Rename AddCommentTooltip to ReviewTooltipMenu
* Split off add-comment-button specific padding
GitOrigin-RevId: 12a69b13b52b007eb97ba7ad6f290e3a98d741cd
2024-10-14 11:08:26 +00:00
David
037529f243
Merge pull request #20886 from overleaf/dp-overview-file-counts
...
Check that thread has messages in overview comment count
GitOrigin-RevId: 8499f837a016256c5ca615172b5c53a7f2e7c6b5
2024-10-14 11:05:53 +00:00
David
d9211998de
Merge pull request #20887 from overleaf/dp-rp-entry-buttons
...
Don't focus entry if clicking on a button/link
GitOrigin-RevId: 0c37ce76134358ef7d3fd5b0c897ffab8e4d7db1
2024-10-14 11:05:48 +00:00
David
50723d0f8f
Merge pull request #20840 from overleaf/dp-review-panel-split-test-badge
...
Add split test badge to new review panel for beta release
GitOrigin-RevId: 863b7614fc6b68aebc15dbc9bfec5014499af817
2024-10-14 11:03:05 +00:00
David
fac379b3a8
Merge pull request #20733 from overleaf/dp-align-change-icon
...
Align change icon with first line of change
GitOrigin-RevId: 319ed7ba7984fae52f31bd37a6d718ca07aa9009
2024-10-14 11:02:50 +00:00
David
a40fb42fed
Merge pull request #20712 from overleaf/dp-click-mini-panel
...
Clicking on an entry in the mini review panel opens the full panel
GitOrigin-RevId: 4c925435a09f56ae5b02c53951185c67eb0413a2
2024-10-14 11:02:44 +00:00
David
4480a986a3
Merge pull request #20785 from overleaf/dp-sticky-highlights
...
Clear op highlight on review-panel-entry dismount
GitOrigin-RevId: 9892df75f35fcb0440bd19bcfbaa276a3db033a1
2024-10-14 11:02:35 +00:00
David
2117bfe29d
Merge pull request #20541 from overleaf/dk-delete-widgets
...
Handle highlight/focus effects for track deletes in new review panel
GitOrigin-RevId: 102eed9e8af04599823c1bcf0598a0328901bdba
2024-10-14 10:59:47 +00:00
David
4c334b4b45
Merge pull request #20776 from overleaf/dp-resolve-lint
...
Provide empty decoration set to useMoreComments when addCommentRanges is undefined
GitOrigin-RevId: 40b7ae41ef783586d4304f2896397d8e84628e18
2024-10-14 10:59:42 +00:00
David
56d396a6cf
Merge pull request #20617 from overleaf/dk-review-indicator-hover
...
Improve "mini" view popovers for new review panel
GitOrigin-RevId: ff5fc0af70bd9660d5cc17437b25824ef4c9a704
2024-10-14 10:59:38 +00:00
David
a331ac6116
Merge pull request #19796 from overleaf/dp-more-comments-2
...
Add More Comments buttons
GitOrigin-RevId: 3cd6539683cbc53ceb63488ab9e9b0ffe53e079c
2024-10-14 10:59:29 +00:00
David
df2e3c1119
Merge pull request #20728 from overleaf/dp-state-field-error
...
Safeguard against addCommentStateField not existing
GitOrigin-RevId: 06f5f72bc12552b9668892a50d9789d6dfc45a9e
2024-10-14 10:59:16 +00:00
Alf Eaton
c6633632d6
Move CodeMirror contexts into a separate file ( #20643 )
...
GitOrigin-RevId: 8425454a75ff8160a03fda1be5bda2242b41f6cd
2024-09-30 08:04:48 +00:00
David
dae40941ee
Merge pull request #20638 from overleaf/dk-review-subview-mini
...
Always use current file sub view when review panel is collapsed
GitOrigin-RevId: 536476a11a9e54c79c2fe930d74639c6e676870e
2024-09-27 08:04:47 +00:00
David
2801b3baad
Merge pull request #20583 from overleaf/dk-review-gotoposition
...
Goto position when clicking on review entry in Overview tab
GitOrigin-RevId: 17c9cefed339537afa994778ffbc01cfb294bf46
2024-09-27 08:04:34 +00:00
