Commit graph

24256 commits

Author SHA1 Message Date
Tim Down
d95df5b486 Merge pull request #22579 from overleaf/td-bs5-dropdown-header-display
Remove flex from dropdown header in BS5

GitOrigin-RevId: 799b99273ed2c69af28a407a23d33628195916e9
2024-12-19 09:04:52 +00:00
Antoine Clausse
bce3d4df78 Update SurveyNotification style for DS Nav (#22585)
* Hide the "DS nav" survey for users on the default variant

* Create and use `SurveyWidgetDsNav`

* Add link to SurveyWidgetDsNav button

* Revert SurveyNotification changes in the DS Nav mobile view

* Hide DS nav survey via JS rather than CSS

* Remove survey card in DS nav project dashboard mobile view in the short term

* Change sr-only to visually-hidden

* Fix typo

---------

Co-authored-by: Tim Down <158919+timdown@users.noreply.github.com>
GitOrigin-RevId: 6ff91637bcc8ad29c383627c7218f644a7b19d75
2024-12-19 09:04:47 +00:00
Alf Eaton
abbac67954 Remove Writefull promo banner from projects dashboard (#22568)
GitOrigin-RevId: 49f95f1317462248f4841882ec0ef0ac23c45fe3
2024-12-19 09:04:42 +00:00
Alf Eaton
9c9ffd8a08 Improve spell check edit tracking (#22577)
GitOrigin-RevId: 237e454b56fc18199bf64087dd3cfb93749b8468
2024-12-19 09:04:37 +00:00
Kristina
7bc9a6673a [web] group tab on plans updates for group pricing (#22485)
* hide discounts
* show updated large groups upsell
* show group member picker
* expand educational discounts to all group plans
* add spacing above group plan prices
* change contact modal trigger to contact sales link
* add dropdown treatment to group tab improvement default treatment

GitOrigin-RevId: 690763361672e248c21198741d8870569411c8c1
2024-12-18 09:06:42 +00:00
Kristina
d488791474 [web] Update change plan flow for group-pricing-2025 (#22532)
GitOrigin-RevId: 23f6f5972b1d13b457c7c5e88f508b7cf022469a
2024-12-18 09:06:38 +00:00
Antoine Clausse
fce3adc810 [web] Update Navbar icons (Carets and Close) (#22570)
* Use Phosphor icon for navigation close

* Add carets from Phosphor

* Remove CaretUp when expanded (not in design)

* Revert "Remove CaretUp when expanded (not in design)"

This reverts commit 242f295ea18a73aae0e2cf5d2cf0dc1e610dbef9.

* Fixup: Hide the default caret in the desktop view too

* Fixup format after merge

GitOrigin-RevId: 6781028dd50922a017ef2b76fe91c4ff611dd77c
2024-12-18 09:06:34 +00:00
Antoine Clausse
0193d00735 [web] Make the new project dropdown menu scrollable (#22559)
* Make the new project dropdown menu scrollable

* Use CSS variables

GitOrigin-RevId: 9a918f2349cfc74038bde36e48b1060a4de09822
2024-12-18 09:06:30 +00:00
Antoine Clausse
14ba6013ac Replace tags-list dropdown icon to Phosphor ThreeDotsVertical (#22562)
GitOrigin-RevId: 50c70aca162e787eb6ab051ac56c6b226a6c6aa6
2024-12-18 09:06:26 +00:00
Antoine Clausse
19e962876d [web] Replace "scroll-shadow" by "scroll-borders" in the sidebar (#22563)
* Replace "scroll-shadow" by "scroll-borders" in the sidebar

* Set invisible borders to prevent "jumps"

GitOrigin-RevId: b73ec532f28627d1c55dd64cbfabec8a2efb08b2
2024-12-18 09:06:22 +00:00
Antoine Clausse
a1e42ff003 [web] Reapply "Update navigation events (navbar menu, new project)" and bugfix (#22576)
* Reapply "[web] Update navigation events (navbar menu, new project) (#22473)"

This reverts commit 134809f73c57d3f019e8158243e1fc74f9f6540a.

* Set the analytics event on the links, not the small contained span (pug)

* Fixup `menu-click` events in pug files: use `trackingKey`, correct event name, ...

* Add `location` prop in NavDropdownMenuItems and ContactUsItem, because they're used in the sidebar too

GitOrigin-RevId: 0bb95f69182268c34929f51121f2d5a2b19c4692
2024-12-18 09:06:18 +00:00
Jessica Lawshe
c9f35a2d68 Merge pull request #22586 from overleaf/jel-gallery-header
[web] Fix spacing above gallery

GitOrigin-RevId: f4460b5dc4780566cf8d0d4cda4213840530a275
2024-12-18 09:06:11 +00:00
Jessica Lawshe
2890661d5c Merge pull request #22538 from overleaf/jel-cms-tabs-as-list
[web] CMS - Add support for rendering `Layout | Tab Group` as a linkable list instead of tabs

GitOrigin-RevId: f86e78abd10029085ee8cdf4ffc7dd6e0ffd5300
2024-12-18 09:06:07 +00:00
Jessica Lawshe
2d620952b5 Merge pull request #22469 from overleaf/jel-remove-deprecated-spacing
[web] Remove deprecated row padding options

GitOrigin-RevId: c253be98d14e93123cc4362fa750e27cf5d9d0c3
2024-12-18 09:06:03 +00:00
Jessica Lawshe
ae4581d02a Merge pull request #22494 from overleaf/jel-cms-icons
[web] Support all material symbols in CMS icon element

GitOrigin-RevId: 1d65302a8e36a16761e00862acd8cba3cc9adeb5
2024-12-18 09:05:59 +00:00
M Fahru
6daf2bef45 Merge pull request #22082 from overleaf/mf-remove-is-split-test-active
[web] Remove `isSplitTestActive` function since it is no longer used

GitOrigin-RevId: 81f3f61f14bb10d403fa72a61dc4a304c191512f
2024-12-18 09:05:55 +00:00
Eric Mc Sween
659f15d010 Merge pull request #22571 from overleaf/dk-add-comment-mouseup2
Show add comment tooltip on mouse up

GitOrigin-RevId: d12b10c0c3d481a509c19eaacaf8055c2c65ff30
2024-12-18 09:05:47 +00:00
Eric Mc Sween
c1360fde7c Merge pull request #22505 from overleaf/em-add-on-checkout
Add an "Add-on:" label to the checkout page for Error Assist

GitOrigin-RevId: c25554b73aa030f880b8d10051247a7cfe5ca3e0
2024-12-18 09:05:43 +00:00
Eric Mc Sween
7cb146765c Merge pull request #22503 from overleaf/em-overleaf-assist
Rename last mentions of Overleaf Assist to Error Assist

GitOrigin-RevId: 83170de1bcf494955138f8ff6484f3fba9c1ea9b
2024-12-18 09:05:39 +00:00
Antoine Clausse
27ea8211f3 Merge pull request #22575 from overleaf/revert-22473-ac-ds-nav-analytics-events
Revert "[web] Update navigation events (navbar menu, new project)"

GitOrigin-RevId: 9608be862e272c29ed92524ae6b8484094e8e0ff
2024-12-18 09:05:35 +00:00
Tim Down
053b84d828 Merge pull request #22557 from overleaf/td-bs5-pdf-detach-height
Copy some <html> and <body> rules from BS3 to fix the detached PDF page

GitOrigin-RevId: 9c14bd4988811b857c8c3516e50589514b400ac1
2024-12-18 09:05:31 +00:00
Andrew Rumble
8417267075 Merge pull request #22188 from overleaf/ar-convert-modules-group-settings-to-es-modules
Convert modules/group-settings to es modules

GitOrigin-RevId: 3f1768fb91148722c0f0c181ab9b5a5a9174deca
2024-12-18 09:05:27 +00:00
Antoine Clausse
c6506d9a2e [web] Update navigation events (navbar menu, new project) (#22473)
* Add project-list-events.ts

* Add event `menu-expand`

* Add event `menu-click`

* Add event `new-project-expand`

* Add event `new-project-click`

* Change `menu-clicked-*` events to "`menu-clicked`+trackingKey"

* Add `SplitTestProvider` to header-footer-react

* Convert to `menu-click` events in pug files

* Add sidebar `menu-expand` events

* Fixup formatting after rebase

* Fixup format after merge

* Get location type from `ExtraSegmentations`

* Replace `any` by `ExtraSegmentations['menu-click']['item']`

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* Use `string & {}` trick to type `new-project-click.item`

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* Add `location: 'top-menu'` to Pug events

* Add `menu-expand` tracking event

---------

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>
GitOrigin-RevId: c290835c9b92a25a758cec94b49103edcdcdffed
2024-12-18 09:05:23 +00:00
ilkin-overleaf
b253d860ff Merge pull request #22554 from overleaf/ii-fl-upgrade-subscription-redirect
[web] FL subscription upgrade error handling

GitOrigin-RevId: 1c9e841ba94cec4aa4de6e91f565cdf75e251b3d
2024-12-18 09:05:16 +00:00
ilkin-overleaf
8e7f1d5e89 Merge pull request #22448 from overleaf/ii-flexible-group-licensing-add-seats-tests
[web] Add seats tests

GitOrigin-RevId: 76fb5edc6eba5579fac2d3e05cd1f64fba16046c
2024-12-18 09:05:12 +00:00
Antoine Clausse
df727d64c3 Merge pull request #22548 from overleaf/ac-ds-phosphor-icons-and-splittests-bugfix
[web] Reapply  Use icons from @phosphor-icons/react for the project-list (DS nav)

GitOrigin-RevId: b87767b7c875ff4c081590e7bc0111892c0a1435
2024-12-17 09:05:32 +00:00
Tim Down
e68d2e88e0 Merge pull request #22506 from overleaf/td-bs5-ieee-overall-theme-take-2
Always apply overall dark theme with IEEE-branded editor and tear down ieee-stylesheet feature flag, second attempt

GitOrigin-RevId: 311d125a77a46ee3f34769064005b6edea7ce013
2024-12-17 09:05:28 +00:00
Tim Down
79e4b76551 Merge pull request #22222 from overleaf/td-thin-footer-react
Implement thin footer in Bootstrap 5

GitOrigin-RevId: c45f63b3d2536e6266eb55cc95df11b53a6b77ec
2024-12-17 09:05:23 +00:00
Antoine Clausse
0c40841d9f Merge pull request #22547 from overleaf/revert-22517-ac-ds-nav-phosphor-icons
Revert "[web] Use icons from `@phosphor-icons/react` for the project-list (DS-Nav)"

GitOrigin-RevId: 350f5d69a8f575d8ee4e3bd6af46e4e5f7137c7d
2024-12-17 09:05:19 +00:00
Alf Eaton
c0cbe51828 Avoid dispatching unnecessary transaction for review panel tooltip (#22524)
* Avoid dispatching unneeded review panel effects
* Remove event listeners

GitOrigin-RevId: 17fec45f660fdd7934aa6ef3202159377902f6a5
2024-12-17 09:05:11 +00:00
Alf Eaton
d434a2ba86 Remove toolbar visibility button (#22519)
GitOrigin-RevId: 51084bf6f21a6ecaf9d38dab33a8e1541bf62bc8
2024-12-17 09:05:06 +00:00
Alf Eaton
9b82969e44 Upgrade CodeMirror dependencies (#22489)
GitOrigin-RevId: 77d2773a382ddb8dfa8f3a66bd6f8041720490b3
2024-12-17 09:05:02 +00:00
Antoine Clausse
bb8bdd04af [web] Use icons from @phosphor-icons/react for the project-list (DS-Nav) (#22517)
* Use icons from `@phosphor-icons/react`

https://phosphoricons.com/

* Add the phosphor Plus icon to the tag list

* Add SignOut icon

* Use Phosphor icon for tags

* Fix icon color when active

* Add offset to dropdown menus so they're positioned like in Figma

---------

Co-authored-by: Tim Down <158919+timdown@users.noreply.github.com>
GitOrigin-RevId: 039e98063d775d0348d227202d5ecd6a0bfb7b65
2024-12-17 09:04:57 +00:00
David
362521dd1e Show full edit/review mode dropdown on first load (#22465)
* Show full edit/review mode dropdown on first load

* Remove unneeded import

* rename localstorage value, inline event

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 7efb52d4b43588dd1ee8b7a6a5f703166b0c9b3a
2024-12-17 09:04:52 +00:00
David
4a8163b3f3 Add new trackedWrite frontend permission for review panel (#22486)
* Add new trackedWrite frontend permission for review panel

* Fix test lint

* Remove comment

* Fix codemirror tests

* hide file actions for reviewer

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 6aab5c662287a02750d81b3960bbdd9c98b325db
2024-12-17 09:04:48 +00:00
Kristina
8fa2e9ec96 Merge pull request #22447 from overleaf/kh-group-pricing-faq
[web] add group pricing change FAQ

GitOrigin-RevId: 50bbc097889fb90515fa27dd502c84f5ba3a23db
2024-12-16 09:05:47 +00:00
Antoine Clausse
555af767bd Add hover bg on navbar items (#22525)
GitOrigin-RevId: e220da99962abcaaac568f501875970747cd3d4b
2024-12-16 09:05:42 +00:00
M Fahru
c25ee1d786 Merge pull request #22464 from overleaf/mf-add-padding-bottom-login-container
[web] BS5 login page - Add sufficient spacing to prevent cookie banner from covering the bottom text on mobile

GitOrigin-RevId: e5024cf124387b2670211cee8d28ef5e6b4fc85f
2024-12-16 09:05:31 +00:00
M Fahru
d238e509c1 Merge pull request #22496 from overleaf/mf-login-register-use-social-button
[web] Use `.btn-social` for all login and register buttons that has icon on it

GitOrigin-RevId: a5590578ebf048b188d9f9ab3551907fdf5fe63d
2024-12-16 09:05:27 +00:00
M Fahru
b0a47b6c6d Merge pull request #22467 from overleaf/mf-clean-up-register-styling-bs5
[web] Clean up register and login bs5 code

GitOrigin-RevId: fcdb32d1e1ad7d0fb2862bb2726688780e42fa7c
2024-12-16 09:05:23 +00:00
M Fahru
10e1c5b320 Merge pull request #22460 from overleaf/mf-notification-website-redesign-blue-link-color
[web] Set all link inside notification to use the default blue color for all website-redesigned non-application page

GitOrigin-RevId: d5e598f7b02ff132d9686a010ff55541346f7d2e
2024-12-16 09:05:18 +00:00
Antoine Clausse
90b16e4c8e [web] DS-Nav footer tweaks (#22482)
* Footer tweaks (add border, main-content 100vh)

* Update color to be the same as the sidebar `<hr>`

* Move the border to the larger div so it also separates with the navbar

* Update border color to be the same as the background

* Fixup lint

* Fixup main content padding on mobile view

See https://github.com/overleaf/internal/pull/22186#discussion_r1876087478

* Change the border color to neutral-20

* Use `--border-divider` which is the same color as --neutral-20 (`#e7e9ee`)

* Replace `@media (width >= 768px)` by `@include media-breakpoint-up(md)`

* Replace `min-height: 100dvh` by `min-height: 100%`

GitOrigin-RevId: 426869e9b96a1ee8245c487bb80ff01856521a34
2024-12-16 09:05:14 +00:00
Eric Mc Sween
a323a5c915 Merge pull request #22527 from overleaf/revert-22471-em-tracked-deletes-at-same-position
Revert "Improve handling of tracked delete rejections"

GitOrigin-RevId: 444a5a73aa2b93162036dfc463cd76d9c463aadb
2024-12-16 09:05:10 +00:00
Antoine Clausse
f2d6c73f75 [web] Update project-list Navbar for mobile (#22478)
* Control if nav items are shown with CSS instead of JS

* Fix navbar style for mobile view

* Update navbar toggle icon to close

* Hide "Projects" nav item from the navbar

* Add separator above the Help menuitem in the mobile navbar

* Adjust sidebar padding: 24px from the logo

GitOrigin-RevId: ba587645f56febc0da798269bd6aa8c2e1639c27
2024-12-16 09:05:02 +00:00
Eric Mc Sween
6737cfa38d Merge pull request #22471 from overleaf/em-tracked-deletes-at-same-position
Improve handling of tracked delete rejections

GitOrigin-RevId: 35857d0a3f739c0531223737b2b649c9e8033157
2024-12-16 09:04:58 +00:00
Domagoj Kriskovic
db45323b93 Hide reviewer option from edit-member (#22499)
GitOrigin-RevId: 16f2b51a4856ef0f651b8b7973c34a7529d826cc
2024-12-16 09:04:53 +00:00
Antoine Clausse
e5c97f1963 [web] Add box shadows to scrollable part of sidebar (#22400)
* Add box shadows to scrollable part of sidebar

* Fix lint

* Fix `isAtBottom` boolean on Firefox

* Throttle the `scroll` event

* Remove wrong and unnecessary comment

GitOrigin-RevId: 7bcbb7fc860ab32f44203b3ae9ff37a3fed069a8
2024-12-16 09:04:49 +00:00
Brian Gough
6d1a258e7b Merge pull request #22512 from overleaf/bg-fixed-linked-files
use history-v1 for fetching linked files

GitOrigin-RevId: 32c4a35ea8c1f745e0242237c57285b3edbbb984
2024-12-16 09:04:34 +00:00
Miguel Serrano
e5cdc768b3 Merge pull request #22507 from overleaf/dependabot-maven-services-git-bridge-org.asynchttpclient-async-http-client-3.0.1
Bump org.asynchttpclient:async-http-client from 2.12.3 to 3.0.1 in /services/git-bridge

GitOrigin-RevId: cc375ff1ad1a3127aad2ac8b2987f1af3b1643b9
2024-12-16 09:04:29 +00:00
Miguel Serrano
303e85a72b Merge pull request #22492 from overleaf/msm-fix-flaky-e2e-jpg-preview
[SP] Wait for document being rendered before editor tests

GitOrigin-RevId: 4afa9b7d225ff19e6c10b061de4eef076bcd9a5d
2024-12-13 09:05:42 +00:00