* [server-pro] tests: avoid opening editor if not needed for test
* [server-pro] tests: use intercept to avoid opening editor page
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
* [server-pro] tests: use times option in intercept
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
---------
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: 9530d1f5b06766fec70631da47d8b1049b59ead5
* Update shellcheck files to include non ".sh" files having the sh shebang
* Add shellcheck to root Makefile
* `make shellcheck_fix`
* Add shellcheck to server-ce and server-pro
* Exclude SC1091 (Not following) in SP/CE
* Fix errors in SP
* Fix errors in CE
* Update root shellcheck to ignore all failing rules. We can later remove rules one by one.
* Add shellcheck to web
* Add shellcheck step for server-ce and server-pro in cloudbuild.yaml
* Revert "Add shellcheck to root Makefile"
This reverts commit e0fa56f2
* Revert "`make shellcheck_fix`"
This reverts commit eb179245c109a9e742a7fdeeb75a4bdd03963587.
* `make shellcheck_fix` in server-ce
* Fix: Use $(...) notation instead of legacy backticked
```
In init_scripts/100_set_docker_host_ipaddress.sh line 5:
echo "`route -n | awk '/UG[ \t]/{print $2}'` dockerhost" >> /etc/hosts
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
echo "$(route -n | awk '/UG[ \t]/{print $2}') dockerhost" >> /etc/hosts
For more information:
https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...
```
* `make shellcheck_fix` in web
* Manual corrections on autofix
* Update SHELLCHECK_FILES to Perl regex so it matches at start of file
GitOrigin-RevId: 815d53f319a3792efa22703beb75570de5977450
* [web] only flag errors originating from WebSocket connect as ws failure
* [web] slow down reconnecting when potentially offline
GitOrigin-RevId: 7c587d52dfe8092c45e2152f929e05e814db98f4
Co-authored-by: Brian Gough <brian.gough@overleaf.com>
Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
GitOrigin-RevId: f55de7783cb1c14108eb347eebb74ec329180000
* [haproxy] add support for xhr-polling in real-time
* [web] try 3 WebSockets then fallback to xhr-polling when (re-)connecting
* [web] ensure old socket.io transport has been closed when reconnecting
* [web] close xhr-polling transport before leaving the page
This will de-register the client, leave the project and clean up the
connected clients tracking ASAP.
* [web] rename constant to avoid confusion
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
---------
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: 55e500c341145947e5589875438fc796394b6ae4
* Reapply "[web] Show DS Navigation for all SAAS users regardless of feature fla…"
This reverts commit 8d4096a7e4b6a7894b1bef14290548225deebd57.
* Fix: `hasDsNav` should check `isOverleaf` !!!
* Change `hasDsNav` from a boolean to a function call for dynamic evaluation
GitOrigin-RevId: 17463ac113a4278ed344622552d83da93b208b4d
Previous attempt failed with `sh: gcr.io/overleaf-ops/texlive-full:2023.1: No such file or directory`.
✅ Now tested with `make prefetch_custom_texlive`
GitOrigin-RevId: 09a5e1d3c270bdb58c761c8be3c665155879290f
* Remove `sidebar-navigation-ui-update` as true from analytics events
* Hide "ds-nav" survey for users who have the feature flag
* Replace `useIsDsNav()` by `isOverleaf`
* Rename former `hideDsSurvey` to `hideDsSurvey`, and set `hasDsNav = isOverleaf` variable
so the intent is clearer.
* Update frontend tests
GitOrigin-RevId: 2be9f88a10da430c0429de15d777d98104327f9f
`xargs -d` doesn't work on Mac OS: `xargs: illegal option -- d`
There's a workaround using `tr`
See: https://stackoverflow.com/a/71409498/4823861
GitOrigin-RevId: 109c7e1e035b829122d96fd41824f18bdf81468a
