Commit graph

22129 commits

Author SHA1 Message Date
Alf Eaton
5e491cc0c0 Use thread id in removeNewCommentRangeEffect (#23205)
GitOrigin-RevId: 6082f5e6d6f548eff43da657526097118a2d3c11
2025-02-03 09:04:48 +00:00
Brian Gough
a6bfbad5bd Merge pull request #23246 from overleaf/bg-real-time-server-ping
add real-time ping-pong messages for debugging lost connections

GitOrigin-RevId: 28feb8c8c7c660a5a23ca394acd0f69ac828c5a3
2025-02-03 09:04:39 +00:00
M Fahru
e042233dd9 [web] Fix bug where VAT value isn't retained properly when changing plan without reloading (#23211)
Fix VAT info is not properly updated when changing plan without reloading.

I removed `setPlan` and created a new function: `updatePlan`. In the new function, I call the recurly function directly and the tracking code. This way, we can be sure that changing plan won't call useLayoutEffect.

Also, remove unused `useState` on the `planCode`

GitOrigin-RevId: 0d6d9fac32c15dcf13e35cf9cd9161aa07581938
2025-01-31 09:05:36 +00:00
M Fahru
438bd76c61 Use PaymentContextValue type instead of direct boolean (#23185)
GitOrigin-RevId: 2e1af64a40a4b98f84fbd7a024b1facd18e0fe90
2025-01-31 09:05:32 +00:00
Antoine Clausse
3312d97a6b [web] Add tests on find_malformed_filetrees and fix_malformed_filetree, partially fix fix_malformed_filetree (#23120)
* Create tests on find_malformed_filetrees and fix_malformed_filetrees

* Remove lines that are making fix_malformed_filetree fail

These lines are causing errors such as
```
Missing file hash: 586846800000000000000000/5891271c0000000000000000 (rootFolder.0.folders.2.fileRefs.7.hash)
SaaS: likely needs filestore restore
Server Pro: please reach out to support
```

* Add snapshots of projects after fix_malformed_filetree

* Set `WRITE_SNAPSHOT` as false

* Make `deleteProjectsRecordId0` constant

* Ignore duplicated ID errors in CreateMalformedFileTrees.mjs

* Move snapshots to directory folder

* Remove unnecessary code

* Update tests to cover use cases from the scripts

* Fix: Use `new ObjectId(projectId)` instead of the string in mongo queries

* Fix: Query `rootFolder: []` to fix more than `rootFolder: { $size: 0 }`

* Remove/rename files from first draft

* Remove empty strings from expects in unrelated tests, now that `filterOutput` removes them

* Add missing `expectFixStdout` to tests

* misc: rename test util to strId

* Add "well formed filetrees" to test cases

* Use `wellFormed` variable to remove some duplication

* Update tests:
- check Missing file hash path
- remove test on string/numbers as array items

* Add test "bug: shifted arrays in filetree"

* Rename `wellFormedFile` to `wellFormedFolder`

* Fix name of the root folder to `'rootFolder'`, not `'untitled'`

GitOrigin-RevId: dc098bb7ad3ca441fe2bb72b5f5f0e3bcedbdf67
2025-01-31 09:05:27 +00:00
Antoine Clausse
4738961f51 [web] Update secondary email addition: confirm with 6 digits code (#22851)
* Remove `Interstitial` from `ConfirmEmailForm`

* Allow adding `affiliationOptions` in `addWithConfirmationCode`

* Add confirmationStep in add-email.tsx

* Call `getEmails` once a secondary email is added

* Fix tests

* Lint fix

* Style confirm-email-form

Figma: https://www.figma.com/design/TWyeImDSZHhkl9akYaGmeb/24.5-Secondary-email-reconfirmation?node-id=1-449&p=f&m=dev

* Remove unnecessary `successMessage` and `successButtonText` from hidden ConfirmEmailForm

* Remove icon padding

* Rename file to confirm-email-form.tsx

* Use `OLButton`

* Add Cancel button

* Update loading states

* Remove redundant `className` with variants

GitOrigin-RevId: 62b1729cf2299da38f20fa3946273ad0193c7d54
2025-01-31 09:05:23 +00:00
Miguel Serrano
8ff8e7a4bf Merge pull request #23006 from overleaf/msm-chat-capabilities-poc-2
[web] Add option to disable chat for subscription

GitOrigin-RevId: 0052d060c74c39400496f7f9f54c820398d60012
2025-01-31 09:05:18 +00:00
Jakob Ackermann
ba60f885a4 [project-history] fetch most recent chunk once when processing updates (#23261)
GitOrigin-RevId: 08ddd1f953b0dbae0541a60b45fec0f88e0a1d06
2025-01-31 09:05:14 +00:00
Jakob Ackermann
72b4083318 [project-history] forward all the optional file attributes during resync (#23260)
Notably, 'createdBlob' was missing. And others like metadata should not
be added if not set.

GitOrigin-RevId: c4a6746c4824d637f7c54b4c68a7025b60c15ff2
2025-01-31 09:05:09 +00:00
roo hutton
50f5a4e909 Merge pull request #23161 from overleaf/rh-pause-no-plan-change
Prevent downgrade to personal plan during subscription pause

GitOrigin-RevId: e3ba2e8e4d9b909fa2ee9c3c7e15db2ed257e43b
2025-01-31 09:04:58 +00:00
roo hutton
347cade55f Merge pull request #23177 from overleaf/rh-pause-tracking
Add tracking for subscription-pause-scheduled event

GitOrigin-RevId: 802899e53d22f2be49f2d20adb45a4a47d0f6beb
2025-01-31 09:04:53 +00:00
CloudBuild
4858efd06f auto update translation
GitOrigin-RevId: afd78e117c45b7ab3c28cacfc9ec29b2e7c20e70
2025-01-30 09:05:46 +00:00
Domagoj Kriskovic
461818810c Ensure editor decorations for comments are removed in the old review panel (#23239)
GitOrigin-RevId: d41d9b9701fc792c0190f4648ce9c4ddf035a967
2025-01-30 09:05:30 +00:00
Domagoj Kriskovic
3a918a58e5 Prevent submitting comment on enter if input is empty (#23221)
* Prevent submitting comment on enter if input is empty

* check for content in keyPress event

GitOrigin-RevId: 1abef229782265836a49d74aa93625797d50dc3a
2025-01-30 09:05:26 +00:00
Eric Mc Sween
76dd6d1e20 Merge pull request #23212 from overleaf/em-docupdater-send-doc-hash
Send doc hash with history updates from docupdater

GitOrigin-RevId: 119475d4198c6603cecd4fd579a64ff4448261ce
2025-01-30 09:05:21 +00:00
David
d731afed90 Merge pull request #23134 from overleaf/dp-remove-math-preview-flag
Remove math-preview feature flag

GitOrigin-RevId: a5235cf36b692b0e3dc36ff6185ebc7ef169d21e
2025-01-30 09:05:17 +00:00
David
f523358d08 Merge pull request #23182 from overleaf/dp-pdf-error-state
Add pdf error state for new ide

GitOrigin-RevId: 35fe07744996375db9cb3b860bdc128b509ee438
2025-01-30 09:05:12 +00:00
David
069624029a Merge pull request #23080 from overleaf/dp-file-outline-in-editor
Add file outline to new editor

GitOrigin-RevId: c9b36d480b243905de8e98dcb838c56a2fe9d2b0
2025-01-30 09:05:08 +00:00
Rebeka Dekany
646e7c2ef0 Merge pull request #23071 from overleaf/rd-migrate-project-id-bs5
Migrate the admin project info page to Bootstrap 5

GitOrigin-RevId: 36ce714ca56e4aeea9f20a84fda6991fb53627c4
2025-01-30 09:05:00 +00:00
Alf Eaton
af86239f03 Reject out-of-order op ack messages (#23163)
GitOrigin-RevId: 50c48282e93925a8c40be72e8fc0b8a72d39d82d
2025-01-30 09:04:56 +00:00
Alf Eaton
8f11bc6270 Call event.preventDefault on the "full project search" keyboard shortcut (#23147)
GitOrigin-RevId: 7cd7b2fa3eaf978377fc6f402bce92229fda2c51
2025-01-30 09:04:51 +00:00
Alf Eaton
1ca47334f7 Throttle range rebuilding on edits (#23193)
GitOrigin-RevId: 86d9465af663c346805445cd57dd6f6e06049d7b
2025-01-30 09:04:47 +00:00
Alf Eaton
90aec12e84 Ensure that review panel components are memoized (#23194)
GitOrigin-RevId: 271b8b00394d6b87fddc503a70f17f8f41144ec7
2025-01-30 09:04:42 +00:00
Mathias Jakobsen
fd8fcb11f8 Merge pull request #23170 from overleaf/mj-ide-resize-handle-bg
[web] Override resize handle background colour in editor redesign

GitOrigin-RevId: b429dc5d0f0369c7bd54f29b5e499411ac9398d6
2025-01-29 09:06:00 +00:00
M Fahru
51bf63a32a Merge pull request #23125 from overleaf/mf-change-case-settings-page-form
[web] Change settings page form labels to sentence case (instead of capitalizing each word)

GitOrigin-RevId: 70cc94c2883e782928b5cfdf81ea5ed2d4ff4363
2025-01-29 09:05:47 +00:00
M Fahru
33bbb32d07 Merge pull request #23149 from overleaf/mf-disable-paypal-submit-unchecked-student-confirm
[web] Disable paypal submit button if student confirmation checkbox is not checked

GitOrigin-RevId: 3c8ca624399e249a48ac0be48cb0c5c0b4170d30
2025-01-29 09:05:43 +00:00
Domagoj Kriskovic
cd48caeaa1 Updated mongo index for ProjectDeleter (#23138)
GitOrigin-RevId: aa26f29b8917b0d6ff836cc03f82b74066a7dcd4
2025-01-29 09:05:36 +00:00
Domagoj Kriskovic
ff9ee2f5a9 Use "can write or review project content" authorization middleware (#23111)
GitOrigin-RevId: c5d1cb955e5833347f7e0c3610c5b8d768026478
2025-01-29 09:05:33 +00:00
Domagoj Kriskovic
ea918f3674 Disable restore project/file and project settings for a reviewer (#23104)
* Disable restore project/file and project settings for a reviewer

* hide github menu

* use permissions context

GitOrigin-RevId: a705ecf8bc1f722b8818baef85c5411e7a762989
2025-01-29 09:05:29 +00:00
Liangjun Song
6245e81f42 Merge pull request #22518 from overleaf/ii-flexible-group-licensing-add-seats-legacy
[web] Unlock self-served license purchasing for legacy plans

GitOrigin-RevId: bf3083d00a77417f0e78d2145f6192c57b163273
2025-01-29 09:05:25 +00:00
Liangjun Song
8808e8dfa2 Merge pull request #23128 from overleaf/ii-flexible-group-licensing-add-seats-cost-summary
[web] FL cost summary billing info

GitOrigin-RevId: eae6a7f02aa37e304144ccf75b952406567ca5d5
2025-01-29 09:05:21 +00:00
Liangjun Song
e91079d493 Merge pull request #23129 from overleaf/ii-flexible-group-licensing-sales-tax-percentage
[web] Fix sales tax percentage in add seats page

GitOrigin-RevId: 0cb0ab537fbe190d7291deb5942c244a5b0bd3af
2025-01-29 09:05:17 +00:00
Liangjun Song
d893bb76cf Merge pull request #22816 from overleaf/enable-group-plan-upgrade-for-legacy-plans
Enable group plan upgrade for legacy plans

GitOrigin-RevId: 9dde0371eeb791a6331ab50733fd457e28837ba9
2025-01-29 09:05:13 +00:00
Liangjun Song
eba4418672 Merge pull request #23060 from overleaf/ls-support-new-group-plan-in-redesigned-checkout-page
Support new group plan in the redesigned checkout page

GitOrigin-RevId: 2564477b36ee93ca4b4b6dd8210f140a3104c6ed
2025-01-29 09:05:09 +00:00
Mathias Jakobsen
ec73bbcfa0 Merge pull request #23045 from overleaf/mj-errors-tab
[web] Add errors to rail

GitOrigin-RevId: 484e28b1ff1578ec46aa6811f1d1bd1d03a02f59
2025-01-29 09:04:59 +00:00
Mathias Jakobsen
4b46120ec1 Merge pull request #22928 from overleaf/mj-ide-toolbar
[web] Initial editor toolbar

GitOrigin-RevId: 33658d886bf86cbaa22a161f2ff463ef608e5f6b
2025-01-29 09:04:55 +00:00
Alf Eaton
71ab3a41ed Remove ColorManager (#22974)
GitOrigin-RevId: 32cb6fd599345eaf8e474553da5c6d3080575ee8
2025-01-29 09:04:48 +00:00
Alf Eaton
cce8d12bf7 Remove bootstrap-5-ide split test (#23059)
GitOrigin-RevId: a812f676b6dab1d3efec4ea8ff962e144baf4299
2025-01-29 09:04:45 +00:00
Alf Eaton
6ccf61e1f2 Disable spell check if WebAssembly is not available (#23136)
GitOrigin-RevId: c209540579e0d8ff7f62dc66ff5d850450b18600
2025-01-29 09:04:41 +00:00
Alf Eaton
4e736a9e96 Check that op ack message version matches the client ShareJS doc version (#23108)
GitOrigin-RevId: f262f63ed5012aabb1bffbf0fb44d677816443be
2025-01-29 09:04:37 +00:00
Alf Eaton
9e040d6946 Select matched text when a file is opened from a full project search result (#23139)
GitOrigin-RevId: bd3b66e89b70c4fa1d77e401d9e5fa755876ce9f
2025-01-29 09:04:33 +00:00
M Fahru
8ed4199245 Merge pull request #22615 from overleaf/mf-reconfirm-page-migrate-bs5
[web] Migrate reconfirm account page to bootstrap 5 and website-redesign styling

GitOrigin-RevId: b65f3ad69a5914ce42dc58c21436c8616393f724
2025-01-28 09:05:47 +00:00
M Fahru
1916a0bbf6 Merge pull request #22613 from overleaf/mf-migrate-primary-email-check-bs5
[web] Migrate "Primary email check" page to bootstrap 5 and website-redesign styling

GitOrigin-RevId: e233edafb8c5033c8fbd97088fa1ac840e2e572e
2025-01-28 09:05:43 +00:00
M Fahru
0558761482 Merge pull request #22610 from overleaf/mf-migrate-setpassword-page-bs5
[web] Migrate set password page to bootstrap 5 and website-redesign styling

GitOrigin-RevId: a9168b4171739cd49d0b76505800bcd171bd9572
2025-01-28 09:05:39 +00:00
M Fahru
7fbcca6ed1 Merge pull request #22609 from overleaf/mf-migrate-aux-password-pages-to-bs5
[web] Migrate reset password page to bootstrap 5 and website redesign

GitOrigin-RevId: 613865379d094b305c6dc78f74dc70341214f4ed
2025-01-28 09:05:35 +00:00
Jimmy Domagala-Tang
c6824f8649 Merge pull request #21838 from overleaf/jdt-ae-wf-codec-challenge
[Web] Enable PKCE flows for Oauth server

GitOrigin-RevId: e9a61596ed64e2be8b038b35eb8ea3e21b772e97
2025-01-28 09:05:31 +00:00
Jimmy Domagala-Tang
0baaed6cdf Merge pull request #22994 from overleaf/jdt-diasble-assist
Add a toggle to hide all AI features on a users account

GitOrigin-RevId: 978b02609c40f3975daa267aa6c10ac49e13d6f3
2025-01-28 09:05:27 +00:00
Jimmy Domagala-Tang
e228b77c14 Merge pull request #22840 from overleaf/revert-22795-jdt-offline-survey
Revert "feat: enable temporary survey hardcoded to only non ds-nav users"

GitOrigin-RevId: d48b629572e1b6b29121c3e1b54a70f3a8b4c884
2025-01-28 09:05:20 +00:00
Eric Mc Sween
db44d0b6ee Merge pull request #22915 from overleaf/em-blob-caching
Improved caching for blobs

GitOrigin-RevId: c5113106ef239b201ae8f66bb3539a52c65ddb60
2025-01-28 09:05:16 +00:00
Jakob Ackermann
45a5d090d9 [web] add external 15s heartbeat to socket.io connection (#22853)
* [web] add external 15s heartbeat to socket.io connection

* [web] extend debugging context for client errors

- include performance.now() timestamp for correlating other timings
- include connectionState, especially for new externalHeartbeat detail
- include spellCheckLanguage to check on client-side spelling impact

* [web] remove unnecessary hook dependency

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>

* Refactor externalHeartbeat

* Add connectionManager to context

* Clear the interval earlier, and on connect

* [web] refactor handling of socket debugging info

* [web] add split-test for external socket heartbeat

* [web] fully remove connectionManager from connection context

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: fbebe64f8aa207eb4fd4a8f27d522d1cac35f9d4
2025-01-28 09:05:12 +00:00