Commit graph

25466 commits

Author SHA1 Message Date
Domagoj Kriskovic
ebab25058a Allow selecting comment text without changing scroll position (#23628)
* Allow selecting comment text without changing scroll position

* cursor:default on review content

* check text selection on mouseup

* update comment

GitOrigin-RevId: f867613f5b4d08c3b960abfa061b14b404f411a8
2025-02-24 09:04:45 +00:00
Domagoj Kriskovic
d8b850f740 Convert track changes to proper format when reviewer role is enabled (#23683)
GitOrigin-RevId: 2ac696804491f61e52b4645dff7f64339c47afc5
2025-02-24 09:04:41 +00:00
Antoine Clausse
3976210485 Merge pull request #23798 from overleaf/revert-23767-ac-remove-ds-nav-code-small
Revert "[web] Show DS Navigation for all users regardless of feature flag "

GitOrigin-RevId: 569800d75e1ef3ed6af666325213f1615c8f3a43
2025-02-24 09:04:37 +00:00
Brian Gough
981e91f012 Merge pull request #21763 from overleaf/bg-backup-script
initial script for running backups

GitOrigin-RevId: d22c373de30738d8080d40dce10790f0bdcb9f51
2025-02-24 09:04:32 +00:00
Jakob Ackermann
c3f94358eb [real-time] ignore error from duplicate send action on socket.io socket (#23787)
GitOrigin-RevId: 992a39a5cff04bcc0814ac6a620ad350d6e1da14
2025-02-21 09:05:52 +00:00
Antoine Clausse
7b2f51aad5 [web] Show DS Navigation for all users regardless of feature flag (#23767)
* Remove uses of `useIsDsNav`

* Remove `sidebar-navigation-ui-update` as true from analytics events

* Hide "ds-nav" survey for users who have the feature flag

* `make cleanup_unused_locales` & `bin/run web npm run extract-translations`

* Update frontend tests

GitOrigin-RevId: 83f429d81ca1b46e9eab4fc667a921026a85912f
2025-02-21 09:05:48 +00:00
Antoine Clausse
34cac93f9a [web] When switching primary email, delete the old primary if it's unconfirmed (#23688)
* Add note to ConfirmModal: unconfirmed primary will be deleted

* Change confirm button copy

* Promisify `UserEmailsController.setDefault`

* Update tests after promisification

* Delete unconfirmed primary when swapped

* Fixup apostrophe in translation

* `npm run extract-translations`

* Add unit tests

* Add acceptance tests

* Fix frontend tests

* Make email address bold

* Add "We removed the previous primary..." to the email

GitOrigin-RevId: c971e219e36e509f9963e1720acdd44f562a05b5
2025-02-21 09:05:44 +00:00
Jakob Ackermann
f0d94f06ed [server-pro] fix ldap tests (#23771)
GitOrigin-RevId: 6540b7b8766eaf5fd2c7d0b3ff3c9d627382e56e
2025-02-21 09:05:40 +00:00
Jakob Ackermann
0be79e846c [server-pro] tests: make project invite tests more reliable (#23732)
* [web] wait for sending project invite notification, send email detached

Errors from sending the notification or email are still logged only.
Wait up-to ~one second for notification to be sent (API timeout is 1s).

* [server-pro] tests: wait for invite action to complete

GitOrigin-RevId: e6998e6134b5267c91b47785d616a46e9651b996
2025-02-21 09:05:30 +00:00
Miguel Serrano
2e72aa8a47 Merge pull request #23652 from overleaf/msm-update-path-to-regexp
[monorepo] Update express to 4.1.2

GitOrigin-RevId: b3db75257e1edc1a25a1a657def352ecca926920
2025-02-21 09:05:26 +00:00
Miguel Serrano
9a2a14f588 Merge pull request #23642 from overleaf/msm-update-cross-spawin
[monorepo] Updated cross-spawn to 7.0.6

GitOrigin-RevId: 42ca1ca19957a2cddd4968ceea276bc05f659071
2025-02-21 09:05:22 +00:00
Miguel Serrano
d22ffb926d Merge pull request #23733 from overleaf/msm-configurable-login-title
[web] Add `OVERLEAF_LOGIN_SUPPORT_TITLE` for CE/SP

GitOrigin-RevId: 5a50d17ded67b68c72dbaeab5172fc283b5aaa01
2025-02-21 09:05:18 +00:00
Miguel Serrano
78297efeab Merge pull request #23680 from overleaf/msm-readonly-email-activation
[CE/SP] Fix `email` not sent on activation

GitOrigin-RevId: 3989bcc318086b3b10576138869296888be27998
2025-02-21 09:05:14 +00:00
Eric Mc Sween
fb22d6f518 Merge pull request #23725 from overleaf/em-find-dangling-comments-archived-docs
Look at archived docs when looking for dangling comments

GitOrigin-RevId: fb04b9428ce83802b6e658153c5bbe70e983de65
2025-02-21 09:05:04 +00:00
Eric Mc Sween
12abf74620 Merge pull request #23689 from overleaf/em-dp-mj-interstitial-join-project-bs5
Migrate interstitial join project page to Bootstrap 5

GitOrigin-RevId: 10f45eecb33e087373a9605074ef9f8562ca2b8f
2025-02-21 09:05:00 +00:00
Eric Mc Sween
2710e37caf Merge pull request #23715 from overleaf/em-zoom-tooltips
Change copy for zoom tooltips

GitOrigin-RevId: e87d66d22bba93b9e9ee5e6938a99d003e70131a
2025-02-21 09:04:56 +00:00
roo hutton
14e76b5a72 Misc fixes for updated compile timeout paywall (#23741)
* hide cached files/logs and files buttons while primary paywall showing

* replace plans link with interstitial

* open checkout in new tab

* editors > collaborators, use correct collab count for student plan, refactor collab translations

* fix variable case

GitOrigin-RevId: 48f53aa385ed6d7e5c9b485fe4a045a47c448777
2025-02-21 09:04:52 +00:00
Andrew Rumble
0e64fe2b21 Merge pull request #23457 from overleaf/ar-recurly-account-mapping-initial
[web] setup Recurly -> Mongo account mapping

GitOrigin-RevId: ee08cad60ee04e62100f3d5a4f76fdbcf5543917
2025-02-21 09:04:45 +00:00
Andrew Rumble
be247b8cc9 Merge pull request #23617 from overleaf/ar-lg-webpack
[web/latexqc] Bump webpack to 5.98.0

GitOrigin-RevId: 1124432fdce88df0636449d9bf0f8c99f582967c
2025-02-21 09:04:41 +00:00
David
64bb822e41 Merge pull request #23738 from overleaf/ae-blur-handler-timeout
Wrap "Add Comment" blur action in setTimeout

GitOrigin-RevId: 632555d94c8a33a095f3b9a10089714eeae2d962
2025-02-21 09:04:36 +00:00
David
3a9587797d Merge pull request #23710 from overleaf/dp-remove-file-tree-workaround
Remove pre-filetree work around for new editor

GitOrigin-RevId: 7b34e4e298324ad217b603b48abbfbfa78d21804
2025-02-21 09:04:32 +00:00
David
2d02111e06 Merge pull request #23697 from overleaf/dp-layout-switcher
Add layout switcher button to toolbar

GitOrigin-RevId: 33bf664c2e2cb5c2f992b70fd9ca90b5dfe2ee44
2025-02-21 09:04:28 +00:00
Domagoj Kriskovic
874b37c917 Added new properties to "project-opened" event (#23438)
GitOrigin-RevId: e7d3c665abfe485246281e949a645bb90f288dab
2025-02-21 09:04:21 +00:00
Domagoj Kriskovic
b75917eb9f Prevent user name in review panel to break if larger than container (#23643)
GitOrigin-RevId: 9d4948e5dc595dc39510a558edc6a008d3ef7156
2025-02-21 09:04:17 +00:00
Domagoj Kriskovic
725db44392 Change scrollTo behavior when review panel entry is selected (#23720)
GitOrigin-RevId: 86fc08f437c49bdf00a9b7d8461b9476f2e9717f
2025-02-21 09:04:10 +00:00
Brian Gough
32983da29c Merge pull request #23700 from overleaf/bg-history-redis
add redis to history-v1

GitOrigin-RevId: def900c4b560ea0a297b11b6c0ecc8cc8caa5b49
2025-02-21 09:04:06 +00:00
Alf Eaton
8ca5360454 Reapply "Increase the length of unsaved doc time before the editor is locked" (#23723)
* Reapply "Increase the length of unsaved doc time before the editor is locked (#23431)"

This reverts commit d0efca398e59ca488c530ee9ec5ca76f29843679.

* Use pendingOpCreatedAt if inflightOpCreatedAt isn't set

GitOrigin-RevId: b3301d7cc1554215a4ba569537bd47beeefde20f
2025-02-20 09:06:31 +00:00
Alf Eaton
aac5bccc54 Upgrade CodeMirror dependencies (#23707)
GitOrigin-RevId: b74813af84538f6d62bb3904be05c3782d1bdf45
2025-02-20 09:06:26 +00:00
Mathias Jakobsen
8fdefdc2bd Merge pull request #23687 from overleaf/mj-expose-font-lineheight
[web] Expose font family and lineheight to extensions

GitOrigin-RevId: 75462fd5b062b70feb152fe5e805ff5ab80f5e64
2025-02-20 09:06:22 +00:00
Alf Eaton
0d85fd775c Encapsulate left menu loading error (#23724)
GitOrigin-RevId: 6f53b4932f6e691b7aaaa5d308571561af636877
2025-02-20 09:06:14 +00:00
Jakob Ackermann
a1755c1c08 [web] fix waiting for cdn upload on staging-main (#23729)
Co-authored-by: Jimmy Domagala-Tang <jimmy.domagala-tang@overleaf.com>
GitOrigin-RevId: fdf0f2c0b0b8c9e83a1ea6f6f71305f9ff822f1f
2025-02-20 09:06:09 +00:00
Eric Mc Sween
5f6de9caf0 Merge pull request #23706 from overleaf/em-fix-dangling-comments-script
Fix dangling comments script when doc does not have ranges

GitOrigin-RevId: 31cf25ecf79f7ab0ed872c403d31b2c5064b4c76
2025-02-20 09:06:05 +00:00
Alf Eaton
432bbe0db8 Merge pull request #23714 from overleaf/ae-revert-unsaved-docs
Revert "Increase the length of unsaved doc time before the editor is locked"

GitOrigin-RevId: 0f2d257a55ebc3353ded2b10d505bfdb2e85f402
2025-02-20 09:05:53 +00:00
Eric Mc Sween
483c97a484 Merge pull request #23691 from overleaf/em-resolve-comments-permissions
Add resolveAllComments and resolveOwnComments permissions

GitOrigin-RevId: 1fca9391dc3ff6e890532054582c49f11731e987
2025-02-20 09:05:45 +00:00
Eric Mc Sween
ae491f910b Merge pull request #23692 from overleaf/em-history-errors
Move error boundary inside history container

GitOrigin-RevId: cd4c911cef18b50cd4187f655e818c9ab851cfe0
2025-02-20 09:05:40 +00:00
Davinder Singh
b38c6eab7c Customer IO - Initial functions Setup (#22972)
* adding a hello world end point in analytics service for customerio

* adding updateCustomerIoUser handler function

* setting up the function recordUserAnalyticsEvent

* removing hello function and adding end points for update and track function

* installing the node js source for customer io

* adding the the functions for identify and track events

* adding a properties property

* adding new API key

* cleaning some code and making some changes to make it work

* renaming function to include identify keyword

* adding some detailed succes messages and try catch blocks

* adding a temporary key for testing

* adding the env variable for key

* adding a fallback value for acceptance test, this will need more investigation later on

* deleting the controller, as the handler functions will directly be linked to the customerio queue, so we do not want this path anynmore

GitOrigin-RevId: 38e0cb713e5d6a14c70cdbfb2a7463c633746bbe
2025-02-20 09:05:32 +00:00
Alf Eaton
f40118e58b Increase the length of unsaved doc time before the editor is locked (#23431)
* Use opInflightSince to measure unsaved doc time
* Use performance.now() for lastAcked timestamp
* Use inflightOpCreatedAt
* Increase MAX_UNSAVED_ALERT_SECONDS to 15
* Increase MAX_UNSAVED_SECONDS to 30
* Increase FATAL_OP_TIMEOUT to 45000
* Convert "Connection lost" modal to a notification

GitOrigin-RevId: 2d4233723620fd03ce6d6c5795c48c33c0b2f92c
2025-02-20 09:05:20 +00:00
Alf Eaton
04a2e24a89 Use refs and timeout for editor heartbeat events (#23340)
GitOrigin-RevId: 4eb7697fb40c9aaf523765c256c870a21afb0844
2025-02-20 09:05:15 +00:00
Alf Eaton
97d7a60f68 Increase the maximum width of the search input (#23140)
GitOrigin-RevId: 70619c42cbbb16047a929e773a30ba4c0b5cfa50
2025-02-20 09:05:11 +00:00
Rebeka Dekany
d1ddfadd0d Merge pull request #23639 from overleaf/rd-fix-scrollbar-text-admins
Fix tables and tabs responsiveness on the admin pages

GitOrigin-RevId: 94c8cea8933f4f908c50aa404e45f23642852c15
2025-02-20 09:05:06 +00:00
Eric Mc Sween
4152d3d796 Merge pull request #23667 from overleaf/em-read-only-label-version
Prevent read-only users from labelling a version

GitOrigin-RevId: 472e70f3860553b131f20afe3dfd01aa00bd48fa
2025-02-19 09:05:26 +00:00
Eric Mc Sween
79bb2e3d40 Merge pull request #23673 from overleaf/em-reviewer-role-delete-replies
Let reviewers delete their own comments

GitOrigin-RevId: bd5341a917a3e886dc573d7e42d12343da6700cd
2025-02-19 09:05:21 +00:00
Mathias Jakobsen
a34ebd3c7e Merge pull request #23660 from overleaf/mj-history-tooltip
[web] Editor redesign: Add tooltip to history button

GitOrigin-RevId: c14dab2c6d62d10312f9d5097fd95cad5cae1397
2025-02-19 09:05:17 +00:00
Mathias Jakobsen
fb12a1bc8e Merge pull request #23656 from overleaf/mj-ide-toolbar-buttons
[web] Reduce toolbar and rail size in editor redesign

GitOrigin-RevId: 9e9670c37664355f4bc287a5561b427768bb4436
2025-02-19 09:05:12 +00:00
David
46e9c69d8e Merge pull request #23597 from overleaf/dp-integrations-panel
Add integration panel to new editor

GitOrigin-RevId: 85e038c645e40d0ea596ed35d31448caa232e298
2025-02-19 09:05:02 +00:00
Antoine Clausse
f096ffaa43 [web] Send security alert email when secondary is added (#23657)
* [web] Send security alert email when secondary is added

* [web] Add test: checkSecondaryEmailConfirmationCode - sends a security alert email

* Move `_sendSecurityAlertEmail` before `addEmailAddress`

GitOrigin-RevId: 8d9c496fffd953871e03d8c7f011c42459eeb0bc
2025-02-18 09:05:14 +00:00
Antoine Clausse
98ea3664f2 Create script: remove_unconfirmed_emails.mjs (#23079)
* Create script: remove_unconfirmed_emails.mjs

* Update script remove_unconfirmed_emails.mjs after pairing

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>

* Add user counts. Add timing

* Revert previous changes: just remove the fully unconfirmed emails

* Add tests on scripts/remove_unconfirmed_emails.mjs

* Update audit log so `removedEmail` is a string and doesn't break the admin-panel audit logs list

* Update remove_unconfirmed_emails to have a `--generate` and a `--consume` mode

* Update tests on remove_unconfirmed_emails

* Add tests checking that `--consume` doesn't delete any email

* Update script so `--consume` checks that emails shouldn't be deleted again!

* Update CSV path to `/tmp/...`

* Add test cases: deleted users, deleted email, comma in email

---------

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>
GitOrigin-RevId: 8c60b56bcdfa33bc6143d66c32a5f430fb76f6d7
2025-02-18 09:05:10 +00:00
Jakob Ackermann
b79af7f6d3 [server-ce] upgrade mongo to 6.0 in e2e tests (#23611)
* [server-ce] upgrade mongo to 6.0 in e2e tests

* [server-ce] upgrade mongo to 6.0 for CE dev-env

GitOrigin-RevId: 6a76297d32177a8b5a067d325e74bdb01971af30
2025-02-18 09:04:55 +00:00
Davinder Singh
39884d8199 Merge pull request #22733 from overleaf/ds-sso-login-redesign-bs5-2
Website Redesign & BS5 migration - SSO Login page (2)

GitOrigin-RevId: d0d5752e2ce84a70dfb50a3de0c200c468de0cb8
2025-02-18 09:04:43 +00:00
Davinder Singh
0c8e31708a Merge pull request #22716 from overleaf/ds-sso-login-redesign-bs5
Website Redesign & BS5 migration - SSO Login page

GitOrigin-RevId: 9c819479c7ca6510d2e683881564427c91c4f04e
2025-02-18 09:04:38 +00:00