Commit graph

147 commits

Author SHA1 Message Date
Tim Down
905cc5d45f Move project context out of scope value store (#26615)
* Refactor project context to not use scope store

* Fix Cypress tests for project context changes

* Fix frontend React Testing Library tests for project context changes

* Remove redundant code

* Fix some project types in tests

* Remove unused import and fix a type

* Throw an error if updating the project in the project context before joining the project

* Fix some review panel tests

* Remove unused imports

GitOrigin-RevId: 2f0c928b651f387aa980c29aef7d1ba0649790a7
2025-07-10 08:06:31 +00:00
Tim Down
132ccbc4cc Merge pull request #26583 from overleaf/td-editor-scope-values-to-context
Move scope values starting with `editor.` to contexts

GitOrigin-RevId: 7ca349ceff002228cf4e931c644c8c386eb6c597
2025-07-09 08:05:15 +00:00
Mathias Jakobsen
b89951cf5d Merge pull request #26814 from overleaf/mj-review-panel-comment-collapse
[web] Fix review panel check for comments in active document

GitOrigin-RevId: fc0c35bc1d2f253c133dec5dcea7f81f68d723a9
2025-07-08 08:06:31 +00:00
Mathias Jakobsen
913caca379 Merge pull request #26850 from overleaf/mj-chat-deleted-user
[web] Handle deleted users in chat threads

GitOrigin-RevId: 6593bf37e4f2339b40069b7cf4198166660852fb
2025-07-08 08:06:17 +00:00
Antoine Clausse
09a534f48b [web] Move scopes permissionsLevel, permissions and hasLintingError to React context (#26607)
* Move `hasLintingError` from scope to react state

* Move `permissionsLevel` to IdeReactContext states

* Get `permissionsLevel` from `useIdeReactContext()`

* Set `permissionsLevel` in mocked `IdeReactProvider`

* Replace `permissions` scope by React state

* Fixup `permission` changes

* Remove redundant type

GitOrigin-RevId: 6203c61f9ac429789624196bf67e508310f4577f
2025-07-07 08:05:36 +00:00
Mathias Jakobsen
e660718c63 Merge pull request #26769 from overleaf/mj-review-mode-switch-focus
[web] Focus editor after changing reviewer mode

GitOrigin-RevId: d19ef178221579894620c5fd204f45c893c126ae
2025-07-04 08:05:08 +00:00
Alf Eaton
06153de0aa Fix Add Comment observer disconnect (#26565)
GitOrigin-RevId: bb84aa25d744a9b035a70c877c934156c2675cbd
2025-07-03 08:05:47 +00:00
Tim Down
904fac958d Merge pull request #26326 from overleaf/td-clean-up-scope-store
Create separate window.overleaf.unstable.store based on React context values

GitOrigin-RevId: 68f070a6fc5e2965a82720024d91b16fa622b28b
2025-07-02 08:05:53 +00:00
Domagoj Kriskovic
04e026904f Hide reviewer options for community edition (#25944)
GitOrigin-RevId: 7eba3d193e3a0ab37006cb42dd945ba40703136f
2025-06-27 08:56:35 +00:00
Domagoj Kriskovic
3b65a674d0 Allow switching reviewing mode for anonymous editors (#26426)
* Revert "Remove reference to track changes ofForGuests"

This reverts commit 675f3864e4bf0a07d24848223814768ab50bfd9b.

* handle track changes for guests

* only send on_for_guests

* update test

GitOrigin-RevId: 15308f0904b26d2ea6a2e57b3852cd2a9b3c886d
2025-06-26 08:05:43 +00:00
Tim Down
ab140f578d Merge pull request #26244 from overleaf/td-limit-browser-translate-ide
Prevent browser translation of stuff that shouldn't be translated in IDE page

GitOrigin-RevId: 96a75b51c3c8efc4cbcec7eb17d9e331a03e2c96
2025-06-24 08:05:32 +00:00
David
b6fe6ae062 Merge pull request #26407 from overleaf/dp-review-panel-gap
Allow comments to be positioned at top of review panel in new editor

GitOrigin-RevId: 581bbf85cc54b68b54235123b14b1564ed019e6d
2025-06-17 08:05:35 +00:00
andrew rumble
52280febf6 When filtering object members from rest use full name
GitOrigin-RevId: 0c21c70b2512931744f18e79c8d9e4bb85e83dfa
2025-06-11 08:06:05 +00:00
andrew rumble
4960569648 Remove unused full arguments
As distinct from removing destructured props.

GitOrigin-RevId: d02ad8d36fb532559ed2899268d7b699f2f2fa37
2025-06-11 08:05:46 +00:00
andrew rumble
eb60d364f6 Fix instances of ...rest filtering
GitOrigin-RevId: 9f2889b08ffed20466d7022a5aba69d3e87c5ed9
2025-06-11 08:05:42 +00:00
David
c450094659 Merge pull request #25804 from overleaf/dp-on-for-guests
Remove references to removed track changes onForGuests option

GitOrigin-RevId: c251ad41633df33f0d963dbc3c2e5cb62920a5e1
2025-05-23 08:05:59 +00:00
Alf Eaton
80897001a5 Add review mode tutorial popover (#25709)
GitOrigin-RevId: bf2a365b21da780786f2736efb0770cea5f5b656
2025-05-22 08:07:03 +00:00
Alf Eaton
ed006b707c Update "Editing" role description (#25641)
GitOrigin-RevId: dba2e4a21ca645ba34d9e41b76f09a287b5c3b33
2025-05-19 12:27:14 +00:00
David
b56556f37b Merge pull request #25547 from overleaf/dp-remove-reviewer-role-flag-frontend
Clean up reviewer-role feature flag from frontend

GitOrigin-RevId: 0cac59be58b0350c24f57d3e63898246b2bd6881
2025-05-16 08:06:00 +00:00
Alf Eaton
bd67b4ca13 Improve review panel entry performance (#25402)
GitOrigin-RevId: 2a6ec8ad432195c6069bb58be37dd93341533817
2025-05-14 08:06:35 +00:00
Mathias Jakobsen
3c3414a7d3 Merge pull request #25435 from overleaf/mj-review-panel-tests
[web] Add review panel cypress tests

GitOrigin-RevId: e953519fc8fed089df59970ee3c745b06d78ddfb
2025-05-12 08:05:52 +00:00
David
32a8142f9c Merge pull request #25211 from overleaf/dp-review-panel-mini-click
Fix bug where clicking on comment/change in mini panel would not open full panel in new editor

GitOrigin-RevId: e7db345e01b881255a1651b37dec637f04692f3e
2025-05-02 08:05:43 +00:00
Tim Down
7abafb01ea Merge pull request #23940 from overleaf/td-react-18
Upgrade to React 18

GitOrigin-RevId: 9b81936e6eea2bccd97fe5c2c5841f0b946371b8
2025-05-02 08:05:29 +00:00
David
bc95219bf6 Merge pull request #24862 from overleaf/dp-check-logs
Create openTab utility in rail-context to open rail at specific tab

GitOrigin-RevId: bfac2597fdd66db6dd8280873be97096f2b812dc
2025-04-16 08:05:01 +00:00
David
9cd7e49daf Merge pull request #24332 from overleaf/dp-review-panel
Add review panel to new editor

GitOrigin-RevId: 918a29d81fcfaf60bc4af8a20a25545d79c4a3ed
2025-04-11 08:05:31 +00:00
Domagoj Kriskovic
0f3f78cde7 Add mouse down listener in PreventSelectingEntry (#24665)
GitOrigin-RevId: 97411fd45d10b850f41c3f6269550bc6fffb0e11
2025-04-08 08:06:41 +00:00
Domagoj Kriskovic
6169a5d3df Update track changes paywall modal (#24620)
* Update track changes paywall modal

* update list styling

GitOrigin-RevId: f5eda3a4b19c89105e163c8b5729ebcdd5dca2d0
2025-04-07 08:04:56 +00:00
M Fahru
ad677afa81 Merge pull request #22705 from overleaf/mf-tear-down-paywall-cta
[web] Tear down `paywall-cta` split test

GitOrigin-RevId: 8cfba819b80bb34f48f8fc1fec37aee6791ef9f0
2025-03-27 14:16:52 +00:00
Domagoj Kriskovic
8fe07b196b Fix import path for UpgradeTrackChangesModal in review mode switcher (#24410)
GitOrigin-RevId: 929c85480d253ff5786d99812f4959683f050b52
2025-03-24 10:49:25 +00:00
Domagoj Kriskovic
7f67df2468 Disable track changes for reviewers in free projects (#24368)
* Disable track changes for reviewers in free projects

* cleanup_unused_locales

GitOrigin-RevId: 806ee20c0aed5ef61352041782af620cec72ed70
2025-03-24 10:49:20 +00:00
David
0895b5c6ee Merge pull request #24405 from overleaf/dp-review-panel-new-cleanup
Remove review-panel-new namespacing css class

GitOrigin-RevId: 3a3f62674763d1b6b4b1a69e6a72b676cdd549c0
2025-03-24 10:48:30 +00:00
Alf Eaton
b8d74c6ae0 Remove 'review-panel-redesign' split test and old code (#24235)
GitOrigin-RevId: 1f3d4a9a51429591a82391a9bee3cfdf226bc9c8
2025-03-24 10:48:15 +00:00
Alf Eaton
9fd4e4ab87 Display changes as additions when only whitespace content is removed (#24296)
GitOrigin-RevId: b6527e8a1c4a73faeed01538212224349ad70614
2025-03-24 10:47:53 +00:00
Alf Eaton
ecc2f1f544 Merge pull request #24196 from overleaf/ae-fetch-data-access
Avoid fetching unavailable project data

GitOrigin-RevId: 58fd58f098af5e3eb000e31f22b403d3e28ef691
2025-03-12 09:05:18 +00:00
Alf Eaton
2147f1d53d Remove Bootstrap 3 code from IDE page components (#23061)
GitOrigin-RevId: b41aff10672bf96e892de0be396a69eb25e2443b
2025-03-07 09:05:45 +00:00
Alf Eaton
763bf34e19 Avoid creating a comment when the main selection is empty (#24063)
GitOrigin-RevId: 8c21dfbcb5f49d196afd0e8730326ee6e0bfbe25
2025-03-07 09:05:25 +00:00
Domagoj Kriskovic
08882c63df Adjust scroll behavior in review panel to account for wrapped lines (#24029)
GitOrigin-RevId: 748f7ffcdd2d0c83132b43de99b10f598227f6b0
2025-03-06 09:05:03 +00:00
Tim Down
cd644320f4 Merge pull request #23998 from overleaf/td-resolved-thread-count
Fix for resolved thread count display

GitOrigin-RevId: c4f6848ed2e952981d20f157466db6dded99c3c9
2025-03-05 09:05:02 +00:00
Domagoj Kriskovic
767eccd1c8 Update projectRanges on "accept-changes" (#23984)
GitOrigin-RevId: f06dd126e3948df41f71a189d97f8d3ad6928a43
2025-03-04 09:04:33 +00:00
Eric Mc Sween
0d9528932c Merge pull request #23900 from overleaf/em-read-only-permissions
Restrict viewer permissions for comments

GitOrigin-RevId: fb7189b8af9358603e29bbd33b0160dd862fe532
2025-03-03 09:05:17 +00:00
Domagoj Kriskovic
598d51c9e7 Prevent focusing review panel entry on resolve/accept/reject (#23859)
GitOrigin-RevId: 91d6725d1ea2a27f1ff93871db745440486b7246
2025-02-26 09:04:16 +00:00
Domagoj Kriskovic
ebab25058a Allow selecting comment text without changing scroll position (#23628)
* Allow selecting comment text without changing scroll position

* cursor:default on review content

* check text selection on mouseup

* update comment

GitOrigin-RevId: f867613f5b4d08c3b960abfa061b14b404f411a8
2025-02-24 09:04:45 +00:00
Domagoj Kriskovic
d8b850f740 Convert track changes to proper format when reviewer role is enabled (#23683)
GitOrigin-RevId: 2ac696804491f61e52b4645dff7f64339c47afc5
2025-02-24 09:04:41 +00:00
David
64bb822e41 Merge pull request #23738 from overleaf/ae-blur-handler-timeout
Wrap "Add Comment" blur action in setTimeout

GitOrigin-RevId: 632555d94c8a33a095f3b9a10089714eeae2d962
2025-02-21 09:04:36 +00:00
Domagoj Kriskovic
725db44392 Change scrollTo behavior when review panel entry is selected (#23720)
GitOrigin-RevId: 86fc08f437c49bdf00a9b7d8461b9476f2e9717f
2025-02-21 09:04:10 +00:00
Eric Mc Sween
483c97a484 Merge pull request #23691 from overleaf/em-resolve-comments-permissions
Add resolveAllComments and resolveOwnComments permissions

GitOrigin-RevId: 1fca9391dc3ff6e890532054582c49f11731e987
2025-02-20 09:05:45 +00:00
Eric Mc Sween
79bb2e3d40 Merge pull request #23673 from overleaf/em-reviewer-role-delete-replies
Let reviewers delete their own comments

GitOrigin-RevId: bd5341a917a3e886dc573d7e42d12343da6700cd
2025-02-19 09:05:21 +00:00
Domagoj Kriskovic
3251ebffdb Move "add comment" widget below edit mode switcher (#23507)
GitOrigin-RevId: cd1ca5b93bba5604ea312133dc2f9166d5fe8c84
2025-02-13 09:05:31 +00:00
Domagoj Kriskovic
0eaa0c47e4 Added new analytics events for reviewer role (#23382)
* Added analytics for review mode switcher

* Added "collaborator-role-change" analytics event to edit-member.tsx

GitOrigin-RevId: 030e9208de088898ef112e951fe301799a27277e
2025-02-11 09:04:37 +00:00
Alf Eaton
294079d55e Remove uses of editor scope values (#23312)
GitOrigin-RevId: 97e2188bc1363618b60f722fa317a5b240d5013b
2025-02-07 09:05:12 +00:00