Commit graph

147 commits

Author SHA1 Message Date
Domagoj Kriskovic
6d45fea773 Add "new-comment-threads" event handler for new review panel (#23298)
GitOrigin-RevId: 00628e6421a563f5157415d235ee5e7c2818e690
2025-02-05 09:06:07 +00:00
Domagoj Kriskovic
6ee3ff63e4 Dont show "add comment" tooltip when text is selected via search (#23341)
* Dont show "add comment" tooltip when text is selected via search

* remove the tooltip if selection changes

* handle empty selection

* use tr.effects.some for mouseUp check

* avoid creating new create function each time

* use useEventListener

GitOrigin-RevId: 18d96fe6fdefcd55f88849cf880f804d4c963f4d
2025-02-05 09:06:02 +00:00
Alf Eaton
87186eb568 Standardise naming of openDocId as openDocWithId or currentDocumentId (#23307)
GitOrigin-RevId: d71b6d878188c7b916f02a3749976ecd96d648a3
2025-02-05 09:05:15 +00:00
Domagoj Kriskovic
f2c6a7ddb4 Refactor review panel position-items function (#22969)
GitOrigin-RevId: 929e7f2b90ac21cb68117d66ca599120cc765fab
2025-02-03 09:05:10 +00:00
Domagoj Kriskovic
97562c0042 Debounce position updates in review panel for improved performance (#23190)
* Debounce position updates in review panel for improved performance

* move debounce inside useMemo

* move 'review-panel:position' inside debounce

GitOrigin-RevId: 2b2d0e59537875f85036b0105ccb1a7d2035c0de
2025-02-03 09:05:05 +00:00
Domagoj Kriskovic
14dedf0101 Prevent adding multiple replies by hitting enter while submitting (#23240)
GitOrigin-RevId: 342aa30f89f3ac0b0b25ab931dd4df1d956aa4a1
2025-02-03 09:05:00 +00:00
Alf Eaton
32a27c14b4 Add memoized FormatTimeBasedOnYear component (#23199)
GitOrigin-RevId: 1f26ca9c0dbbda639939736f1e6a0c236e38a160
2025-02-03 09:04:52 +00:00
Alf Eaton
5e491cc0c0 Use thread id in removeNewCommentRangeEffect (#23205)
GitOrigin-RevId: 6082f5e6d6f548eff43da657526097118a2d3c11
2025-02-03 09:04:48 +00:00
Domagoj Kriskovic
3a918a58e5 Prevent submitting comment on enter if input is empty (#23221)
* Prevent submitting comment on enter if input is empty

* check for content in keyPress event

GitOrigin-RevId: 1abef229782265836a49d74aa93625797d50dc3a
2025-01-30 09:05:26 +00:00
Alf Eaton
1ca47334f7 Throttle range rebuilding on edits (#23193)
GitOrigin-RevId: 86d9465af663c346805445cd57dd6f6e06049d7b
2025-01-30 09:04:47 +00:00
Alf Eaton
90aec12e84 Ensure that review panel components are memoized (#23194)
GitOrigin-RevId: 271b8b00394d6b87fddc503a70f17f8f41144ec7
2025-01-30 09:04:42 +00:00
Alf Eaton
71ab3a41ed Remove ColorManager (#22974)
GitOrigin-RevId: 32cb6fd599345eaf8e474553da5c6d3080575ee8
2025-01-29 09:04:48 +00:00
Domagoj Kriskovic
c300d0adb1 Show "Upgrade to track changes" modal for redesigned review panel (#23003)
GitOrigin-RevId: c4809784783af740d6b7d9fa24110e915c36d794
2025-01-24 09:05:40 +00:00
Alf Eaton
53214d4222 Create shared PanelHeading and CollapsibleFileList components (#22995)
GitOrigin-RevId: ffe524cc0ddf6a1cf532a50f37900b1747b2afee
2025-01-23 09:05:09 +00:00
Domagoj Kriskovic
1072f836ae Hide reply input if no comment permissions (#22955)
GitOrigin-RevId: eeb323e8d7426388f4291906299397f58095b46a
2025-01-21 09:05:58 +00:00
Domagoj Kriskovic
e5a4a8606f Prevent scrolling when reply input is focused (#22968)
* Prevent scrolling when reply textarea is focused

* remove focusIsOnTextarea check as it is handled above

* remove unnecessery setSelected

GitOrigin-RevId: 5ce3fc6691a19fe2566875785607bb4faa3e9f52
2025-01-21 09:05:49 +00:00
Domagoj Kriskovic
58c9f6e76e Hide resolve/edit/delete comment options for users without permissions (#22891)
GitOrigin-RevId: b3d2c1ba03ee836596abfc3da1260dec5a0a7714
2025-01-20 09:04:40 +00:00
Alf Eaton
386d6f8ffd Wrap range building in setTimeout (#22796)
GitOrigin-RevId: a0841e6eb9f2f637653dd0b8a37a61136097cc4f
2025-01-16 09:05:31 +00:00
Domagoj Kriskovic
3d543b20b5 [web] Show most recently resolved comments at the top (#22835)
GitOrigin-RevId: cb42a0fe3d6bf5d23d329b6ef9732f7cb9612907
2025-01-16 09:05:07 +00:00
Domagoj Kriskovic
39d1ba7fe0 Allow rejecting reviewers own track changes (#22793)
* Allow rejecting reviewers own track changes

* reject option only for change authors

GitOrigin-RevId: ecbc5ee9dfe6c468a5df3c1ce7b147561802a8c0
2025-01-14 09:05:25 +00:00
Domagoj Kriskovic
3e11fffaf0 Add delay on showing "Add comment" tooltip (#22600)
GitOrigin-RevId: eb2f2abc368fdba0e85a5611a4c73e3500b6bbb2
2025-01-10 09:04:55 +00:00
David
362521dd1e Show full edit/review mode dropdown on first load (#22465)
* Show full edit/review mode dropdown on first load

* Remove unneeded import

* rename localstorage value, inline event

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 7efb52d4b43588dd1ee8b7a6a5f703166b0c9b3a
2024-12-17 09:04:52 +00:00
David
4a8163b3f3 Add new trackedWrite frontend permission for review panel (#22486)
* Add new trackedWrite frontend permission for review panel

* Fix test lint

* Remove comment

* Fix codemirror tests

* hide file actions for reviewer

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 6aab5c662287a02750d81b3960bbdd9c98b325db
2024-12-17 09:04:48 +00:00
David
f8a1e7c43b Merge pull request #22398 from overleaf/dp-change-edit-mode-ui-part-2
Add ReviewModeSwitcher

GitOrigin-RevId: bfbbdac30530d859da0e8b5673357ba805b100ab
2024-12-12 09:05:06 +00:00
Domagoj Kriskovic
f1c3ddb7c2 Use isReviewerRoleEnabled meta tag (#22437)
GitOrigin-RevId: e2f2529f09936a53087393d8f02968bdb5ea1acc
2024-12-12 09:04:51 +00:00
David
f1893fa03a Show coloured squares next to collaborator names (#22406)
* Change font to content-primary

* Add user colour blocks to comments/track changes

* Format

GitOrigin-RevId: a9186e9c7c95dfe134bee2f756245275cfa9ea24
2024-12-10 13:09:37 +00:00
David
97cdc290c3 Adapt review panel header with new reviewer role (#22291)
* Adapt review panel header with new reviewer role

* Remove duplicate css property

* Update position-items

GitOrigin-RevId: a2e8dac0c1d90e6d5b3f13769909cddd69b5db14
2024-12-10 13:09:33 +00:00
David
524d743d6c Double the max lenght of a comment before truncating (#22409)
GitOrigin-RevId: 8c4314d0b3567e7c4bd963dadf2eb698d3df3565
2024-12-10 13:09:24 +00:00
David
9ed3861c70 Merge pull request #22287 from overleaf/dp-review-safari
Allow review panel entry buttons to be focused in safari

GitOrigin-RevId: 1f9854534394d2561b673857fde186058e4acf49
2024-12-10 09:04:43 +00:00
Domagoj Kriskovic
6a6ef776d5 Revert "Update review entries in overview panel on collaborator changes (#22098)" (#22369)
This reverts commit e2d837efe889170dc055df69eae6b4e8f86cb5fc.

GitOrigin-RevId: e2c8637ffd64fc52f1a9cb36801f8688d42d4e0c
2024-12-09 09:05:00 +00:00
Domagoj Kriskovic
e83963eefc Update review entries in overview panel on collaborator changes (#22098)
* remove unused "total" property

* add missing key

* added socket listeners

* remove accept-changes listener

* not using ranges context in overview

* fix lint error

* added comment

* add accept-changes listener

* rename to removeThreadHandler

* simplify docRanges useEffect

* refactor removeThreadHandler

* refactor accept-changes handler

* delete unnecessery event handlers

* remove edit-message listener

GitOrigin-RevId: e2d837efe889170dc055df69eae6b4e8f86cb5fc
2024-12-09 09:04:56 +00:00
Domagoj Kriskovic
fb45c3c144 Fix onKeyPress listener in AutoExpandingTextArea (#22040)
GitOrigin-RevId: 3fe870fe3aa16e6ed212ea4347a31e57444ad5e6
2024-11-22 09:05:51 +00:00
Domagoj Kriskovic
f72c86e7fe Add "accept-changes" socket listener in ranges context (#22048)
GitOrigin-RevId: 0be5f3be1806aad29f44eec2e596af51e65263e7
2024-11-22 09:05:42 +00:00
Domagoj Kriskovic
99f77b2205 Fixed "Add comment" tooltip if cursor is out of viewport (#21852)
* Fixed "Add comment" tooltip if cursor is out of viewport

* account for cm-line padding when calulation tooltip pos

GitOrigin-RevId: f4b69a3bf83dd15c0304bfd6b37f3be8b07cd727
2024-11-20 09:05:00 +00:00
Domagoj Kriskovic
8a90ffa3fb Add confirm modal on accept/reject selected changes (#21540)
* Add showGenericConfirmModal in ModalsContext

* Add confirm modal on accept/reject selected changes

* plural in translations

* change tooltip to include selected changes

* add _plural to all translated languages

* lowercase title/tooltip

* count replacements as single change

* use new translation key

GitOrigin-RevId: afadbe1eeb2a290688b96f2b5388485f40c958d0
2024-11-12 09:06:01 +00:00
Alf Eaton
76c7c3e28e Fix dirtyState handling in ranges context (#21724)
GitOrigin-RevId: 44f3aa9efc6dbd0d34a2b0440054197398a62caf
2024-11-12 09:05:42 +00:00
Domagoj Kriskovic
8b0b923063 Fix "show more/less" options in new review panel (#21700)
* Fix "show all/less" options in new review panel

* added newLineCharsLimit, inline options

* fix scss lint

GitOrigin-RevId: 98f29c76d4efda225515162cde0961e55acd5545
2024-11-11 09:05:21 +00:00
David
1c7e4ddcd2 Merge pull request #21450 from overleaf/dp-focus-entry
Refactor how ReviewPanel and TrackChangesWidget are rendered

GitOrigin-RevId: 0b206a2a70270a885befdcf2403da4e1af3aa9bf
2024-11-05 09:04:54 +00:00
David
ef90950cd3 Merge pull request #21439 from overleaf/dk-accept-reject-all-tooltip
Added tooltips to "Accept all" and "Reject all" options

GitOrigin-RevId: 62887e4e26964119cbb2c2aa140565c46aba94fe
2024-10-29 09:05:57 +00:00
David
7c613cdceb Merge pull request #21438 from overleaf/dp-edit-comment-popover
Dont select entry from textarea when review panel is mini

GitOrigin-RevId: 5900ae11ec01bb40100e19497557469e6dac1615
2024-10-29 09:05:53 +00:00
David
9d62c620fd Merge pull request #21410 from overleaf/dp-mini-panel-click
Prevent clicking on mini review panel entry popovers from opening the full panel

GitOrigin-RevId: a81ed154307750a756931d9fe5e893cd30d40c55
2024-10-29 09:04:56 +00:00
David
44b2ca1830 Manually force blur on submitting an edited message (#21333)
* Return focus to parent entry element after message is edited

* Revert "Return focus to parent entry element after message is edited"

This reverts commit 96234a666e7e7c17b99a23a8a92ea030efe6083f.

* Manually force blur on submitting an edited message

* Show review panel entry header when editing comment (#21397)

* Show review panel entry header when editing comment

* edit comment spacing

* hide comment options when editing

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 66a8d1ed772cf91ea0f086bd08cdabaeb7456956
2024-10-28 09:05:43 +00:00
Domagoj Kriskovic
29c5bc8206 Focused and selected states for ReviewPanelEntry (#21354)
GitOrigin-RevId: 41e5ed1110d71eae51cbbde1e874dda133d666c8
2024-10-28 09:05:34 +00:00
Domagoj Kriskovic
db23262611 Scroll selection anchor into view when adding new comment (#21328)
* Scroll selection anchor into view when adding new comment

* check if cursor is near viewport edge

GitOrigin-RevId: 57d4195f7ce1513a56249365b45b3959b4ea813f
2024-10-28 09:05:29 +00:00
Domagoj Kriskovic
4bcc7c9602 Update review panel entries on layout resize (#21323)
GitOrigin-RevId: db9b01609a2425952671e30fc20c16de4d3b36a8
2024-10-28 09:05:25 +00:00
David
d74981775c Merge pull request #21283 from overleaf/dp-keyboard-shortcuts
Add missing keyboard shortcuts to new review panel

GitOrigin-RevId: 78e3a63284b62c90e8a3803bd81fdf273f1a2ec9
2024-10-24 08:05:17 +00:00
David
c872d97295 Merge pull request #21250 from overleaf/dp-resolved-comments-ui
UI tweaks for resolved comments menu

GitOrigin-RevId: 23df6f9f0374277c315d2fb9c9940dd92ec19f4e
2024-10-24 08:05:12 +00:00
David
1c5f5950fa Merge pull request #21208 from overleaf/dp-accept-reject-all-changes
Add options to accept/reject all changes to review tooltip

GitOrigin-RevId: 1cea76926d59d0354c8abaa6ba69b7e99c02fbe0
2024-10-24 08:05:08 +00:00
David
c7eafd69c2 Merge pull request #21014 from overleaf/dk-review-panel-tc-widget
Add "Track changes is On" button when review panel is closed

GitOrigin-RevId: a165201f611860ba531f2eeb3d89f83a695cd017
2024-10-22 08:05:50 +00:00
Domagoj Kriskovic
64460681b8 Fix delete comment/thread in the new review panel (#21199)
GitOrigin-RevId: 95d4db64d2f837322d84a81cbd129ec02ee135a2
2024-10-22 08:05:46 +00:00